yupeng9 commented on a change in pull request #6113: URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r501223500
########## File path: pinot-core/src/main/java/org/apache/pinot/core/upsert/UpsertProcessorUtil.java ########## @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.upsert; + +import java.util.Map; +import org.apache.pinot.core.realtime.impl.ThreadSafeMutableRoaringBitmap; +import org.apache.pinot.spi.data.readers.PrimaryKey; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +public final class UpsertProcessorUtil { + private static final Logger LOGGER = LoggerFactory.getLogger(UpsertProcessorUtil.class); + + private UpsertProcessorUtil() { + } + + public static void handleUpsert(PrimaryKey primaryKey, long timestamp, String segmentName, int docId, int partitionId, Review comment: I don't quite buy the concurrency control argument. Static methods are executed concurrently, and if the concurrent access within this block of code is actually on `PartitionUpsertMetadataManager ` access. So from this front, the current way has better concurrency control IMO. Code organization for better clarity is a different perspective, and we can discuss it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
