[incubator-pinot] branch master updated: Support aggregation function name with underscore inside (#5795)

2020-08-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 48d1653 Support aggregation function

[GitHub] [incubator-pinot] fx19880617 merged pull request #5795: Support aggregation function name with underscore inside

2020-08-06 Thread GitBox
fx19880617 merged pull request #5795: URL: https://github.com/apache/incubator-pinot/pull/5795 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5738: HAVING and Post-Aggregation Support

2020-08-06 Thread GitBox
Jackie-Jiang commented on issue #5738: URL: https://github.com/apache/incubator-pinot/issues/5738#issuecomment-670353290 QueryContext support: #5827 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5827: Support post-aggregation in QueryContext

2020-08-06 Thread GitBox
Jackie-Jiang opened a new pull request #5827: URL: https://github.com/apache/incubator-pinot/pull/5827 ## Description Support post-aggregation in QueryContext - Be able to extract aggregation functions within post-aggregation function (modeled as transform) - Store a map from the A

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5738: HAVING and Post-Aggregation Support

2020-08-06 Thread GitBox
Jackie-Jiang commented on issue #5738: URL: https://github.com/apache/incubator-pinot/issues/5738#issuecomment-670351695 Sql parser support: https://github.com/apache/incubator-pinot/pull/5825 This is an automated message fr

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5825: Enhance sql parser for having and post-aggregation

2020-08-06 Thread GitBox
Jackie-Jiang commented on a change in pull request #5825: URL: https://github.com/apache/incubator-pinot/pull/5825#discussion_r466830248 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -74,6 +74,11 @@ * non-alphanumeric cha

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5825: Enhance sql parser for having and post-aggregation

2020-08-06 Thread GitBox
Jackie-Jiang commented on a change in pull request #5825: URL: https://github.com/apache/incubator-pinot/pull/5825#discussion_r466830127 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -397,7 +403,8 @@ private static void rewr

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5825: Enhance sql parser for having and post-aggregation

2020-08-06 Thread GitBox
Jackie-Jiang commented on pull request #5825: URL: https://github.com/apache/incubator-pinot/pull/5825#issuecomment-670334309 > Would be nice to have a dedicated test for flattening. @mayankshriv You mean a separate test class? IMO having a separate test in `CalciteSqlParser` for fla

[GitHub] [incubator-pinot] jackjlli opened a new pull request #5826: Identify if the values are converted from map and emit server metric

2020-08-06 Thread GitBox
jackjlli opened a new pull request #5826: URL: https://github.com/apache/incubator-pinot/pull/5826 ## Description Currently there are some existing use cases who use map structure for columns in the raw data during segment creation, while map structure support isn't completely done yet.

[GitHub] [incubator-pinot] suvodeep-pyne edited a comment on pull request #5808: [TE] Dashboard Resource Refactor

2020-08-06 Thread GitBox
suvodeep-pyne edited a comment on pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#issuecomment-670270234 @jihaozh @akshayrai The way this was validated is by doing a diff between an existing set of APIs and the current set. This is logged by dropwizard during

[incubator-pinot] 01/01: Identify whether the values are converted from map and emit server metric

2020-08-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch add-virtual-key-to-segment-metadata in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit ac6e64709416f0422d90502c691a3d9e7b6c248f Author: Jack Li(Analytics Engineering) Auth

[incubator-pinot] branch add-virtual-key-to-segment-metadata created (now ac6e647)

2020-08-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-virtual-key-to-segment-metadata in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at ac6e647 Identify whether the values are converted from map and emit server metr

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5825: Enhance sql parser for having and post-aggregation

2020-08-06 Thread GitBox
mayankshriv commented on a change in pull request #5825: URL: https://github.com/apache/incubator-pinot/pull/5825#discussion_r466798962 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -74,6 +74,11 @@ * non-alphanumeric char

[GitHub] [incubator-pinot] suvodeep-pyne commented on a change in pull request #5808: [TE] Dashboard Resource Refactor

2020-08-06 Thread GitBox
suvodeep-pyne commented on a change in pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#discussion_r466773098 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java ## @@ -139,36 +11

[GitHub] [incubator-pinot] suvodeep-pyne commented on a change in pull request #5808: [TE] Dashboard Resource Refactor

2020-08-06 Thread GitBox
suvodeep-pyne commented on a change in pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#discussion_r466773098 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java ## @@ -139,36 +11

[GitHub] [incubator-pinot] suvodeep-pyne commented on a change in pull request #5808: [TE] Dashboard Resource Refactor

2020-08-06 Thread GitBox
suvodeep-pyne commented on a change in pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#discussion_r466770549 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java ## @@ -139,36 +11

[GitHub] [incubator-pinot] suvodeep-pyne edited a comment on pull request #5808: [TE] Dashboard Resource Refactor

2020-08-06 Thread GitBox
suvodeep-pyne edited a comment on pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#issuecomment-670270234 @jihaozh @akshayrai The way this was validated is by doing a diff between an existing set of APIs and the current set. ``` GET /alerts

[GitHub] [incubator-pinot] suvodeep-pyne commented on a change in pull request #5808: [TE] Dashboard Resource Refactor

2020-08-06 Thread GitBox
suvodeep-pyne commented on a change in pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#discussion_r466770549 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java ## @@ -139,36 +11

[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #5808: [TE] Dashboard Resource Refactor

2020-08-06 Thread GitBox
suvodeep-pyne commented on pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#issuecomment-670270234 @jihaozh @akshayrai The way this was validated is by doing a diff between an existing set of APIs and the current set. ``` GET /alerts (org.ap

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5825: Enhance sql parser for having and post-aggregation

2020-08-06 Thread GitBox
Jackie-Jiang opened a new pull request #5825: URL: https://github.com/apache/incubator-pinot/pull/5825 ## Description Enhance sql parser for having and post-aggregation In `CalciteSqlParser`: - Support parsing HAVING clause - Flatten AND/OR expression - Simplify `compileCa

[GitHub] [incubator-pinot] npawar commented on pull request #5793: Tiered storage

2020-08-06 Thread GitBox
npawar commented on pull request #5793: URL: https://github.com/apache/incubator-pinot/pull/5793#issuecomment-670244811 > Well done. > Most comments are minor (comments in `OfflineSegmentAssignment` also applies to `RealtimeSegmentAssignment`). > Please merge the 2 relocators into one

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5793: Tiered storage

2020-08-06 Thread GitBox
npawar commented on a change in pull request #5793: URL: https://github.com/apache/incubator-pinot/pull/5793#discussion_r466742688 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/tier/TieredStorageRelocator.java ## @@ -0,0 +1,101 @@ +/** + *

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5793: Tiered storage

2020-08-06 Thread GitBox
npawar commented on a change in pull request #5793: URL: https://github.com/apache/incubator-pinot/pull/5793#discussion_r466742315 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/OfflineSegmentAssignment.java ## @@ -91,6 +

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5793: Tiered storage

2020-08-06 Thread GitBox
npawar commented on a change in pull request #5793: URL: https://github.com/apache/incubator-pinot/pull/5793#discussion_r466742218 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/OfflineSegmentAssignment.java ## @@ -82,6 +

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5793: Tiered storage

2020-08-06 Thread GitBox
npawar commented on a change in pull request #5793: URL: https://github.com/apache/incubator-pinot/pull/5793#discussion_r466742018 ## File path: pinot-common/src/main/java/org/apache/pinot/common/assignment/InstanceAssignmentConfigUtils.java ## @@ -50,6 +50,13 @@ public static

[GitHub] [incubator-pinot] jasperjiaguo commented on a change in pull request #5774: Config recommendation engine

2020-08-06 Thread GitBox
jasperjiaguo commented on a change in pull request #5774: URL: https://github.com/apache/incubator-pinot/pull/5774#discussion_r466730931 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/io/params/PartitionRuleParams.java ## @@ -0,0 +1,

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5808: [TE] Dashboard Resource Refactor

2020-08-06 Thread GitBox
jihaozh commented on a change in pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#discussion_r466707307 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java ## @@ -139,36 +114,11 @

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5823: [TE] enchance anomaly api to propagate feedback

2020-08-06 Thread GitBox
jihaozh commented on a change in pull request #5823: URL: https://github.com/apache/incubator-pinot/pull/5823#discussion_r466705333 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/bao/jdbc/MergedAnomalyResultManagerImpl.java ## @@ -456,6

[GitHub] [incubator-pinot] jihaozh opened a new pull request #5824: [TE] UI - Anomalies page v3

2020-08-06 Thread GitBox
jihaozh opened a new pull request #5824: URL: https://github.com/apache/incubator-pinot/pull/5824 This PR updates the ThirdEye anomalies page, including the following changes. - Move the filtering, searching, and pagination to the backend endpoint. Update UI according to the response

[GitHub] [incubator-pinot] jasonyanwenl commented on a change in pull request #5769: [TE] add anomaly detection as a service - Phase 1

2020-08-06 Thread GitBox
jasonyanwenl commented on a change in pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769#discussion_r466671941 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java ## @@ -0,0 +1,756

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #5823: [TE] enchance anomaly api to propagate feedback

2020-08-06 Thread GitBox
vincentchenjl opened a new pull request #5823: URL: https://github.com/apache/incubator-pinot/pull/5823 This PR is to enhance the anomaly feedback api so that it propagates the feedback to the parent of the specified anomaly and its siblings if the `propagate` flag is set. -

[GitHub] [incubator-pinot] jasperjiaguo commented on a change in pull request #5774: Config recommendation engine

2020-08-06 Thread GitBox
jasperjiaguo commented on a change in pull request #5774: URL: https://github.com/apache/incubator-pinot/pull/5774#discussion_r466638540 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -0,0 +1,519 @@ +/** + * Lice

[GitHub] [incubator-pinot] jasperjiaguo commented on a change in pull request #5774: Config recommendation engine

2020-08-06 Thread GitBox
jasperjiaguo commented on a change in pull request #5774: URL: https://github.com/apache/incubator-pinot/pull/5774#discussion_r466638254 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/BloomFilterRule.java ## @@ -0,0 +1,142 @@ +/

[GitHub] [incubator-pinot] jasperjiaguo commented on a change in pull request #5774: Config recommendation engine

2020-08-06 Thread GitBox
jasperjiaguo commented on a change in pull request #5774: URL: https://github.com/apache/incubator-pinot/pull/5774#discussion_r466638116 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/NoDictionaryOnHeapDictionaryJointRule.java #

[GitHub] [incubator-pinot] jasperjiaguo commented on a change in pull request #5774: Config recommendation engine

2020-08-06 Thread GitBox
jasperjiaguo commented on a change in pull request #5774: URL: https://github.com/apache/incubator-pinot/pull/5774#discussion_r466637820 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/io/params/PartitionRuleParams.java ## @@ -0,0 +1,

[GitHub] [incubator-pinot] jasperjiaguo commented on a change in pull request #5774: Config recommendation engine

2020-08-06 Thread GitBox
jasperjiaguo commented on a change in pull request #5774: URL: https://github.com/apache/incubator-pinot/pull/5774#discussion_r466637759 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/io/params/RecommenderConstants.java ## @@ -0,0 +1

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5822: Avoid variable substitution in metadata

2020-08-06 Thread GitBox
Jackie-Jiang merged pull request #5822: URL: https://github.com/apache/incubator-pinot/pull/5822 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[incubator-pinot] branch master updated: Avoid variable substitution in metadata (#5822)

2020-08-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new ae2bd2f Avoid variable substitution in

[GitHub] [incubator-pinot] sajjad-moradi commented on pull request #5821: Enable segment decryption for encrypted segments in Minion

2020-08-06 Thread GitBox
sajjad-moradi commented on pull request #5821: URL: https://github.com/apache/incubator-pinot/pull/5821#issuecomment-670137789 > Do we have test for the flow where minion uploads decrypted segment, but controller encrypts it? Minion uses `FileUploadDownloadClient` to upload segment t

[GitHub] [incubator-pinot] suvodeep-pyne commented on a change in pull request #5808: [TE] Dashboard Resource Refactor

2020-08-06 Thread GitBox
suvodeep-pyne commented on a change in pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#discussion_r466610993 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/RootResource.java ## @@ -0,0 +1,201 @@ +/

[GitHub] [incubator-pinot] suvodeep-pyne commented on a change in pull request #5808: [TE] Dashboard Resource Refactor

2020-08-06 Thread GitBox
suvodeep-pyne commented on a change in pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#discussion_r466602375 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java ## @@ -139,36 +11

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5822: Avoid variable substitution in metadata

2020-08-06 Thread GitBox
Jackie-Jiang opened a new pull request #5822: URL: https://github.com/apache/incubator-pinot/pull/5822 ## Description In the segment metadata and column metadata, we always store the actual value in the property file and never use variable substitution (`${anotherKey}`). Using variable

[incubator-pinot] branch support_aggregation_function_name_with_underscore updated (a7079f3 -> fe1f80a)

2020-08-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch support_aggregation_function_name_with_underscore in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard a7079f3 Simplify the handling add fe1f80a Simplify the ha

[incubator-pinot] branch new-anomalies-page-ui updated (20a747f -> 56b86f5)

2020-08-06 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch new-anomalies-page-ui in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 20a747f ui for new anomalies page add 17a3873 Improve performance of DistinctCountTheta

[incubator-pinot] 01/01: ui for new anomalies page

2020-08-06 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch new-anomalies-page-ui in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 56b86f503de7adce72dc5c8f88803dda064676df Author: Jihao Zhang AuthorDate: Wed Aug 5 11:11:17 2020

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5808: [TE] Dashboard Resource Refactor

2020-08-06 Thread GitBox
jihaozh commented on a change in pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#discussion_r466589749 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/RootResource.java ## @@ -0,0 +1,201 @@ +/* + *

[incubator-pinot] branch support_aggregation_function_name_with_underscore updated (3e4fdc0 -> a7079f3)

2020-08-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch support_aggregation_function_name_with_underscore in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 3e4fdc0 Change ST_Union AggregationType enum to STUnion ad

[GitHub] [incubator-pinot] kishoreg merged pull request #5758: Pradeep/sr ssl fix

2020-08-06 Thread GitBox
kishoreg merged pull request #5758: URL: https://github.com/apache/incubator-pinot/pull/5758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated: Pradeep/sr ssl fix (#5758)

2020-08-06 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 2e08602 Pradeep/sr ssl fix (#5758) 2

[GitHub] [incubator-pinot] sajjad-moradi opened a new pull request #5821: Enable segment decryption for encrypted segments in Minion

2020-08-06 Thread GitBox
sajjad-moradi opened a new pull request #5821: URL: https://github.com/apache/incubator-pinot/pull/5821 Minion downloads segments locally and purges (or modifies) records of the segments. If segments are encrypted, Minion needs to decrypt them before applying any purge (or modification). D

[GitHub] [incubator-pinot] lgo closed issue #5819: Query execution error when grouping by multi-value string and non-dictionary encoded string dimension

2020-08-06 Thread GitBox
lgo closed issue #5819: URL: https://github.com/apache/incubator-pinot/issues/5819 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [incubator-pinot] lgo commented on issue #5819: Query execution error when grouping by multi-value string and non-dictionary encoded string dimension

2020-08-06 Thread GitBox
lgo commented on issue #5819: URL: https://github.com/apache/incubator-pinot/issues/5819#issuecomment-669991246 egh, github 404'd the first time -- closing this as it's a dupe of #5820. This is an automated message from the

[GitHub] [incubator-pinot] lgo opened a new issue #5820: Query execution error when grouping by multi-value dimension and non-dictionary encoded dimension

2020-08-06 Thread GitBox
lgo opened a new issue #5820: URL: https://github.com/apache/incubator-pinot/issues/5820 I've been playing around with queries and ran into an execution problem (this isn't really blocking anything, just doing toying with table setups). Specifically, it seems to happen when a query is grou

[GitHub] [incubator-pinot] lgo opened a new issue #5819: Query execution error when grouping by multi-value string and non-dictionary encoded string dimension

2020-08-06 Thread GitBox
lgo opened a new issue #5819: URL: https://github.com/apache/incubator-pinot/issues/5819 I've been playing around with queries and ran into an execution problem (this isn't really blocking anything, just doing toying with table setups). Specifically, it seems to happen when a query is grou

[incubator-pinot] branch support_aggregation_function_name_with_underscore updated (8912099 -> 3e4fdc0)

2020-08-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch support_aggregation_function_name_with_underscore in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 8912099 Support aggregation function name with underscore insi