[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5533: [TE] frontend - harleyjj/alert-details - handle Composite Alerts in A…

codecov-commenter edited a comment on pull request #5533: URL: https://github.com/apache/incubator-pinot/pull/5533#issuecomment-641760851 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5533?src=pr&el=h1) Report > Merging [#5533](https://codecov.io/gh/apache/incubator-pin

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5532: Fixing grep thirdeye changes in github action scripts

codecov-commenter edited a comment on pull request #5532: URL: https://github.com/apache/incubator-pinot/pull/5532#issuecomment-641673683 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5532?src=pr&el=h1) Report > Merging [#5532](https://codecov.io/gh/apache/incubator-pin

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5461: Adding Support for SQL CASE Statement

codecov-commenter edited a comment on pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#issuecomment-641758773 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5461?src=pr&el=h1) Report > Merging [#5461](https://codecov.io/gh/apache/incubator-pin

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5532: Fixing grep thirdeye changes in github action scripts

codecov-commenter edited a comment on pull request #5532: URL: https://github.com/apache/incubator-pinot/pull/5532#issuecomment-641673683 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5532?src=pr&el=h1) Report > Merging [#5532](https://codecov.io/gh/apache/incubator-pin

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5533: [TE] frontend - harleyjj/alert-details - handle Composite Alerts in A…

codecov-commenter commented on pull request #5533: URL: https://github.com/apache/incubator-pinot/pull/5533#issuecomment-641760851 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5533?src=pr&el=h1) Report > Merging [#5533](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5461: Adding Support for SQL CASE Statement

codecov-commenter commented on pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#issuecomment-641758773 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5461?src=pr&el=h1) Report > Merging [#5461](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] haibow merged pull request #5529: Update license and notice for 0.4.0 release

haibow merged pull request #5529: URL: https://github.com/apache/incubator-pinot/pull/5529 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-pinot] branch master updated (2d28c0f -> bbc3228)

This is an automated email from the ASF dual-hosted git repository. haibow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 2d28c0f Enhance quickstart script for CI tests (#5508) add bbc3228 Update license and notice for 0.4.

[GitHub] [incubator-pinot] haibow commented on a change in pull request #5529: Update license and notice for 0.4.0 release

haibow commented on a change in pull request #5529: URL: https://github.com/apache/incubator-pinot/pull/5529#discussion_r437882392 ## File path: licenses-binary/LICENSE-gpl-2.0.txt ## @@ -0,0 +1,641 @@ +Apache Pinot (incubating) Review comment: Thanks for catching it!

[GitHub] [incubator-pinot] harleyjj opened a new pull request #5533: [TE] frontend - harleyjj/alert-details - handle Composite Alerts in A…

harleyjj opened a new pull request #5533: URL: https://github.com/apache/incubator-pinot/pull/5533 …lert Overview ## Description * Doesn't show graph for composite alerts in Alert Overview. * Removes RCA link for composite anomalies on Alert Overview. -

[incubator-pinot] branch support_case_when_statement updated (9fbd589 -> eeccadb)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch support_case_when_statement in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 9fbd589 update case statement to skip some conditions won't happen discard ebc1c27

[incubator-pinot] branch release-0.4.0-update-binary updated (0872dbc -> 21b7604)

This is an automated email from the ASF dual-hosted git repository. haibow pushed a change to branch release-0.4.0-update-binary in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 0872dbc Update license add 21b7604 Update license No new revisions were added b

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5513: Return Select only Literal Expression at Broker

codecov-commenter edited a comment on pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5513?src=pr&el=h1) Report > Merging [#5513](https://codecov.io/gh/apache/incubator-pin

[incubator-pinot] branch master updated: Enhance quickstart script for CI tests (#5508)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 2d28c0f Enhance quickstart script for

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5508: Enhance quickstart script for CI tests

Jackie-Jiang merged pull request #5508: URL: https://github.com/apache/incubator-pinot/pull/5508 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5513: Return Select only Literal Expression at Broker

codecov-commenter edited a comment on pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5513?src=pr&el=h1) Report > Merging [#5513](https://codecov.io/gh/apache/incubator-pin

[incubator-pinot] branch support_case_when_statement updated (012776a -> 9fbd589)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch support_case_when_statement in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 012776a update case statement to skip some conditions won't happen discard 496c44c

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437853396 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@ +/**

[incubator-pinot] branch support_case_when_statement updated (496c44c -> 012776a)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch support_case_when_statement in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 496c44c Address comments add 012776a update case statement to skip some conditi

[incubator-pinot] branch pinot_query_literal_only updated (a579612 -> c682c95)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch pinot_query_literal_only in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard a579612 Address comments discard 89c1eff Support Selection Literal only queries a

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5532: Fixing grep thirdeye changes in github action scripts

codecov-commenter edited a comment on pull request #5532: URL: https://github.com/apache/incubator-pinot/pull/5532#issuecomment-641673683 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5532?src=pr&el=h1) Report > Merging [#5532](https://codecov.io/gh/apache/incubator-pin

[incubator-pinot] branch master updated: Fix the failure caused by Reflections in FunctionRegistry (#5531)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 5390698 Fix the failure caused by Refl

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

Jackie-Jiang merged pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

codecov-commenter commented on pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#issuecomment-641673684 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5531?src=pr&el=h1) Report > Merging [#5531](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5532: Fixing grep thirdeye changes in github action scripts

codecov-commenter commented on pull request #5532: URL: https://github.com/apache/incubator-pinot/pull/5532#issuecomment-641673683 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5532?src=pr&el=h1) Report > Merging [#5532](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

Jackie-Jiang commented on pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-641663429 @kishoreg @mayankshriv @siddharthteotia This PR is ready for review. This is an automated message f

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5532: Fixing grep thirdeye changes in github action scripts

Jackie-Jiang commented on a change in pull request #5532: URL: https://github.com/apache/incubator-pinot/pull/5532#discussion_r437804646 ## File path: .github/workflows/scripts/.pinot_test.sh ## @@ -44,17 +44,9 @@ if [ $? -eq 0 ]; then fi Review comment: line 38-44 c

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5513: Return Select only Literal Expression at Broker

codecov-commenter edited a comment on pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5513?src=pr&el=h1) Report > Merging [#5513](https://codecov.io/gh/apache/incubator-pin

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5513: Return Select only Literal Expression at Broker

codecov-commenter edited a comment on pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5513?src=pr&el=h1) Report > Merging [#5513](https://codecov.io/gh/apache/incubator-pin

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5513: Return Select only Literal Expression at Broker

codecov-commenter commented on pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5513?src=pr&el=h1) Report > Merging [#5513](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5532: Fixing grep thirdeye changes in github action scripts

Jackie-Jiang commented on a change in pull request #5532: URL: https://github.com/apache/incubator-pinot/pull/5532#discussion_r437784293 ## File path: .github/workflows/scripts/.pinot_test.sh ## @@ -25,7 +25,7 @@ java -version COMMIT_BEFORE=$(jq -r ".pull_request.base.sha" "${

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5510: Remove BlockValIterator and directly read values from BlockValSet with docId

Jackie-Jiang merged pull request #5510: URL: https://github.com/apache/incubator-pinot/pull/5510 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[incubator-pinot] branch master updated: Remove BlockValIterator and directly read values from BlockValSet with docId (#5510)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new a1a2434 Remove BlockValIterator and di

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5532: Fixing grep thirdeye changes in github action scripts

fx19880617 opened a new pull request #5532: URL: https://github.com/apache/incubator-pinot/pull/5532 ## Description Fixing grep thirdeye changes in github action scripts This is an automated message from the Apache Git Ser

[incubator-pinot] branch pinot_query_literal_only updated (09e54fb -> a579612)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch pinot_query_literal_only in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 09e54fb Address comments add a579612 Address comments This update added new revis

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437774641 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -435,6 +455,115 @@ static

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5508: Fix Travis quickstart tests

Jackie-Jiang commented on a change in pull request #5508: URL: https://github.com/apache/incubator-pinot/pull/5508#discussion_r437773389 ## File path: .travis/.travis_quickstart.sh ## @@ -30,60 +30,75 @@ java -version # Quickstart DIST_BIN_DIR=`ls -d pinot-distribution/targ

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437772483 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -278,7 +278,9 @@ private static PinotQuery

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437772483 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -278,7 +278,9 @@ private static PinotQuery

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437772150 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -435,6 +455,115 @@ static

[incubator-pinot] branch pinot_query_literal_only updated (c1da5c0 -> 09e54fb)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch pinot_query_literal_only in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard c1da5c0 Address comments add 09e54fb Address comments This update added new revis

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437771739 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java ## @@ -318,6 +317,37

[incubator-pinot] branch pinot_query_literal_only updated (1fabecc -> c1da5c0)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch pinot_query_literal_only in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 1fabecc Address comments discard e3392d7 Support Selection Literal only queries a

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437766763 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -184,6 +192,18 @@ public B

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5461: Adding Support for SQL CASE Statement

Jackie-Jiang commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437766091 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@ +/*

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5513: Return Select only Literal Expression at Broker

Jackie-Jiang commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437758422 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -435,6 +455,115 @@ stati

[GitHub] [incubator-pinot] mcvsubbu commented on pull request #5512: [CI] Adding github actions for pinot tests

mcvsubbu commented on pull request #5512: URL: https://github.com/apache/incubator-pinot/pull/5512#issuecomment-641612903 > > Let's keep both Github Action and Travis running for a while until we feel Github Action is stable enough to kill Travis completely. > > Agreed, we can let bo

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5476: Improve error message on NPE related to typo in star schema column names

Jackie-Jiang commented on a change in pull request #5476: URL: https://github.com/apache/incubator-pinot/pull/5476#discussion_r437753947 ## File path: pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java ## @@ -150,7 +151,11 @@ /

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

Jackie-Jiang commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437750886 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java ## @@ -39,62 +38,63 @@ */ public class Fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

Jackie-Jiang commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437749424 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -667,21 +666,23 @@ protected static Expres

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

sajjad-moradi commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437740412 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java ## @@ -39,62 +38,63 @@ */ public class F

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

Jackie-Jiang commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437745012 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java ## @@ -39,62 +38,63 @@ */ public class Fu

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

Jackie-Jiang commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437743484 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java ## @@ -39,62 +38,63 @@ */ public class Fu

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

mcvsubbu commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437729537 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java ## @@ -39,62 +38,63 @@ */ public class Functi

[incubator-pinot] branch master updated (15fda7f -> 5b3837c)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 15fda7f Update Pinot quickstart to use sql mode (#5530) add 5b3837c Adding github actions for pinot

[GitHub] [incubator-pinot] fx19880617 merged pull request #5512: [CI] Adding github actions for pinot tests

fx19880617 merged pull request #5512: URL: https://github.com/apache/incubator-pinot/pull/5512 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-pinot] fx19880617 commented on pull request #5512: [CI] Adding github actions for pinot tests

fx19880617 commented on pull request #5512: URL: https://github.com/apache/incubator-pinot/pull/5512#issuecomment-641587051 > Let's keep both Github Action and Travis running for a while until we feel Github Action is stable enough to kill Travis completely. Agreed, we can let both r

[incubator-pinot] branch master updated (2b09676 -> 15fda7f)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 2b09676 One to many records from record reader/decoder (#5430) add 15fda7f Update Pinot quickstart t

[GitHub] [incubator-pinot] fx19880617 merged pull request #5530: Update Pinot quickstart to use sql mode

fx19880617 merged pull request #5530: URL: https://github.com/apache/incubator-pinot/pull/5530 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-pinot] fx19880617 closed issue #5516: Move quickstart examples to use SQL Mode

fx19880617 closed issue #5516: URL: https://github.com/apache/incubator-pinot/issues/5516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

mayankshriv commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437703543 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java ## @@ -39,62 +38,63 @@ */ public class Fun

[GitHub] [incubator-pinot] mayankshriv commented on pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

mayankshriv commented on pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#issuecomment-641553854 Thanks a lot for identifying this issue, and providing a fix. Could you please elaborate a bit on how the thread safety issue leads to query compilation error? ---

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

Jackie-Jiang opened a new pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531 The problem is caused by Reflections library not being thread-safe when multiple threads are accessing the same jar file. Read more about the thread-safety issue here: https://github.c

[GitHub] [incubator-pinot] snleee commented on pull request #5512: [CI] Adding github actions for pinot tests

snleee commented on pull request #5512: URL: https://github.com/apache/incubator-pinot/pull/5512#issuecomment-641543455 +1 on 20 concurrent jobs. @jackjlli Can you review this PR and make sure that our CRON job is also correctly migrated to Github Action? -

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5529: Update license and notice for 0.4.0 release

snleee commented on a change in pull request #5529: URL: https://github.com/apache/incubator-pinot/pull/5529#discussion_r437687448 ## File path: licenses-binary/LICENSE-gpl-2.0.txt ## @@ -0,0 +1,641 @@ +Apache Pinot (incubating) Review comment: This is not the license f

[GitHub] [incubator-pinot] npawar merged pull request #5430: One to many records from record reader/decoder

npawar merged pull request #5430: URL: https://github.com/apache/incubator-pinot/pull/5430 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-pinot] branch master updated: One to many records from record reader/decoder (#5430)

This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 2b09676 One to many records from re

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437654871 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@ +/**

[incubator-pinot] branch support_case_when_statement updated (82955f6 -> 496c44c)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch support_case_when_statement in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 82955f6 Address comments add 496c44c Address comments This update added new re

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437650377 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@ +/**

[incubator-pinot] branch support_case_when_statement updated (d6c0ca8 -> 82955f6)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch support_case_when_statement in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard d6c0ca8 Address comments add 82955f6 Address comments This update added new re

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437650377 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@ +/**

[GitHub] [incubator-pinot] mcvsubbu merged pull request #5506: Moved StreamPartitionMsgOffset to be an interface

mcvsubbu merged pull request #5506: URL: https://github.com/apache/incubator-pinot/pull/5506 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] akshayrai opened a new pull request #5515: [TE] Add data quality/sla rule to the detection template

akshayrai opened a new pull request #5515: URL: https://github.com/apache/incubator-pinot/pull/5515 * Add sla rule to the detection onboarding template This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5336: [Part 4] Deep-store bypass for LLC: Add a peer to peer segment fetcher.

mcvsubbu commented on a change in pull request #5336: URL: https://github.com/apache/incubator-pinot/pull/5336#discussion_r436849376 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java ## @@ -268,20 +273,81 @@ public

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5476: Improve error message on NPE related to typo in star schema column names

snleee commented on a change in pull request #5476: URL: https://github.com/apache/incubator-pinot/pull/5476#discussion_r437027028 ## File path: pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java ## @@ -150,7 +151,11 @@ // Igno

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5514: Add integration test for theta sketches

mayankshriv commented on a change in pull request #5514: URL: https://github.com/apache/incubator-pinot/pull/5514#discussion_r436750863 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ThetaSketchIntegrationTest.java ## @@ -0,0 +1,263 @@ +

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5513: Return Select only Literal Expression at Broker

Jackie-Jiang commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437008430 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -184,6 +192,18 @@ public

[GitHub] [incubator-pinot] akshayrai opened a new issue #5519: [Preview][UI] New Settings Anomalies on the time-series legend is confusing

akshayrai opened a new issue #5519: URL: https://github.com/apache/incubator-pinot/issues/5519 In the UI legend rephrase New Settings Anomalies to anomalies **Priority:** Low **Solution:** “Current Anomalies” -> “Anomalies” “New Setting Anomalies” -> “Preview Anomalies”

[GitHub] [incubator-pinot] mayankshriv commented on pull request #5511: WIP: Support LITTLE ENDIAN indexes

mayankshriv commented on pull request #5511: URL: https://github.com/apache/incubator-pinot/pull/5511#issuecomment-640681656 Interesting, I was under the impression that JVM is big-endian regardless of the host endianness. Would be good if you can share any stats on the speed up seen in ra

[GitHub] [incubator-pinot] akshayrai opened a new issue #5526: [TE-demo][Backend] cannot run frontend and backend simultaneously in demo mode

akshayrai opened a new issue #5526: URL: https://github.com/apache/incubator-pinot/issues/5526 Currently we cannot run backend and frontend at the same time as it will lock the h2 db. can we think of another approach? **Priority:** N/A **Solution:** h2 is only for demo frontend. W

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5430: One to many records from record reader/decoder

kishoreg commented on a change in pull request #5430: URL: https://github.com/apache/incubator-pinot/pull/5430#discussion_r436887390 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -466,19 +469,28 @@ pr

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5515: [TE] Add data quality/sla rule to the detection template

akshayrai commented on a change in pull request #5515: URL: https://github.com/apache/incubator-pinot/pull/5515#discussion_r436891442 ## File path: thirdeye/thirdeye-frontend/app/utils/yaml-tools.js ## @@ -11,24 +11,29 @@ dataset: dataset_to_which_this_metric_belongs # Configu

[GitHub] [incubator-pinot] akshayrai opened a new issue #5517: UI - [RCA] refresh and open a fresh rca tab for new metrics

akshayrai opened a new issue #5517: URL: https://github.com/apache/incubator-pinot/issues/5517 UI - [RCA] After feeding a metric on the RCA page, it is hard to go back and view the rca for another metric. The page automatically loads the previous metric unless we manually modify the url.

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5513: Return Select only Literal Expression at Broker

mayankshriv commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r436764713 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -435,6 +455,116 @@ static

[GitHub] [incubator-pinot] akshayrai merged pull request #5515: [TE] Add data quality/sla rule to the detection template

akshayrai merged pull request #5515: URL: https://github.com/apache/incubator-pinot/pull/5515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #5515: [TE] Add data quality/sla rule to the detection template

xiaohui-sun commented on a change in pull request #5515: URL: https://github.com/apache/incubator-pinot/pull/5515#discussion_r436876820 ## File path: thirdeye/thirdeye-frontend/app/utils/yaml-tools.js ## @@ -11,24 +11,29 @@ dataset: dataset_to_which_this_metric_belongs # Confi

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5336: [Part 4] Deep-store bypass for LLC: Add a peer to peer segment fetcher.

chenboat commented on a change in pull request #5336: URL: https://github.com/apache/incubator-pinot/pull/5336#discussion_r437074675 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java ## @@ -268,20 +273,81 @@ public

[GitHub] [incubator-pinot] siddharthteotia merged pull request #5503: Config for raw index writer version

siddharthteotia merged pull request #5503: URL: https://github.com/apache/incubator-pinot/pull/5503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5502: Support expression as the left-hand side for BETWEEN and IN clause

Jackie-Jiang merged pull request #5502: URL: https://github.com/apache/incubator-pinot/pull/5502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-pinot] akshayrai opened a new issue #5524: [Subscription Group][UI] Hide the internal subscription group id on the UI

akshayrai opened a new issue #5524: URL: https://github.com/apache/incubator-pinot/issues/5524 Do not display the internal subscription id in the subscription list. It is very misleading. People will think it is the number of anomalies or alerts etc. **Priority:** Low **Solution:*

[GitHub] [incubator-pinot] akshayrai opened a new pull request #5528: [TE] Add maxValueDaily and maxValueHourly data filters

akshayrai opened a new pull request #5528: URL: https://github.com/apache/incubator-pinot/pull/5528 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5482: Change a NPE to have a better error message

snleee commented on a change in pull request #5482: URL: https://github.com/apache/incubator-pinot/pull/5482#discussion_r437024926 ## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/immutable/ImmutableSegmentImpl.java ## @@ -60,7 +60,11 @@ public Immutab

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5530: Update Pinot quickstart to use sql mode

fx19880617 opened a new pull request #5530: URL: https://github.com/apache/incubator-pinot/pull/5530 ## Description Move Pinot Quickstart to use SQL query mode This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5513: Return Select only Literal Expression at Broker

kishoreg commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437011477 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -435,6 +455,116 @@ static vo

[GitHub] [incubator-pinot] akshayrai opened a new issue #5522: [TE-Admin][UI] Ability to create new applications from admin page

akshayrai opened a new issue #5522: URL: https://github.com/apache/incubator-pinot/issues/5522 Add a button to create a new application. This is mainly helpful when booting ThirdEye for the first time with 0 applications. **Priority:** High **Possible Solution:** Add an entry to “

[GitHub] [incubator-pinot] snleee closed pull request #5319: Add segment merge-rollup task executor

snleee closed pull request #5319: URL: https://github.com/apache/incubator-pinot/pull/5319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] akshayrai opened a new issue #5525: [TE-demo][Backend] Have a default application auto-created in demo mode

akshayrai opened a new issue #5525: URL: https://github.com/apache/incubator-pinot/issues/5525 We should have a default application auto-created in the demo mode. For example, sandbox application. **Priority:** Low **Solution:** Automatically populate “sandbox” entry to the appli

[GitHub] [incubator-pinot] fx19880617 opened a new issue #5516: Move quickstart examples to use SQL Mode

fx19880617 opened a new issue #5516: URL: https://github.com/apache/incubator-pinot/issues/5516 Current Pinot Quickstart is still using PQL mode, we should move to SQL mode. This is an automated message from the Apache Git Se

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5506: Moved StreamPartitionMsgOffset to be an interface

npawar commented on a change in pull request #5506: URL: https://github.com/apache/incubator-pinot/pull/5506#discussion_r437112256 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -515,7 +519

  1   2   >