akshayrai commented on a change in pull request #5515: URL: https://github.com/apache/incubator-pinot/pull/5515#discussion_r436891442
########## File path: thirdeye/thirdeye-frontend/app/utils/yaml-tools.js ########## @@ -11,24 +11,29 @@ dataset: dataset_to_which_this_metric_belongs # Configure multiple rules with "OR" relationship. rules: - detection: - - name: detection_rule_1 - type: ALGORITHM # Configure the detection type here. See doc for more details. - params: # The parameters for this rule. Different rules have different params. - configuration: - bucketPeriod: P1D # Use P1D for daily; PT1H for hourly; PT5M for minutely data. - pValueThreshold: 0.05 # Higher value means more sensitive to small changes. - mlConfig: true # Automatically maintain configuration with the best performance. - filter: # Filter out anomalies detected by rules to reduce noise. - - name: filter_rule_1 - type: PERCENTAGE_CHANGE_FILTER - params: - pattern: UP_OR_DOWN # Other patterns: "UP","DOWN". - threshold: 0.05 # Filter out all changes less than 5% compared to baseline. + - name: detection_rule_1 + type: ALGORITHM # Configure the detection type here. See doc for more details. + params: # The parameters for this rule. Different rules have different params. + configuration: + bucketPeriod: P1D # Use P1D for daily; PT1H for hourly; PT5M for minutely data. + pValueThreshold: 0.05 # Higher value means more sensitive to small changes. + mlConfig: true # Automatically maintain configuration with the best performance. + filter: # Filter out anomalies detected by rules to reduce noise. + - name: filter_rule_1 + type: PERCENTAGE_CHANGE_FILTER + params: + pattern: UP_OR_DOWN # Other patterns: "UP","DOWN". + threshold: 0.05 # Filter out all changes less than 5% compared to baseline. + quality: # Configure the data quality rules + - name: data_sla_rule_1 + type: DATA_SLA # Alert if data is delayed Review comment: updated ########## File path: thirdeye/thirdeye-frontend/app/utils/yaml-tools.js ########## @@ -11,24 +11,29 @@ dataset: dataset_to_which_this_metric_belongs # Configure multiple rules with "OR" relationship. rules: - detection: - - name: detection_rule_1 - type: ALGORITHM # Configure the detection type here. See doc for more details. - params: # The parameters for this rule. Different rules have different params. - configuration: - bucketPeriod: P1D # Use P1D for daily; PT1H for hourly; PT5M for minutely data. - pValueThreshold: 0.05 # Higher value means more sensitive to small changes. - mlConfig: true # Automatically maintain configuration with the best performance. - filter: # Filter out anomalies detected by rules to reduce noise. - - name: filter_rule_1 - type: PERCENTAGE_CHANGE_FILTER - params: - pattern: UP_OR_DOWN # Other patterns: "UP","DOWN". - threshold: 0.05 # Filter out all changes less than 5% compared to baseline. + - name: detection_rule_1 + type: ALGORITHM # Configure the detection type here. See doc for more details. + params: # The parameters for this rule. Different rules have different params. + configuration: + bucketPeriod: P1D # Use P1D for daily; PT1H for hourly; PT5M for minutely data. + pValueThreshold: 0.05 # Higher value means more sensitive to small changes. + mlConfig: true # Automatically maintain configuration with the best performance. + filter: # Filter out anomalies detected by rules to reduce noise. + - name: filter_rule_1 + type: PERCENTAGE_CHANGE_FILTER + params: + pattern: UP_OR_DOWN # Other patterns: "UP","DOWN". + threshold: 0.05 # Filter out all changes less than 5% compared to baseline. + quality: # Configure the data quality rules + - name: data_sla_rule_1 + type: DATA_SLA # Alert if data is delayed + params: + sla: 3_DAYS # Data delayed by 3 days since last availability Review comment: updated ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org