Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
xiaokang merged PR #43065: URL: https://github.com/apache/doris/pull/43065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2456170322 TeamCity be ut coverage result: Function Coverage: 37.80% (9822/25982) Line Coverage: 28.97% (81685/281934) Region Coverage: 28.21% (42096/149241) Branch Coverage: 24.7

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
amorynan commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2456189406 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2456158623 ClickBench: Total hot run time: 32.41 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2456153570 TPC-DS: Total hot run time: 195896 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2456141547 TPC-H: Total hot run time: 41409 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2456090136 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
amorynan commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2456078684 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2455064960 ClickBench: Total hot run time: 32.51 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2455051276 TPC-DS: Total hot run time: 196919 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2455019178 TPC-H: Total hot run time: 41612 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2455002869 TeamCity be ut coverage result: Function Coverage: 37.83% (9826/25977) Line Coverage: 29.00% (81720/281826) Region Coverage: 28.23% (42116/149200) Branch Coverage: 24.8

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
eldenmoon commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1827835358 ## be/src/vec/data_types/serde/data_type_ipv4_serde.cpp: ## @@ -92,6 +92,26 @@ Status DataTypeIPv4SerDe::deserialize_one_cell_from_json(IColumn& column, Slice&

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
eldenmoon commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1827835358 ## be/src/vec/data_types/serde/data_type_ipv4_serde.cpp: ## @@ -92,6 +92,26 @@ Status DataTypeIPv4SerDe::deserialize_one_cell_from_json(IColumn& column, Slice&

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2454868178 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
github-actions[bot] commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1827794036 ## be/test/vec/data_types/serde/data_type_serde_test.cpp: ## @@ -220,4 +220,66 @@ TEST(DataTypeSerDeTest, DataTypeScalaSerDeTest) { serialize_and_deser

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
amorynan commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2454816540 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2454454432 TPC-DS: Total hot run time: 191519 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
yiguolei commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1827584343 ## be/src/vec/data_types/serde/data_type_ipv6_serde.cpp: ## @@ -69,25 +69,17 @@ Status DataTypeIPv6SerDe::write_column_to_mysql(const IColumn& column, } void Data

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
yiguolei commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1827583252 ## be/src/vec/data_types/serde/data_type_ipv6_serde.cpp: ## @@ -69,25 +69,17 @@ Status DataTypeIPv6SerDe::write_column_to_mysql(const IColumn& column, } void Data

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2454465202 ClickBench: Total hot run time: 32.39 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2454447618 TeamCity be ut coverage result: Function Coverage: 37.82% (9824/25975) Line Coverage: 29.00% (81712/281809) Region Coverage: 28.22% (42109/149195) Branch Coverage: 24.8

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2454430510 TPC-H: Total hot run time: 41362 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2454404137 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
github-actions[bot] commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1827543505 ## be/test/vec/data_types/serde/data_type_serde_test.cpp: ## @@ -220,4 +220,36 @@ TEST(DataTypeSerDeTest, DataTypeScalaSerDeTest) { serialize_and_deser

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
amorynan commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2454389062 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2454127401 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2454121850 ClickBench: Total hot run time: 32.76 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2454111334 TPC-DS: Total hot run time: 195600 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2454088524 TPC-H: Total hot run time: 41101 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
amorynan commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2454019736 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
amorynan commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1827289111 ## be/src/vec/data_types/serde/data_type_ipv6_serde.cpp: ## @@ -87,7 +87,10 @@ void DataTypeIPv6SerDe::write_one_cell_to_jsonb(const IColumn& column, result.writ

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
eldenmoon commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1827209915 ## regression-test/suites/datatype_p0/ip/test_ip_basic.groovy: ## @@ -146,4 +146,18 @@ suite("test_ip_basic") { sql "DROP TABLE t0" sql "DROP TABLE t1"

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
eldenmoon commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1827209747 ## regression-test/suites/datatype_p0/ip/test_ip_basic.groovy: ## @@ -146,4 +146,18 @@ suite("test_ip_basic") { sql "DROP TABLE t0" sql "DROP TABLE t1"

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
eldenmoon commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1827200914 ## be/src/vec/data_types/serde/data_type_ipv6_serde.cpp: ## @@ -87,7 +87,10 @@ void DataTypeIPv6SerDe::write_one_cell_to_jsonb(const IColumn& column, result.wri

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2453829164 TeamCity be ut coverage result: Function Coverage: 37.83% (9823/25968) Line Coverage: 28.99% (81633/281570) Region Coverage: 28.27% (42158/149146) Branch Coverage: 24.8

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2453812476 ClickBench: Total hot run time: 32.1 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2453808454 TPC-DS: Total hot run time: 191761 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2453799421 TPC-H: Total hot run time: 41834 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
yiguolei commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1827163287 ## be/src/vec/data_types/serde/data_type_ipv6_serde.cpp: ## @@ -87,7 +87,10 @@ void DataTypeIPv6SerDe::write_one_cell_to_jsonb(const IColumn& column, result.writ

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
github-actions[bot] commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2453778303 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
github-actions[bot] commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2453778270 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
amorynan commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2453776985 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-03 Thread via GitHub
amorynan commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1827160062 ## regression-test/suites/datatype_p0/ip/test_ip_basic.groovy: ## @@ -146,4 +146,18 @@ suite("test_ip_basic") { sql "DROP TABLE t0" sql "DROP TABLE t1"

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-01 Thread via GitHub
eldenmoon commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1825650183 ## regression-test/suites/datatype_p0/ip/test_ip_basic.groovy: ## @@ -146,4 +146,18 @@ suite("test_ip_basic") { sql "DROP TABLE t0" sql "DROP TABLE t1"

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-01 Thread via GitHub
amorynan commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2451496310 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-01 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2451543293 ClickBench: Total hot run time: 32.66 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-01 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2451536018 TPC-DS: Total hot run time: 192044 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-01 Thread via GitHub
github-actions[bot] commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1825558472 ## be/test/vec/data_types/serde/data_type_serde_test.cpp: ## @@ -220,4 +220,33 @@ TEST(DataTypeSerDeTest, DataTypeScalaSerDeTest) { serialize_and_deser

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-01 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2451520274 TPC-H: Total hot run time: 41763 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-01 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2451527748 TeamCity be ut coverage result: Function Coverage: 37.83% (9825/25971) Line Coverage: 28.99% (81618/281543) Region Coverage: 28.28% (42169/149121) Branch Coverage: 24.8

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-01 Thread via GitHub
amorynan commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1825572812 ## be/test/vec/data_types/serde/data_type_serde_test.cpp: ## @@ -220,4 +220,33 @@ TEST(DataTypeSerDeTest, DataTypeScalaSerDeTest) { serialize_and_deserialize_pb_t

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-01 Thread via GitHub
eldenmoon commented on code in PR #43065: URL: https://github.com/apache/doris/pull/43065#discussion_r1825561262 ## be/test/vec/data_types/serde/data_type_serde_test.cpp: ## @@ -220,4 +220,33 @@ TEST(DataTypeSerDeTest, DataTypeScalaSerDeTest) { serialize_and_deserialize_pb_

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-01 Thread via GitHub
amorynan commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2451467217 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](ip) fix datatype serde for ipv6 with rowstore [doris]

2024-11-01 Thread via GitHub
doris-robot commented on PR #43065: URL: https://github.com/apache/doris/pull/43065#issuecomment-2451466653 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y