github-actions[bot] commented on code in PR #43065:
URL: https://github.com/apache/doris/pull/43065#discussion_r1825558472


##########
be/test/vec/data_types/serde/data_type_serde_test.cpp:
##########
@@ -220,4 +220,33 @@ TEST(DataTypeSerDeTest, DataTypeScalaSerDeTest) {
     serialize_and_deserialize_pb_test();
 }
 
+TEST(DataTypeSerDeTest, DataTypeRowStoreSerDeTest) {
+    // ipv6
+    {
+        std::string ip = "5be8:dde9:7f0b:d5a7:bd01:b3be:9c69:573b";
+        auto vec = vectorized::ColumnVector<IPv6>::create();
+        IPv6Value ipv6;
+        EXPECT_TRUE(ipv6.from_string(ip));

Review Comment:
   warning: static member accessed through instance 
[readability-static-accessed-through-instance]
   
   ```suggestion
           EXPECT_TRUE(std::doris::IPv6Value::from_string(ip));
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to