yiguolei commented on code in PR #43065:
URL: https://github.com/apache/doris/pull/43065#discussion_r1827584343
##########
be/src/vec/data_types/serde/data_type_ipv6_serde.cpp:
##########
@@ -69,25 +69,17 @@ Status DataTypeIPv6SerDe::write_column_to_mysql(const
IColumn& column,
}
void DataTypeIPv6SerDe::read_one_cell_from_jsonb(IColumn& column, const
JsonbValue* arg) const {
- IPv6 val = 0;
- const auto* str_value = static_cast<const JsonbStringVal*>(arg);
- ReadBuffer rb(reinterpret_cast<const unsigned char*>(str_value->getBlob()),
- str_value->getBlobLen());
- if (!read_ipv6_text_impl(val, rb)) {
- throw doris::Exception(ErrorCode::INVALID_ARGUMENT, "parse ipv6 fail,
string: '{}'",
- rb.to_string());
- }
- assert_cast<ColumnIPv6&>(column).insert_value(val);
+ const auto ip_value = static_cast<const JsonbInt128Val*>(arg)->val();
Review Comment:
If you changed serialized method, DO it have upgrade and downgrade problem???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
