MaoMiMao closed pull request #427: [Feature] Support-doris-Arrow-flight-read
URL: https://github.com/apache/doris-flink-connector/pull/427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
MaoMiMao commented on PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#issuecomment-2229922378
> @MaoMiMao There is conflicting code, you can merge the latest master
branch, thanks.
I will merge the master branch and resolve the aforementioned issues during
my
JNSimba commented on PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#issuecomment-2229920052
@MaoMiMao There is conflicting code, you can merge the latest master branch,
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message,
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677596920
##
flink-doris-connector/src/main/java/org/apache/doris/flink/table/DorisConfigOptions.java:
##
@@ -307,7 +307,16 @@ public class DorisConfigOptions {
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677586595
##
flink-doris-connector/src/main/java/org/apache/doris/flink/source/reader/DorisSourceSplitReader.java:
##
@@ -69,8 +84,41 @@ private void checkSplitOrSta
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677584078
##
flink-doris-connector/src/main/java/org/apache/doris/flink/rest/SchemaUtils.java:
##
@@ -46,4 +49,25 @@ public static Schema convertToSchema(List
tscan
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677581610
##
flink-doris-connector/src/test/java/org/apache/doris/flink/DorisSinkSQLExample.java:
##
Review Comment:
Should this file be deleted?
--
This is
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677577380
##
flink-doris-connector/src/main/java/org/apache/doris/flink/source/reader/DorisSourceSplitReader.java:
##
@@ -69,8 +84,41 @@ private void checkSplitOrSta
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677578265
##
flink-doris-connector/src/main/java/org/apache/doris/flink/source/reader/DorisSourceSplitReader.java:
##
@@ -69,8 +84,41 @@ private void checkSplitOrSta
MaoMiMao commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677572484
##
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##
@@ -153,6 +163,37 @@ public RowBatch readArrow() {
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677570847
##
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##
@@ -507,14 +570,30 @@ public static String completeMillisecon
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677568640
##
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##
@@ -480,6 +517,14 @@ public boolean doConvert(
@Visibl
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677565591
##
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##
@@ -359,9 +390,12 @@ public boolean doConvert(
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677564856
##
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##
@@ -330,26 +378,9 @@ public boolean doConvert(
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677562284
##
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##
@@ -316,8 +364,8 @@ public boolean doConvert(
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677560344
##
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##
@@ -217,24 +258,27 @@ public boolean doConvert(
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677556767
##
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##
@@ -153,6 +163,37 @@ public RowBatch readArrow() {
}
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677555749
##
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##
@@ -153,6 +163,37 @@ public RowBatch readArrow() {
}
MaoMiMao commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677294985
##
flink-doris-connector/src/main/java/org/apache/doris/flink/flight/DorisFlightSource.java:
##
@@ -0,0 +1,206 @@
+// Licensed to the Apache Software Foun
MaoMiMao commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677294744
##
flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisReadOptions.java:
##
@@ -121,52 +126,20 @@ public void setFilterQuery(String filter
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677285536
##
flink-doris-connector/src/main/java/org/apache/doris/flink/flight/DorisFlightSource.java:
##
@@ -0,0 +1,206 @@
+// Licensed to the Apache Software Found
MaoMiMao commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677285215
##
flink-doris-connector/pom.xml:
##
@@ -379,10 +391,10 @@ under the License.
3.2.4
-
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677284839
##
flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisReadOptions.java:
##
@@ -121,52 +126,20 @@ public void setFilterQuery(String filterQ
JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677283987
##
flink-doris-connector/pom.xml:
##
@@ -379,10 +391,10 @@ under the License.
3.2.4
-
24 matches
Mail list logo
