MaoMiMao commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677294744
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisReadOptions.java:
##########
@@ -121,52 +126,20 @@ public void setFilterQuery(String filterQuery) {
this.filterQuery = filterQuery;
}
- public static Builder builder() {
- return new Builder();
+ public boolean getUseFlightSql() {
+ return useFlightSql;
}
- public static DorisReadOptions defaults() {
- return DorisReadOptions.builder().build();
+ public String getFlightSqlPort() {
+ return flightSqlPort;
}
- @Override
- public boolean equals(Object o) {
- if (this == o) {
- return true;
- }
- if (o == null || getClass() != o.getClass()) {
- return false;
- }
- DorisReadOptions that = (DorisReadOptions) o;
- return useOldApi == that.useOldApi
- && Objects.equals(readFields, that.readFields)
- && Objects.equals(filterQuery, that.filterQuery)
- && Objects.equals(requestTabletSize, that.requestTabletSize)
- && Objects.equals(requestConnectTimeoutMs,
that.requestConnectTimeoutMs)
- && Objects.equals(requestReadTimeoutMs,
that.requestReadTimeoutMs)
- && Objects.equals(requestQueryTimeoutS,
that.requestQueryTimeoutS)
- && Objects.equals(requestRetries, that.requestRetries)
- && Objects.equals(requestBatchSize, that.requestBatchSize)
- && Objects.equals(execMemLimit, that.execMemLimit)
- && Objects.equals(deserializeQueueSize,
that.deserializeQueueSize)
- && Objects.equals(deserializeArrowAsync,
that.deserializeArrowAsync);
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
