JNSimba commented on code in PR #427:
URL:
https://github.com/apache/doris-flink-connector/pull/427#discussion_r1677564856
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##########
@@ -330,26 +378,9 @@ public boolean doConvert(
}
break;
case "DATETIME":
- if (!minorType.equals(Types.MinorType.TIMESTAMPMICRO)
- && !minorType.equals(Types.MinorType.VARCHAR)) {
- return false;
- }
- if (minorType.equals(Types.MinorType.VARCHAR)) {
- VarCharVector varCharVector = (VarCharVector) fieldVector;
- if (varCharVector.isNull(rowIndex)) {
- addValueToRow(rowIndex, null);
- break;
- }
- String stringValue = new
String(varCharVector.get(rowIndex));
- LocalDateTime parse = LocalDateTime.parse(stringValue,
dateTimeFormatter);
- addValueToRow(rowIndex, parse);
- } else {
- LocalDateTime dateTime = getDateTime(rowIndex,
fieldVector);
- addValueToRow(rowIndex, dateTime);
- }
- break;
Review Comment:
Will there be any problem if delete it here？because the formatter of
datetime is different from that of datetimev2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
