dataroaring merged PR #35670:
URL: https://github.com/apache/doris/pull/35670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.
github-actions[bot] commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2159907092
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2159804346
TeamCity be ut coverage result:
Function Coverage: 36.41% (8978/24660)
Line Coverage: 27.95% (73376/262529)
Region Coverage: 27.36% (38027/138998)
Branch Coverage: 23.9
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2159797565
ClickBench: Total hot run time: 31.1 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
C
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2159792721
TPC-DS: Total hot run time: 172608 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2159783160
TPC-H: Total hot run time: 39789 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
ByteYue commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2159711605
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
github-actions[bot] commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2159645692
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2153882313
TeamCity be ut coverage result:
Function Coverage: 36.40% (8976/24659)
Line Coverage: 27.95% (73370/262473)
Region Coverage: 27.36% (38023/138959)
Branch Coverage: 23.9
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2153868870
ClickBench: Total hot run time: 30.03 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2153856533
TPC-DS: Total hot run time: 173118 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2153833476
TPC-H: Total hot run time: 41895 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
ByteYue commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2153746362
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
ByteYue commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2153744907
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2152358471
ClickBench: Total hot run time: 30.53 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2152345958
TeamCity be ut coverage result:
Function Coverage: 36.41% (8973/24644)
Line Coverage: 27.95% (73317/262345)
Region Coverage: 27.36% (38004/138902)
Branch Coverage: 23.9
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2152337660
TPC-DS: Total hot run time: 169368 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2152304810
TPC-H: Total hot run time: 40241 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
ByteYue commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2152117165
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2151877392
TeamCity be ut coverage result:
Function Coverage: 36.34% (8990/24739)
Line Coverage: 27.90% (73460/263259)
Region Coverage: 27.33% (38007/139070)
Branch Coverage: 23.9
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2151861073
ClickBench: Total hot run time: 29.87 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2151848779
TPC-DS: Total hot run time: 169850 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2151827547
TPC-H: Total hot run time: 40079 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
ByteYue commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2151738776
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
ByteYue commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2151655794
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
platoneko commented on code in PR #35670:
URL: https://github.com/apache/doris/pull/35670#discussion_r1628868830
##
be/src/util/s3_util.h:
##
@@ -116,9 +121,9 @@ struct S3ClientConf {
std::string to_string() const {
return fmt::format(
-"(ak={}, t
platoneko commented on code in PR #35670:
URL: https://github.com/apache/doris/pull/35670#discussion_r1628837333
##
gensrc/thrift/AgentService.thrift:
##
@@ -61,6 +61,15 @@ enum TTabletType {
TABLET_TYPE_MEMORY = 1
}
+enum TObjStorageType {
+AWS = 0,
Review Comment:
gavinchou commented on code in PR #35670:
URL: https://github.com/apache/doris/pull/35670#discussion_r1626836505
##
be/src/cloud/cloud_meta_mgr.cpp:
##
@@ -345,6 +346,27 @@ Status retry_rpc(std::string_view op_name, const Request&
req, Response* res,
return Status::RpcErro
github-actions[bot] commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2151258804
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2149893448
ClickBench: Total hot run time: 30.86 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2149870091
TPC-DS: Total hot run time: 170007 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2149827791
TPC-H: Total hot run time: 41700 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2149826092
TeamCity be ut coverage result:
Function Coverage: 36.38% (8987/24704)
Line Coverage: 27.93% (73460/263056)
Region Coverage: 27.35% (38018/138993)
Branch Coverage: 23.9
ByteYue commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2149624194
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2149311316
TeamCity be ut coverage result:
Function Coverage: 36.37% (8985/24704)
Line Coverage: 27.91% (73442/263099)
Region Coverage: 27.35% (38012/139000)
Branch Coverage: 23.9
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2149297030
ClickBench: Total hot run time: 30.75 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2149285513
TPC-DS: Total hot run time: 169339 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2149262261
TPC-H: Total hot run time: 41195 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on code in PR #35670:
URL: https://github.com/apache/doris/pull/35670#discussion_r1627213109
##
be/test/io/fs/azure_test.cpp:
##
@@ -0,0 +1,96 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreemen
ByteYue commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2149144991
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ByteYue commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2149094471
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2149012935
ClickBench: Total hot run time: 29.92 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2149004415
TPC-DS: Total hot run time: 172719 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2148989093
TPC-H: Total hot run time: 40342 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
ByteYue commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2148887592
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
ByteYue commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2148737985
run beut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
ByteYue commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2147310473
run beut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
ByteYue commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2146474097
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
github-actions[bot] commented on code in PR #35670:
URL: https://github.com/apache/doris/pull/35670#discussion_r1623826105
##
be/src/cloud/cloud_meta_mgr.cpp:
##
@@ -813,17 +835,21 @@ Status
CloudMetaMgr::get_storage_vault_info(StorageVaultInfos* vault_infos) {
}
au
ByteYue commented on code in PR #35670:
URL: https://github.com/apache/doris/pull/35670#discussion_r1622712118
##
be/src/util/s3_util.cpp:
##
@@ -156,9 +159,9 @@ S3ClientFactory& S3ClientFactory::instance() {
return ret;
}
-std::shared_ptr S3ClientFactory::create(const S
ByteYue commented on code in PR #35670:
URL: https://github.com/apache/doris/pull/35670#discussion_r1622711376
##
be/src/io/fs/azure_obj_storage_client.cpp:
##
Review Comment:
I'll add enough ut to test them right after i've done all the feature test
like batch delete test
gavinchou commented on code in PR #35670:
URL: https://github.com/apache/doris/pull/35670#discussion_r1622630136
##
be/test/io/fs/azure_test.cpp:
##
@@ -0,0 +1,101 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See
gavinchou commented on code in PR #35670:
URL: https://github.com/apache/doris/pull/35670#discussion_r1622704987
##
be/src/io/fs/azure_obj_storage_client.cpp:
##
Review Comment:
How do we test each function implementation?
##
be/src/util/s3_util.cpp:
##
@
github-actions[bot] commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2139563209
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on code in PR #35670:
URL: https://github.com/apache/doris/pull/35670#discussion_r1620565147
##
be/test/io/fs/azure_test.cpp:
##
@@ -0,0 +1,101 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme
doris-robot commented on PR #35670:
URL: https://github.com/apache/doris/pull/35670#issuecomment-2139381259
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
ByteYue opened a new pull request, #35670:
URL: https://github.com/apache/doris/pull/35670
## Proposed changes
As one subsequent pr of #35307, this pr will link azure into BE, and
implements the corresponding interface of ObjStorageClient for Azure.
--
This is an automated
57 matches
Mail list logo
