gavinchou commented on code in PR #35670:
URL: https://github.com/apache/doris/pull/35670#discussion_r1626836505


##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -345,6 +346,27 @@ Status retry_rpc(std::string_view op_name, const Request& 
req, Response* res,
     return Status::RpcError("failed to {}: rpc timeout, last msg={}", op_name, 
error_msg);
 }
 
+io::ObjStorageType convert_obj_store_type_pb(ObjectStoreInfoPB::Provider 
provider) {
+    switch (provider) {
+    case ObjectStoreInfoPB_Provider_S3:
+        return io::ObjStorageType::AWS;
+    case ObjectStoreInfoPB_Provider_OSS:
+        return io::ObjStorageType::OSS;
+    case ObjectStoreInfoPB_Provider_OBS:
+        return io::ObjStorageType::OBS;
+    case ObjectStoreInfoPB_Provider_BOS:
+        return io::ObjStorageType::BOS;
+    case ObjectStoreInfoPB_Provider_GCP:
+        return io::ObjStorageType::GCP;
+    case ObjectStoreInfoPB_Provider_COS:
+        return io::ObjStorageType::COS;
+    case ObjectStoreInfoPB_Provider_AZURE:
+        return io::ObjStorageType::AZURE;
+    default:
+        return io::ObjStorageType::AWS;

Review Comment:
   This should unknown type?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to