platoneko commented on code in PR #35670:
URL: https://github.com/apache/doris/pull/35670#discussion_r1628868830
##########
be/src/util/s3_util.h:
##########
@@ -116,9 +121,9 @@ struct S3ClientConf {
std::string to_string() const {
return fmt::format(
- "(ak={}, token={}, endpoint={}, region={}, max_connections={},
"
+ "(ak={}, token={}, endpoint={}, region={}, bucket={},
max_connections={}, "
"request_timeout_ms={}, connect_timeout_ms={},
use_virtual_addressing={}",
- ak, token, endpoint, region, max_connections,
request_timeout_ms,
+ ak, token, endpoint, region, bucket, max_connections,
request_timeout_ms,
connect_timeout_ms, use_virtual_addressing);
}
Review Comment:
```c++
static S3Conf get_s3_conf(const ObjectStoreInfoPB&);
static S3Conf get_s3_conf(const TS3StorageParam&);
```
在函数实现里面处理 unknown provider，注意前向兼容
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
