Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-19 Thread via GitHub
BiteThet merged PR #44046: URL: https://github.com/apache/doris/pull/44046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-18 Thread via GitHub
doris-robot commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2484688504 TeamCity be ut coverage result: Function Coverage: 38.02% (9898/26035) Line Coverage: 29.20% (82796/283507) Region Coverage: 28.33% (42512/150048) Branch Coverage: 24.9

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-18 Thread via GitHub
github-actions[bot] commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2484675457 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-18 Thread via GitHub
github-actions[bot] commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2484675490 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-18 Thread via GitHub
github-actions[bot] commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2484596162 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-18 Thread via GitHub
zclllyybb commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2484591685 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-18 Thread via GitHub
github-actions[bot] commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2484576822 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-18 Thread via GitHub
zclllyybb commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2484572255 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-18 Thread via GitHub
github-actions[bot] commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2482299243 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-18 Thread via GitHub
doris-robot commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2482583145 TeamCity be ut coverage result: Function Coverage: 38.02% (9899/26035) Line Coverage: 29.18% (82739/283502) Region Coverage: 28.32% (42499/150048) Branch Coverage: 24.8

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-18 Thread via GitHub
zclllyybb commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2482288187 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-18 Thread via GitHub
github-actions[bot] commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2482239620 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-17 Thread via GitHub
HappenLee commented on code in PR #44046: URL: https://github.com/apache/doris/pull/44046#discussion_r1845813187 ## be/src/vec/columns/column.h: ## @@ -126,16 +126,8 @@ class IColumn : public COW { return nullptr; } -// shrink the end zeros for CHAR type or A

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-17 Thread via GitHub
HappenLee commented on code in PR #44046: URL: https://github.com/apache/doris/pull/44046#discussion_r1845816518 ## be/src/vec/columns/column_object.h: ## @@ -457,9 +457,9 @@ class ColumnObject final : public COWHelper { const uint8_t* __restrict

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-17 Thread via GitHub
github-actions[bot] commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2481792754 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-17 Thread via GitHub
zclllyybb commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2481787969 run buildlall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-17 Thread via GitHub
github-actions[bot] commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2481401378 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-17 Thread via GitHub
doris-robot commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2481449754 TeamCity be ut coverage result: Function Coverage: 37.99% (9902/26068) Line Coverage: 29.19% (82785/283643) Region Coverage: 28.32% (42508/150113) Branch Coverage: 24.8

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-17 Thread via GitHub
zclllyybb commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2481399845 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-15 Thread via GitHub
doris-robot commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2478693304 TeamCity be ut coverage result: Function Coverage: 38.01% (9901/26051) Line Coverage: 29.19% (82750/283470) Region Coverage: 28.32% (42501/150068) Branch Coverage: 24.8

[PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-15 Thread via GitHub
zclllyybb opened a new pull request, #44046: URL: https://github.com/apache/doris/pull/44046 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: dont alloc new mem and re-assign. just shirnk in place. ### Release n

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-15 Thread via GitHub
zclllyybb commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2478516383 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-15 Thread via GitHub
doris-robot commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2478515447 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+proce

Re: [PR] [Refactor](block) Refactor interface of shrink column [doris]

2024-11-15 Thread via GitHub
github-actions[bot] commented on PR #44046: URL: https://github.com/apache/doris/pull/44046#issuecomment-2478524833 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL