HappenLee commented on code in PR #44046: URL: https://github.com/apache/doris/pull/44046#discussion_r1845816518
########## be/src/vec/columns/column_object.h: ########## @@ -457,9 +457,9 @@ class ColumnObject final : public COWHelper<IColumn, ColumnObject> { const uint8_t* __restrict null_data) const override; // Not implemented - MutableColumnPtr get_shrinked_column() override { + void shrink_padding_chars() override { Review Comment: why do not do the work in icolumn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org