HappenLee commented on code in PR #44046:
URL: https://github.com/apache/doris/pull/44046#discussion_r1845813187
##########
be/src/vec/columns/column.h:
##########
@@ -126,16 +126,8 @@ class IColumn : public COW<IColumn> {
return nullptr;
}
- // shrink the end zeros for CHAR type or ARRAY<CHAR> type
- virtual MutablePtr get_shrinked_column() {
- throw doris::Exception(ErrorCode::NOT_IMPLEMENTED_ERROR,
- "Method get_shrinked_column is not supported
for " + get_name());
- return nullptr;
- }
-
- // check the column whether could shrinked
- // now support only in char type, or the nested type in complex type:
array{char}, struct{char}, map{char}
- virtual bool could_shrinked_column() { return false; }
+ // shrink the end zeros for CHAR type(also for who has CHAR nested)
+ virtual void shrink_padding_chars() {}
Review Comment:
why not `throw doris::Exception` here？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
