Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-02-02 Thread via GitHub
dataroaring merged PR #47486: URL: https://github.com/apache/doris/pull/47486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-02-02 Thread via GitHub
github-actions[bot] commented on PR #47486: URL: https://github.com/apache/doris/pull/47486#issuecomment-2629467286 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-02-02 Thread via GitHub
github-actions[bot] commented on PR #47486: URL: https://github.com/apache/doris/pull/47486#issuecomment-2629467271 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-01-31 Thread via GitHub
Yukang-Lian commented on PR #47486: URL: https://github.com/apache/doris/pull/47486#issuecomment-2628748201 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-01-31 Thread via GitHub
Yukang-Lian commented on PR #47486: URL: https://github.com/apache/doris/pull/47486#issuecomment-2627480094 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-01-31 Thread via GitHub
Yukang-Lian commented on PR #47486: URL: https://github.com/apache/doris/pull/47486#issuecomment-2627433256 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-01-30 Thread via GitHub
gavinchou commented on code in PR #47486: URL: https://github.com/apache/doris/pull/47486#discussion_r1935775411 ## cloud/src/recycler/recycler.cpp: ## @@ -1562,7 +1566,8 @@ int InstanceRecycler::delete_rowset_data(const std::vector

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-01-30 Thread via GitHub
gavinchou commented on code in PR #47486: URL: https://github.com/apache/doris/pull/47486#discussion_r1935765022 ## cloud/src/recycler/recycler.cpp: ## @@ -1499,7 +1504,7 @@ int InstanceRecycler::delete_rowset_data(const std::vector> index_ids; // default format as v1.

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-01-30 Thread via GitHub
gavinchou commented on code in PR #47486: URL: https://github.com/apache/doris/pull/47486#discussion_r1935740396 ## cloud/src/recycler/recycler.cpp: ## @@ -1464,18 +1464,23 @@ int InstanceRecycler::delete_rowset_data(const doris::RowsetMetaCloudPB& rs_meta return accessor-

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-01-30 Thread via GitHub
gavinchou commented on code in PR #47486: URL: https://github.com/apache/doris/pull/47486#discussion_r1935652124 ## cloud/src/recycler/recycler.cpp: ## @@ -1464,18 +1464,23 @@ int InstanceRecycler::delete_rowset_data(const doris::RowsetMetaCloudPB& rs_meta return accessor-

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-01-30 Thread via GitHub
gavinchou commented on code in PR #47486: URL: https://github.com/apache/doris/pull/47486#discussion_r1935712512 ## cloud/src/recycler/recycler.h: ## @@ -222,7 +222,8 @@ class InstanceRecycler { const std::string& rowset_id); // return 0 for su

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-01-30 Thread via GitHub
gavinchou commented on code in PR #47486: URL: https://github.com/apache/doris/pull/47486#discussion_r1935710151 ## cloud/src/recycler/recycler.h: ## @@ -222,7 +222,8 @@ class InstanceRecycler { const std::string& rowset_id); // return 0 for su

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-01-30 Thread via GitHub
gavinchou commented on code in PR #47486: URL: https://github.com/apache/doris/pull/47486#discussion_r1935652124 ## cloud/src/recycler/recycler.cpp: ## @@ -1464,18 +1464,23 @@ int InstanceRecycler::delete_rowset_data(const doris::RowsetMetaCloudPB& rs_meta return accessor-

[PR] [Fix](recycler) Further fix for #47475 [doris]

2025-01-29 Thread via GitHub
Yukang-Lian opened a new pull request, #47486: URL: https://github.com/apache/doris/pull/47486 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - T

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-01-29 Thread via GitHub
Yukang-Lian commented on PR #47486: URL: https://github.com/apache/doris/pull/47486#issuecomment-2621999128 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix](recycler) Further fix for #47475 [doris]

2025-01-29 Thread via GitHub
Thearas commented on PR #47486: URL: https://github.com/apache/doris/pull/47486#issuecomment-2621998123 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y