gavinchou commented on code in PR #47486:
URL: https://github.com/apache/doris/pull/47486#discussion_r1935652124
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -1464,18 +1464,23 @@ int InstanceRecycler::delete_rowset_data(const
doris::RowsetMetaCloudPB& rs_meta
return accessor->delete_files(file_paths);
}
-int InstanceRecycler::delete_rowset_data(const
std::vector<doris::RowsetMetaCloudPB>& rowsets) {
+int InstanceRecycler::delete_rowset_data(const
std::vector<doris::RowsetMetaCloudPB>& rowsets,
+ bool is_recycle_tmp_rowset) {
int ret = 0;
// resource_id -> file_paths
std::map<std::string, std::vector<std::string>> resource_file_paths;
// (resource_id, tablet_id, rowset_id)
std::vector<std::tuple<std::string, int64_t, std::string>>
rowsets_delete_by_prefix;
for (const auto& rs : rowsets) {
- {
- std::lock_guard lock(recycled_tablets_mtx_);
- if (recycled_tablets_.count(rs.tablet_id())) {
- continue; // Rowset data has already been deleted
+ // Tmp rowsets may not be recycled in recycle_tablet correctly,
+ // here we can not skip recycling them
+ if (!is_recycle_tmp_rowset) {
+ {
Review Comment:
redundant indention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
