gavinchou commented on code in PR #47486:
URL: https://github.com/apache/doris/pull/47486#discussion_r1935710151
##########
cloud/src/recycler/recycler.h:
##########
@@ -222,7 +222,8 @@ class InstanceRecycler {
const std::string& rowset_id);
// return 0 for success otherwise error
- int delete_rowset_data(const std::vector<doris::RowsetMetaCloudPB>&
rowsets);
+ int delete_rowset_data(const std::vector<doris::RowsetMetaCloudPB>&
rowsets,
+ bool is_recycle_tmp_rowset = false);
Review Comment:
Use enum class
```
enum class RowsetRecyclingState {
FORMAL_ROWSET,
TMP_ROWSET,
};
int delete_rowset_data(const std::vector<doris::RowsetMetaCloudPB>&
rowsets,
RowsetRecyclingState type);
```
##########
cloud/src/recycler/recycler.h:
##########
@@ -222,7 +222,8 @@ class InstanceRecycler {
const std::string& rowset_id);
// return 0 for success otherwise error
- int delete_rowset_data(const std::vector<doris::RowsetMetaCloudPB>&
rowsets);
+ int delete_rowset_data(const std::vector<doris::RowsetMetaCloudPB>&
rowsets,
+ bool is_recycle_tmp_rowset = false);
Review Comment:
Use enum class
```
enum class RowsetRecyclingState {
FORMAL_ROWSET,
TMP_ROWSET,
};
int delete_rowset_data(const std::vector<doris::RowsetMetaCloudPB>&
rowsets,
RowsetRecyclingState type);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
