Re: [PR] [fix](hive)Modify the Hive notification event processing method when using meta cache and add parameters to the Hive catalog. [doris]

2024-08-17 Thread via GitHub
hubgeter commented on PR #39239: URL: https://github.com/apache/doris/pull/39239#issuecomment-2295139975 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [chore](be) improve download logs [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39485: URL: https://github.com/apache/doris/pull/39485#issuecomment-2295137500 TPC-H: Total hot run time: 38235 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [chore](be) improve download logs [doris]

2024-08-17 Thread via GitHub
github-actions[bot] commented on PR #39485: URL: https://github.com/apache/doris/pull/39485#issuecomment-2295124948 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [chore](be) improve download logs [doris]

2024-08-17 Thread via GitHub
github-actions[bot] commented on PR #39485: URL: https://github.com/apache/doris/pull/39485#issuecomment-2295124940 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [opt](log) refine the cloud logger [doris]

2024-08-17 Thread via GitHub
github-actions[bot] commented on PR #39488: URL: https://github.com/apache/doris/pull/39488#issuecomment-2295124772 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [opt](log) refine the cloud logger [doris]

2024-08-17 Thread via GitHub
github-actions[bot] commented on PR #39488: URL: https://github.com/apache/doris/pull/39488#issuecomment-2295124762 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [chore](be) improve download logs [doris]

2024-08-17 Thread via GitHub
dataroaring commented on PR #39485: URL: https://github.com/apache/doris/pull/39485#issuecomment-2295124415 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [enhancement](delete) Add a hint msg for forbidden delete when MV or rollup exists [doris]

2024-08-17 Thread via GitHub
dataroaring merged PR #39505: URL: https://github.com/apache/doris/pull/39505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

(doris) branch master updated (118eb3b48cd -> ff892b3d46a)

2024-08-17 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 118eb3b48cd [bugfix](external)add check of engine and catalog types (#39343) add ff892b3d46a [enhancement](d

(doris) branch branch-2.1 updated: [enhancement](schema-change) Record detailed fail reason for schema change tasks (#39351) (#39501)

2024-08-17 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new c0cbb2362c4 [enhancement](schema-cha

Re: [PR] [enhancement](schema-change) Record detailed fail reason for schema change tasks (#39351) [doris]

2024-08-17 Thread via GitHub
dataroaring merged PR #39501: URL: https://github.com/apache/doris/pull/39501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [fix](hive)Modify the Hive notification event processing method when using meta cache and add parameters to the Hive catalog. [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39239: URL: https://github.com/apache/doris/pull/39239#issuecomment-2295114765 ClickBench: Total hot run time: 31.31 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](hive)Modify the Hive notification event processing method when using meta cache and add parameters to the Hive catalog. [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39239: URL: https://github.com/apache/doris/pull/39239#issuecomment-2295113858 TPC-DS: Total hot run time: 195845 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](hive)Modify the Hive notification event processing method when using meta cache and add parameters to the Hive catalog. [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39239: URL: https://github.com/apache/doris/pull/39239#issuecomment-2295111302 TPC-H: Total hot run time: 38306 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](hive)Modify the Hive notification event processing method when using meta cache and add parameters to the Hive catalog. [doris]

2024-08-17 Thread via GitHub
hubgeter commented on PR #39239: URL: https://github.com/apache/doris/pull/39239#issuecomment-2295101405 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [chore](rowset writer) print rowset rows number when meet too many segments (#39091) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39530: URL: https://github.com/apache/doris/pull/39530#issuecomment-2295098268 TeamCity be ut coverage result: Function Coverage: 37.71% (8103/21488) Line Coverage: 29.35% (66396/226212) Region Coverage: 28.84% (34245/118732) Branch Coverage: 24.7

Re: [PR] Var nested [doris]

2024-08-17 Thread via GitHub
xiaokang commented on code in PR #39022: URL: https://github.com/apache/doris/pull/39022#discussion_r1718142693 ## be/src/olap/rowset/segment_v2/segment.h: ## @@ -162,10 +162,10 @@ class Segment : public std::enable_shared_from_this { // nullptr will returned if storage ty

Re: [PR] [fix](stream load) do not throw exception but skip record when can not find database (#39360) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39531: URL: https://github.com/apache/doris/pull/39531#issuecomment-2295095226 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit b272d95a4f3830baaf923361c1eb3fe2eebe8107 with default session variables Stream

Re: [PR] [fix](stream load) do not throw exception but skip record when can not find database (#39360) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39531: URL: https://github.com/apache/doris/pull/39531#issuecomment-2295094612 ClickBench: Total hot run time: 31.68 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [chore](rowset writer) print rowset rows number when meet too many segments (#39091) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39530: URL: https://github.com/apache/doris/pull/39530#issuecomment-2295094159 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 6124c8b06393e762956bcbb9d5bde32c32a68c49 with default session variables Stream

Re: [PR] [fix](stream load) do not throw exception but skip record when can not find database (#39360) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39531: URL: https://github.com/apache/doris/pull/39531#issuecomment-2295093217 TPC-DS: Total hot run time: 210154 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [chore](rowset writer) print rowset rows number when meet too many segments (#39091) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39530: URL: https://github.com/apache/doris/pull/39530#issuecomment-2295093160 ClickBench: Total hot run time: 31.57 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](routine load) fix show routine load task result incorrect (#38523) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39529: URL: https://github.com/apache/doris/pull/39529#issuecomment-2295092315 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit eca70970d1da4fde1bb4f3df81ad4d4c1633f6e9 with default session variables Stream

Re: [PR] [fix](routine load) fix show routine load task result incorrect (#38523) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39529: URL: https://github.com/apache/doris/pull/39529#issuecomment-2295090991 ClickBench: Total hot run time: 30.96 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [chore](rowset writer) print rowset rows number when meet too many segments (#39091) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39530: URL: https://github.com/apache/doris/pull/39530#issuecomment-2295090861 TPC-DS: Total hot run time: 208986 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](routine load) reset Kafka progress cache when routine load job topic change (#38474) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39528: URL: https://github.com/apache/doris/pull/39528#issuecomment-2295088914 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 5aecd928ded35fd09bb5d0c30b506c8ab5a8e96a with default session variables Stream

Re: [PR] [fix](util) Fix DorisOnce not accurate once when exception happend [doris]

2024-08-17 Thread via GitHub
TangSiyang2001 commented on PR #39470: URL: https://github.com/apache/doris/pull/39470#issuecomment-2295089314 > https://learn.microsoft.com/en-us/cpp/cpp/exceptions-and-stack-unwinding-in-cpp?view=msvc-170 > > Are you sure the lock will be destroyed? Misdirect by a similar cas

Re: [PR] [fix](util) Fix DorisOnce not accurate once when exception happend [doris]

2024-08-17 Thread via GitHub
TangSiyang2001 closed pull request #39470: [fix](util) Fix DorisOnce not accurate once when exception happend URL: https://github.com/apache/doris/pull/39470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [fix](util) Fix DorisOnce not accurate once when exception happend [doris]

2024-08-17 Thread via GitHub
TangSiyang2001 commented on PR #39470: URL: https://github.com/apache/doris/pull/39470#issuecomment-2295088688 The call once `called twice` problem is in the formal version DorisOnce, the current version has no problem, this fix is not in demand, so close this PR. -- This is an automated

Re: [PR] [fix](routine load) fix show routine load task result incorrect (#38523) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39529: URL: https://github.com/apache/doris/pull/39529#issuecomment-2295088382 TPC-DS: Total hot run time: 209060 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](routine load) reset Kafka progress cache when routine load job topic change (#38474) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39528: URL: https://github.com/apache/doris/pull/39528#issuecomment-2295087357 ClickBench: Total hot run time: 31.8 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [fix](stream load) do not throw exception but skip record when can not find database (#39360) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39531: URL: https://github.com/apache/doris/pull/39531#issuecomment-2295087337 TPC-H: Total hot run time: 50295 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](routine load) reset Kafka progress cache when routine load job topic change (#38474) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39528: URL: https://github.com/apache/doris/pull/39528#issuecomment-2295085127 TPC-DS: Total hot run time: 208736 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [chore](rowset writer) print rowset rows number when meet too many segments (#39091) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39530: URL: https://github.com/apache/doris/pull/39530#issuecomment-2295085097 TPC-H: Total hot run time: 50064 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [enhancement](err-msg) Add detailed column and schema info when failed to create a column iterator [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #38689: URL: https://github.com/apache/doris/pull/38689#issuecomment-2295083542 ClickBench: Total hot run time: 32.17 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Bug] test suite test_table_options may cause NPE in FE #39457 [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39509: URL: https://github.com/apache/doris/pull/39509#issuecomment-2295082768 ClickBench: Total hot run time: 30.61 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](routine load) fix show routine load task result incorrect (#38523) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39529: URL: https://github.com/apache/doris/pull/39529#issuecomment-2295082844 TPC-H: Total hot run time: 50107 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [enhancement](err-msg) Add detailed column and schema info when failed to create a column iterator [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #38689: URL: https://github.com/apache/doris/pull/38689#issuecomment-2295079902 TPC-DS: Total hot run time: 196009 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Bug] test suite test_table_options may cause NPE in FE #39457 [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39509: URL: https://github.com/apache/doris/pull/39509#issuecomment-2295077019 TPC-DS: Total hot run time: 196078 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](routine load) reset Kafka progress cache when routine load job topic change (#38474) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39528: URL: https://github.com/apache/doris/pull/39528#issuecomment-2295074660 TPC-H: Total hot run time: 50762 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [enhancement](err-msg) Add detailed column and schema info when failed to create a column iterator [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #38689: URL: https://github.com/apache/doris/pull/38689#issuecomment-2295070297 TPC-H: Total hot run time: 38019 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](routine load) do not cancel job if not found transaction [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39514: URL: https://github.com/apache/doris/pull/39514#issuecomment-2295070291 TPC-H: Total hot run time: 38059 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Bug] test suite test_table_options may cause NPE in FE #39457 [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39509: URL: https://github.com/apache/doris/pull/39509#issuecomment-2295069924 TPC-H: Total hot run time: 37962 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](stream load) do not throw exception but skip record when can not find database (#39360) [doris]

2024-08-17 Thread via GitHub
sollhui commented on PR #39531: URL: https://github.com/apache/doris/pull/39531#issuecomment-2295068677 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](stream load) do not throw exception but skip record when can not find database (#39360) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39531: URL: https://github.com/apache/doris/pull/39531#issuecomment-2295068666 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](stream load) do not throw exception but skip record when can not find database (#39360) [doris]

2024-08-17 Thread via GitHub
sollhui opened a new pull request, #39531: URL: https://github.com/apache/doris/pull/39531 pick (#39360) When fetch stream load record from BE node, if can not find database, StreamLoadRecordMgr will throw exception and the remaining records will not be recorded in memory. For

Re: [PR] [chore](rowset writer) print rowset rows number when meet too many segments (#39091) [doris]

2024-08-17 Thread via GitHub
sollhui commented on PR #39530: URL: https://github.com/apache/doris/pull/39530#issuecomment-2295068123 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [chore](rowset writer) print rowset rows number when meet too many segments (#39091) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39530: URL: https://github.com/apache/doris/pull/39530#issuecomment-2295068109 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [chore](rowset writer) print rowset rows number when meet too many segments (#39091) [doris]

2024-08-17 Thread via GitHub
sollhui opened a new pull request, #39530: URL: https://github.com/apache/doris/pull/39530 pick (#39091) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[PR] [fix](routine load) fix show routine load task result incorrect (#38523) [doris]

2024-08-17 Thread via GitHub
sollhui opened a new pull request, #39529: URL: https://github.com/apache/doris/pull/39529 pick (#38523) Create a job: ``` CREATE ROUTINE LOAD testShow ON test_show_routine_load COLUMNS TERMINATED BY "," PROPERTIES ( "max_batch_interval" = "5", "max_batch_rows" = "

Re: [PR] [Bug](http-api) fix core dump on API check_rpc_channel coz exec_env not init [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39520: URL: https://github.com/apache/doris/pull/39520#issuecomment-2295066858 TPC-H: Total hot run time: 38004 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](routine load) fix show routine load task result incorrect (#38523) [doris]

2024-08-17 Thread via GitHub
sollhui commented on PR #39529: URL: https://github.com/apache/doris/pull/39529#issuecomment-2295066855 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](routine load) fix show routine load task result incorrect (#38523) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39529: URL: https://github.com/apache/doris/pull/39529#issuecomment-2295066851 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](routine load) reset Kafka progress cache when routine load job topic change (#38474) [doris]

2024-08-17 Thread via GitHub
sollhui opened a new pull request, #39528: URL: https://github.com/apache/doris/pull/39528 pick (#38474) When change routine load job topic from test_topic_before to test_topic_after by ``` ALTER ROUTINE LOAD FOR test_topic_change FROM KAFKA("kafka_topic" = "test_topic_after");

Re: [PR] [fix](routine load) reset Kafka progress cache when routine load job topic change (#38474) [doris]

2024-08-17 Thread via GitHub
sollhui commented on PR #39528: URL: https://github.com/apache/doris/pull/39528#issuecomment-2295066515 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](routine load) reset Kafka progress cache when routine load job topic change (#38474) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39528: URL: https://github.com/apache/doris/pull/39528#issuecomment-2295066504 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](stream load) do not throw exception but skip record when can not find database (#39360) [doris]

2024-08-17 Thread via GitHub
sollhui commented on PR #39527: URL: https://github.com/apache/doris/pull/39527#issuecomment-2295065755 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](stream load) do not throw exception but skip record when can not find database (#39360) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39527: URL: https://github.com/apache/doris/pull/39527#issuecomment-2295065750 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](stream load) do not throw exception but skip record when can not find database (#39360) [doris]

2024-08-17 Thread via GitHub
sollhui opened a new pull request, #39527: URL: https://github.com/apache/doris/pull/39527 pick (#39360) When fetch stream load record from BE node, if can not find database, StreamLoadRecordMgr will throw exception and the remaining records will not be recorded in memory. For

Re: [PR] [fix](routine load) should update progress before handle transaction state transform (#39311) [doris]

2024-08-17 Thread via GitHub
sollhui commented on PR #39526: URL: https://github.com/apache/doris/pull/39526#issuecomment-2295065521 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] [fix](routine load) should update progress before handle transaction state transform (#39311) [doris]

2024-08-17 Thread via GitHub
sollhui opened a new pull request, #39526: URL: https://github.com/apache/doris/pull/39526 pick (#39311) Update progress maybe throw exception, causing offset has been persisted on edit log or meta service, but the memory data has not been updated. It will cause repeated consumption.

Re: [PR] [fix](routine load) should update progress before handle transaction state transform (#39311) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39526: URL: https://github.com/apache/doris/pull/39526#issuecomment-2295065514 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](routine load) add read lock to fix some concurrent bugs (#39242) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39525: URL: https://github.com/apache/doris/pull/39525#issuecomment-2295065010 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](routine load) add read lock to fix some concurrent bugs (#39242) [doris]

2024-08-17 Thread via GitHub
sollhui commented on PR #39525: URL: https://github.com/apache/doris/pull/39525#issuecomment-2295065046 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] [fix](routine load) add read lock to fix some concurrent bugs (#39242) [doris]

2024-08-17 Thread via GitHub
sollhui opened a new pull request, #39525: URL: https://github.com/apache/doris/pull/39525 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator and make it exception safe (#38960) [doris]

2024-08-17 Thread via GitHub
sollhui commented on PR #39524: URL: https://github.com/apache/doris/pull/39524#issuecomment-2295064607 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator and make it exception safe (#38960) [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39524: URL: https://github.com/apache/doris/pull/39524#issuecomment-2295064590 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [opt](bytebuffer) allocate ByteBuffer memory by Allocator and make it exception safe (#38960) [doris]

2024-08-17 Thread via GitHub
sollhui opened a new pull request, #39524: URL: https://github.com/apache/doris/pull/39524 pick (#38960) At present, the memory allocation of `ByteBuffer` is done through `new char[capacity_]`. Now, it is uniformly allocated by `Allocator` for the following purposes: 1. Better mem

Re: [PR] [fix](util) Fix DorisOnce not accurate once when exception happend [doris]

2024-08-17 Thread via GitHub
yiguolei commented on code in PR #39470: URL: https://github.com/apache/doris/pull/39470#discussion_r1720872532 ## be/src/util/once.h: ## @@ -42,95 +48,67 @@ namespace doris { // } // // bool is_inited() const { -// return _init_once.has_called() && _init_once.s

Re: [PR] [enhancement](err-msg) Add detailed column and schema info when failed to create a column iterator [doris]

2024-08-17 Thread via GitHub
dataroaring commented on PR #38689: URL: https://github.com/apache/doris/pull/38689#issuecomment-2295058751 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Bug](predicate) fix wrong result of AcceptNullPredicate [doris]

2024-08-17 Thread via GitHub
yiguolei commented on code in PR #39497: URL: https://github.com/apache/doris/pull/39497#discussion_r1720870446 ## be/src/olap/accept_null_predicate.h: ## @@ -158,21 +156,26 @@ class AcceptNullPredicate : public ColumnPredicate { } // create selected_fl

(doris) branch branch-2.0 updated: [enhancement](schema-change) Record detailed fail reason for schema change tasks (#39351) (#39502)

2024-08-17 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.0 by this push: new c71871d582e [enhancement](schema-cha

Re: [PR] [enhancement](schema-change) Record detailed fail reason for schema change tasks (#39351) [doris]

2024-08-17 Thread via GitHub
dataroaring merged PR #39502: URL: https://github.com/apache/doris/pull/39502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [Bug] test suite test_table_options may cause NPE in FE #39457 [doris]

2024-08-17 Thread via GitHub
yiguolei commented on PR #39509: URL: https://github.com/apache/doris/pull/39509#issuecomment-2295056560 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Bug] test suite test_table_options may cause NPE in FE #39457 [doris]

2024-08-17 Thread via GitHub
yiguolei commented on PR #39509: URL: https://github.com/apache/doris/pull/39509#issuecomment-2295056346 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [fix](routine load) do not cancel job if not found transaction [doris]

2024-08-17 Thread via GitHub
github-actions[bot] commented on PR #39514: URL: https://github.com/apache/doris/pull/39514#issuecomment-2295056045 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](routine load) do not cancel job if not found transaction [doris]

2024-08-17 Thread via GitHub
github-actions[bot] commented on PR #39514: URL: https://github.com/apache/doris/pull/39514#issuecomment-2295056053 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Bug](http-api) fix core dump on API check_rpc_channel coz exec_env not init [doris]

2024-08-17 Thread via GitHub
yiguolei commented on PR #39520: URL: https://github.com/apache/doris/pull/39520#issuecomment-2295056021 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] [Bug] Inconsistent query results about dulplicate key model [doris]

2024-08-17 Thread via GitHub
huukhuongnguyen commented on issue #35148: URL: https://github.com/apache/doris/issues/35148#issuecomment-2294934910 I also encountered a similar issue, have you found a solution yet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [Fix](parquet-reader) Fix definition level rle decode dead loop in parquet-reader. [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39523: URL: https://github.com/apache/doris/pull/39523#issuecomment-2294932724 TPC-H: Total hot run time: 38131 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Fix](parquet-reader) Fix definition level rle decode dead loop in parquet-reader. [doris]

2024-08-17 Thread via GitHub
kaka11chen commented on PR #39523: URL: https://github.com/apache/doris/pull/39523#issuecomment-2294918862 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [fix](hive)Modify the Hive notification event processing method when using meta cache and add parameters to the Hive catalog. [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39239: URL: https://github.com/apache/doris/pull/39239#issuecomment-2294912108 ClickBench: Total hot run time: 31.87 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](hive)Modify the Hive notification event processing method when using meta cache and add parameters to the Hive catalog. [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39239: URL: https://github.com/apache/doris/pull/39239#issuecomment-2294910827 TPC-DS: Total hot run time: 195658 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](hive)Modify the Hive notification event processing method when using meta cache and add parameters to the Hive catalog. [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39239: URL: https://github.com/apache/doris/pull/39239#issuecomment-2294907727 TPC-H: Total hot run time: 39318 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](hive)Modify the Hive notification event processing method when using meta cache and add parameters to the Hive catalog. [doris]

2024-08-17 Thread via GitHub
hubgeter commented on PR #39239: URL: https://github.com/apache/doris/pull/39239#issuecomment-2294898563 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

(doris) branch branch-3.0 updated: [feature](restore) Support clean_tables/clean_partitions properties for restore job (#39028)

2024-08-17 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 448908336fb [feature](restore) Suppo

Re: [PR] [fix](hive)Modify the Hive notification event processing method when using meta cache and add parameters to the Hive catalog. [doris]

2024-08-17 Thread via GitHub
hubgeter commented on code in PR #39239: URL: https://github.com/apache/doris/pull/39239#discussion_r1720791038 ## fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalCatalog.java: ## @@ -101,6 +106,12 @@ public void checkProperties() throws DdlException {

Re: [PR] [fix](hive)Modify the Hive notification event processing method when using meta cache and add parameters to the Hive catalog. [doris]

2024-08-17 Thread via GitHub
hubgeter commented on code in PR #39239: URL: https://github.com/apache/doris/pull/39239#discussion_r1720790772 ## fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalCatalog.java: ## @@ -101,6 +106,12 @@ public void checkProperties() throws DdlException {

Re: [PR] [fix](hive)Modify the Hive notification event processing method when using meta cache and add parameters to the Hive catalog. [doris]

2024-08-17 Thread via GitHub
hubgeter commented on code in PR #39239: URL: https://github.com/apache/doris/pull/39239#discussion_r1720790740 ## fe/fe-core/src/main/java/org/apache/doris/datasource/hive/event/MetastoreEventsProcessor.java: ## @@ -125,6 +128,8 @@ private void realRun() { } ca

Re: [PR] [fix](hive)Modify the Hive notification event processing method when using meta cache and add parameters to the Hive catalog. [doris]

2024-08-17 Thread via GitHub
hubgeter commented on code in PR #39239: URL: https://github.com/apache/doris/pull/39239#discussion_r1720790583 ## fe/fe-core/src/main/java/org/apache/doris/datasource/hive/event/AlterPartitionEvent.java: ## @@ -145,9 +145,7 @@ protected boolean canBeBatched(MetastoreEvent that)

Re: [PR] [refactor](util) Use std::once_flag and std::call_once to refactror DorisOnce [doris]

2024-08-17 Thread via GitHub
TangSiyang2001 commented on PR #39470: URL: https://github.com/apache/doris/pull/39470#issuecomment-2294883490 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [refactor](util) Use std::once_flag and std::call_once to refactror DorisOnce [doris]

2024-08-17 Thread via GitHub
TangSiyang2001 commented on PR #39470: URL: https://github.com/apache/doris/pull/39470#issuecomment-2294883447 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

(doris) branch branch-3.0 updated (7259dd0ee5d -> c37a1d7cd3a)

2024-08-17 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git from 7259dd0ee5d [fix](nereids) fix partitionTopN choosing under multi winexprs (#39233) new 21c946f61f9 [imp

Re: [PR] [Bug] test suite test_table_options may cause NPE in FE #39457 [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39509: URL: https://github.com/apache/doris/pull/39509#issuecomment-2294878605 ClickBench: Total hot run time: 32.09 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Bug] test suite test_table_options may cause NPE in FE #39457 [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39509: URL: https://github.com/apache/doris/pull/39509#issuecomment-2294876885 TPC-DS: Total hot run time: 196935 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Bug] test suite test_table_options may cause NPE in FE #39457 [doris]

2024-08-17 Thread via GitHub
doris-robot commented on PR #39509: URL: https://github.com/apache/doris/pull/39509#issuecomment-2294873617 TPC-H: Total hot run time: 37808 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

(doris) branch master updated: [bugfix](external)add check of engine and catalog types (#39343)

2024-08-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 118eb3b48cd [bugfix](external)add check of en

Re: [PR] [bugfix](external)add check of engine and catalog types [doris]

2024-08-17 Thread via GitHub
morningman merged PR #39343: URL: https://github.com/apache/doris/pull/39343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

Re: [PR] [Fix](parquet-reader) Fix definition level rle decode dead loop in parquet-reader. [doris]

2024-08-17 Thread via GitHub
kaka11chen commented on PR #39523: URL: https://github.com/apache/doris/pull/39523#issuecomment-2294870478 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Fix](parquet-reader) Fix definition level rle decode dead loop in parquet-reader. [doris]

2024-08-17 Thread via GitHub
github-actions[bot] commented on PR #39523: URL: https://github.com/apache/doris/pull/39523#issuecomment-2294870297 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

  1   2   >