This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new c71871d582e [enhancement](schema-change) Record detailed fail reason
for schema change tasks (#39351) (#39502)
c71871d582e is described below
commit c71871d582ef5751a84d605d9d6305f32fd19d4b
Author: Siyang Tang <82279870+tangsiyang2...@users.noreply.github.com>
AuthorDate: Sun Aug 18 09:42:29 2024 +0800
[enhancement](schema-change) Record detailed fail reason for schema change
tasks (#39351) (#39502)
## Proposed changes
Expose the error msg from BE as the real fail reason recorded for schema
change tasks. To avoid too much memory usage, we just pick one among all
to record.
---
.../src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
b/fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
index ced291fe0a3..9b7c127676e 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
@@ -522,7 +522,7 @@ public class SchemaChangeJobV2 extends AlterJobV2 {
if (task.getFailedTimes() > 0) {
task.setFinished(true);
AgentTaskQueue.removeTask(task.getBackendId(),
TTaskType.ALTER, task.getSignature());
- LOG.warn("schema change task failed: " +
task.getErrorMsg());
+ LOG.warn("schema change task failed: {}",
task.getErrorMsg());
List<Long> failedBackends =
failedTabletBackends.get(task.getTabletId());
if (failedBackends == null) {
failedBackends = Lists.newArrayList();
@@ -533,8 +533,8 @@ public class SchemaChangeJobV2 extends AlterJobV2 {
.getReplicaAllocation(task.getPartitionId()).getTotalReplicaNum();
int failedTaskCount = failedBackends.size();
if (expectSucceedTaskNum - failedTaskCount <
expectSucceedTaskNum / 2 + 1) {
- throw new AlterCancelException("schema change tasks
failed on same tablet reach threshold "
- + failedTaskCount);
+ throw new AlterCancelException(
+ String.format("schema change tasks failed,
error reason: %s", task.getErrorMsg()));
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
