yiguolei commented on code in PR #39497:
URL: https://github.com/apache/doris/pull/39497#discussion_r1720870446
##########
be/src/olap/accept_null_predicate.h:
##########
@@ -158,21 +156,26 @@ class AcceptNullPredicate : public ColumnPredicate {
}
// create selected_flags
uint16_t max_idx = sel[size - 1];
+ std::vector<uint16_t> old_sel(size);
+ memcpy(old_sel.data(), sel, sizeof(uint16_t) * size);
const auto& nullable_col = assert_cast<const
vectorized::ColumnNullable&>(column);
// call nested predicate evaluate
uint16_t new_size =
_nested->evaluate(nullable_col.get_nested_column(), sel, size);
// process NULL values
if (new_size < size) {
- std::vector<uint8_t> selected(max_idx + 1);
- memcpy(selected.data(),
nullable_col.get_null_map_data().data(),
- (max_idx + 1) * sizeof(bool));
+ std::vector<uint8_t> selected(max_idx + 1, 0);
+ const auto* nullmap = nullable_col.get_null_map_data().data();
// add rows selected by _nested->evaluate
for (uint16_t i = 0; i < new_size; ++i) {
uint16_t row_idx = sel[i];
selected[row_idx] = true;
}
+ for (uint16_t i = 0; i < size; ++i) {
Review Comment:
add comment here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
