Re: [PR] [fix](nereids) Use correct PREAGGREGATION in agg(filter(scan)) [doris]

2024-04-10 Thread via GitHub
liutang123 commented on code in PR #33454: URL: https://github.com/apache/doris/pull/33454#discussion_r1560516907 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/mv/SelectMaterializedIndexWithAggregate.java: ## @@ -745,22 +748,22 @@ public PreAggStatus visit(E

Re: [PR] [refactor](Nereids): compute unique and uniform property respectively [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #32908: URL: https://github.com/apache/doris/pull/32908#issuecomment-2049039895 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [refactor](Nereids): compute unique and uniform property respectively [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #32908: URL: https://github.com/apache/doris/pull/32908#issuecomment-2049039859 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feature](Cloud) Add S3 storage vault implementation [doris]

2024-04-10 Thread via GitHub
ByteYue commented on PR #33377: URL: https://github.com/apache/doris/pull/33377#issuecomment-2049039117 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](catalog) fix resource is not reopen when rename catalog [doris]

2024-04-10 Thread via GitHub
zy-kkk commented on PR #33518: URL: https://github.com/apache/doris/pull/33518#issuecomment-2049036405 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

(doris-website) branch revert-538-0410_policy_doc created (now 928bc4e16c06)

2024-04-10 Thread luzhijing
This is an automated email from the ASF dual-hosted git repository. luzhijing pushed a change to branch revert-538-0410_policy_doc in repository https://gitbox.apache.org/repos/asf/doris-website.git at 928bc4e16c06 Revert "Add workload schedule policy document (#538)" This branch includes

(doris-website) 01/01: Revert "Add workload schedule policy document (#538)"

2024-04-10 Thread luzhijing
This is an automated email from the ASF dual-hosted git repository. luzhijing pushed a commit to branch revert-538-0410_policy_doc in repository https://gitbox.apache.org/repos/asf/doris-website.git commit 928bc4e16c069ca512ee492a5056faa571e7314f Author: Luzhijing <82810928+luzhij...@users.norepl

(doris) branch master updated (b214962dbf8 -> f56ce5a83ab)

2024-04-10 Thread gabriellee
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from b214962dbf8 [fix](merge-cloud) disable ssl in meta check (#33516) add f56ce5a83ab [refactor](pipelineX) Reduce

Re: [PR] [refactor](pipelineX) Reduce prepare overhead [doris]

2024-04-10 Thread via GitHub
Gabriel39 merged PR #33421: URL: https://github.com/apache/doris/pull/33421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Improment](executor)Add workload group id in workload policy's property [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #33483: URL: https://github.com/apache/doris/pull/33483#issuecomment-2049021941 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Fix](inverted index) fix fast execute problem when need read data opt enabled [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #33526: URL: https://github.com/apache/doris/pull/33526#issuecomment-2049023037 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [opt](scan) read scan ranges in the order of partitions [doris]

2024-04-10 Thread via GitHub
AshinGau commented on PR #33515: URL: https://github.com/apache/doris/pull/33515#issuecomment-2049020294 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [refactor](pipelineX) Reduce prepare overhead [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #33421: URL: https://github.com/apache/doris/pull/33421#issuecomment-2049018556 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [refactor](pipelineX) Reduce prepare overhead [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #33421: URL: https://github.com/apache/doris/pull/33421#issuecomment-2049018521 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] [fix](catalog) Remove unexpected cleanup when reading jdbc data [doris]

2024-04-10 Thread via GitHub
zy-kkk opened a new pull request, #33529: URL: https://github.com/apache/doris/pull/33529 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d

Re: [PR] [fix](nereids) Use correct PREAGGREGATION in agg(filter(scan)) [doris]

2024-04-10 Thread via GitHub
BiteThet commented on code in PR #33454: URL: https://github.com/apache/doris/pull/33454#discussion_r1560498437 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/mv/SelectMaterializedIndexWithAggregate.java: ## @@ -745,22 +748,22 @@ public PreAggStatus visit

Re: [PR] [fix](catalog) Remove unexpected cleanup when reading jdbc data [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33529: URL: https://github.com/apache/doris/pull/33529#issuecomment-2049015471 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](catalog) Remove unexpected cleanup when reading jdbc data [doris]

2024-04-10 Thread via GitHub
zy-kkk commented on PR #33529: URL: https://github.com/apache/doris/pull/33529#issuecomment-2049015507 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Branch 2.1 rev [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #32985: Branch 2.1 rev URL: https://github.com/apache/doris/pull/32985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

Re: [PR] [only test] [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #33199: [only test] URL: https://github.com/apache/doris/pull/33199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

Re: [PR] [fix](compaction test) show single replica compaction status and fix test [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #33076: URL: https://github.com/apache/doris/pull/33076#issuecomment-2049010262 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #32770: [only test] " [featrue](expr) support common subexpression elimination" URL: https://github.com/apache/doris/pull/32770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [only test] [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #32761: [only test] URL: https://github.com/apache/doris/pull/32761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

Re: [PR] [fix](nereids) Use correct PREAGGREGATION in agg(filter(scan)) [doris]

2024-04-10 Thread via GitHub
BiteThet commented on code in PR #33454: URL: https://github.com/apache/doris/pull/33454#discussion_r1560494718 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/mv/SelectMaterializedIndexWithAggregate.java: ## @@ -829,15 +832,16 @@ public PreAggStatus visit

Re: [PR] [fix](index change) disable light index change for cloud mode [doris]

2024-04-10 Thread via GitHub
xiaokang commented on PR #33387: URL: https://github.com/apache/doris/pull/33387#issuecomment-2049009755 > Please resolve the comment @platoneko done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [fix](compaction test) show single replica compaction status and fix test [doris]

2024-04-10 Thread via GitHub
zzzxl1993 commented on code in PR #33076: URL: https://github.com/apache/doris/pull/33076#discussion_r1560494190 ## be/src/olap/single_replica_compaction.h: ## @@ -40,11 +39,7 @@ class SingleReplicaCompaction final : public CompactionMixin { protected: Status pick_rowsets

Re: [PR] [fix](pipeline) fix check failed in StatefulOperator [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #32733: [fix](pipeline) fix check failed in StatefulOperator URL: https://github.com/apache/doris/pull/32733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #32727: [only test] " [featrue](expr) support common subexpression elimination" URL: https://github.com/apache/doris/pull/32727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [only test] "[refactor](nereids)unify outputTupleDesc and projection " [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #32249: [only test] "[refactor](nereids)unify outputTupleDesc and projection " URL: https://github.com/apache/doris/pull/32249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [only test] [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #32988: [only test] URL: https://github.com/apache/doris/pull/32988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

Re: [PR] [only test] [refactor](nereids)unify outputTupleDesc and projection be part [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #32456: [only test] [refactor](nereids)unify outputTupleDesc and projection be part URL: https://github.com/apache/doris/pull/32456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [only test]Cant cancel test [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #32586: [only test]Cant cancel test URL: https://github.com/apache/doris/pull/32586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] only test [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #32055: only test URL: https://github.com/apache/doris/pull/32055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

Re: [PR] [refactor](nereids)unify outputTupleDesc and projection [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #32128: [refactor](nereids)unify outputTupleDesc and projection URL: https://github.com/apache/doris/pull/32128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [refine](pipelineX) runtime state owner by the Task, not by the FragmentContext. [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #31651: [refine](pipelineX) runtime state owner by the Task, not by the FragmentContext. URL: https://github.com/apache/doris/pull/31651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [only test] may be we do not need tuple is null in nereids [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #32318: [only test] may be we do not need tuple is null in nereids URL: https://github.com/apache/doris/pull/32318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] [only test] [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #31641: [only test] URL: https://github.com/apache/doris/pull/31641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

Re: [PR] [fix](timeout) query timeout was not correctly set [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #33046: [fix](timeout) query timeout was not correctly set URL: https://github.com/apache/doris/pull/33046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [feature](pipelineX) add mem control in local exchange sink [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #31840: [feature](pipelineX) add mem control in local exchange sink URL: https://github.com/apache/doris/pull/31840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [only test] [doris]

2024-04-10 Thread via GitHub
Mryange closed pull request #30257: [only test] URL: https://github.com/apache/doris/pull/30257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

Re: [PR] [feature](Cloud) Add S3 storage vault implementation [doris]

2024-04-10 Thread via GitHub
platoneko commented on code in PR #33377: URL: https://github.com/apache/doris/pull/33377#discussion_r1560380387 ## cloud/src/meta-service/meta_service_resource.cpp: ## @@ -404,6 +404,82 @@ static int add_hdfs_storage_vault(InstanceInfoPB& instance, Transaction* txn, retur

Re: [PR] [fix](Nereids): remove distribute node of shape in regression test [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #33463: URL: https://github.com/apache/doris/pull/33463#issuecomment-2049006253 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](Nereids): remove distribute node of shape in regression test [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #33463: URL: https://github.com/apache/doris/pull/33463#issuecomment-2049006279 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](routine-load) fix get Kafka offset timeout may too long [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33502: URL: https://github.com/apache/doris/pull/33502#issuecomment-2049004603 TeamCity be ut coverage result: Function Coverage: 35.60% (8904/25011) Line Coverage: 27.31% (73092/267631) Region Coverage: 26.44% (37797/142950) Branch Coverage: 23.2

Re: [PR] [PipelineX](improvement) Prepare tasks in parallel [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on code in PR #32789: URL: https://github.com/apache/doris/pull/32789#discussion_r1560485756 ## be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp: ## @@ -164,7 +166,8 @@ void PipelineXFragmentContext::cancel(const PPlanFragmentCancelReason

Re: [PR] [Fix](nereids) fix qualifier problem that affects delete stmt in another catalog [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33528: URL: https://github.com/apache/doris/pull/33528#issuecomment-2048992368 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [Fix](nereids) fix qualifier problem that affects delete stmt in another catalog [doris]

2024-04-10 Thread via GitHub
feiniaofeiafei opened a new pull request, #33528: URL: https://github.com/apache/doris/pull/33528 cherry-pick #32853 to branch 2.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [PipelineX](improvement) Prepare tasks in parallel [doris]

2024-04-10 Thread via GitHub
Gabriel39 commented on PR #32789: URL: https://github.com/apache/doris/pull/32789#issuecomment-2048991928 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](routine-load) fix get Kafka offset timeout may too long [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #33502: URL: https://github.com/apache/doris/pull/33502#issuecomment-2048981597 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](routine-load) fix get Kafka offset timeout may too long [doris]

2024-04-10 Thread via GitHub
HHoflittlefish777 commented on PR #33502: URL: https://github.com/apache/doris/pull/33502#issuecomment-2048976716 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [fix](nereids) Use correct PREAGGREGATION in agg(filter(scan)) [doris]

2024-04-10 Thread via GitHub
liutang123 commented on PR #33454: URL: https://github.com/apache/doris/pull/33454#issuecomment-2048968058 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Feature](Variant) support aggregation model for Variant type [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33493: URL: https://github.com/apache/doris/pull/33493#issuecomment-2048967095 TeamCity be ut coverage result: Function Coverage: 35.59% (8904/25019) Line Coverage: 27.30% (73105/267741) Region Coverage: 26.44% (37809/142994) Branch Coverage: 23.2

Re: [PR] [refine](pipelineX) refine code in agg node [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33491: URL: https://github.com/apache/doris/pull/33491#issuecomment-2048949788 TeamCity be ut coverage result: Function Coverage: 35.64% (8904/24985) Line Coverage: 27.41% (73100/266686) Region Coverage: 26.51% (37800/142584) Branch Coverage: 23.2

Re: [PR] [refactor](pipelineX) Reduce prepare overhead [doris]

2024-04-10 Thread via GitHub
Gabriel39 commented on PR #33421: URL: https://github.com/apache/doris/pull/33421#issuecomment-2048949618 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

(doris) branch branch-2.1 updated (55d969fc4c0 -> af953020889)

2024-04-10 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git omit 55d969fc4c0 fix compile omit e1e05d89b93 [branch-2.1](memory) Fix rowid storage reader memory tracker (#3352

(doris) 03/04: [branch-2.1](memory) Fix rowid storage reader memory tracker (#33521)

2024-04-10 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git commit 69fc8cf06d2ec16cb43ba297156ea058a6bd0ba3 Author: Xinyi Zou AuthorDate: Thu Apr 11 11:22:39 2024 +0800 [branch-

(doris) 02/04: [Bug](runtime-filter) try to fix heap use after free on runtime filter send filter size (#33465) (#33522)

2024-04-10 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git commit 5688c2836415bf8f6f25b6a9a6029b965c17d0b7 Author: Pxl AuthorDate: Thu Apr 11 11:22:10 2024 +0800 [Bug](runtime-

(doris) 04/04: fix compile

2024-04-10 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git commit af953020889f834c45d8a6034d97156716f07797 Author: yiguolei AuthorDate: Thu Apr 11 12:08:26 2024 +0800 fix compi

(doris) 01/04: [fix](cases) Add check status timeout for backup/restore cases (#32975)

2024-04-10 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git commit 9a3b19d21ee48583d03fb233a1403bf9b6bafd0f Author: walter AuthorDate: Tue Apr 9 23:25:20 2024 +0800 [fix](cases)

Re: [PR] [fix](index change) disable light index change for cloud mode [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33387: URL: https://github.com/apache/doris/pull/33387#issuecomment-2048932309 TeamCity be ut coverage result: Function Coverage: 35.60% (8904/25011) Line Coverage: 27.32% (73104/267631) Region Coverage: 26.45% (37812/142959) Branch Coverage: 23.2

Re: [PR] [refine](pipelineX) refine code in agg node [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on code in PR #33491: URL: https://github.com/apache/doris/pull/33491#discussion_r1560436890 ## be/src/pipeline/exec/aggregation_sink_operator.h: ## @@ -138,6 +123,12 @@ class AggSinkLocalState : public PipelineXSinkLocalState { vectorized::Ar

Re: [PR] [Fix](inverted index) fix fast execute problem when need read data opt enabled [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33526: URL: https://github.com/apache/doris/pull/33526#issuecomment-2048929259 TeamCity be ut coverage result: Function Coverage: 35.60% (8903/25011) Line Coverage: 27.32% (73102/267621) Region Coverage: 26.44% (37801/142950) Branch Coverage: 23.2

Re: [PR] [Feature](Variant) support aggregation model for Variant type [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33493: URL: https://github.com/apache/doris/pull/33493#issuecomment-2048928082 TeamCity be ut coverage result: Function Coverage: 35.59% (8904/25019) Line Coverage: 27.30% (73106/267753) Region Coverage: 26.44% (37802/142999) Branch Coverage: 23.2

Re: [PR] [Feature](Variant) support aggregation model for Variant type [doris]

2024-04-10 Thread via GitHub
eldenmoon commented on PR #33493: URL: https://github.com/apache/doris/pull/33493#issuecomment-2048927973 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [refine](pipelineX) refine code in agg node [doris]

2024-04-10 Thread via GitHub
Mryange commented on PR #33491: URL: https://github.com/apache/doris/pull/33491#issuecomment-2048925221 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](nereids)ExtractAndNormalizeWindowExpression should only normalize alias in output [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33527: URL: https://github.com/apache/doris/pull/33527#issuecomment-2048912437 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](nereids)ExtractAndNormalizeWindowExpression should only normalize alias in output [doris]

2024-04-10 Thread via GitHub
starocean999 opened a new pull request, #33527: URL: https://github.com/apache/doris/pull/33527 … ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apach

Re: [PR] [fix](nereids)ExtractAndNormalizeWindowExpression should only normalize alias in output [doris]

2024-04-10 Thread via GitHub
starocean999 commented on PR #33527: URL: https://github.com/apache/doris/pull/33527#issuecomment-2048912479 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](index change) disable light index change for cloud mode [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #33387: URL: https://github.com/apache/doris/pull/33387#issuecomment-2048911938 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improvement](spill) fuzzy spill and improve config [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on code in PR #33291: URL: https://github.com/apache/doris/pull/33291#discussion_r1560424242 ## be/src/runtime/fragment_mgr.cpp: ## @@ -823,8 +837,23 @@ std::string FragmentMgr::dump_pipeline_tasks(int64_t duration) { Status FragmentMgr::exec_pl

Re: [PR] [fix](index change) disable light index change for cloud mode [doris]

2024-04-10 Thread via GitHub
xiaokang commented on PR #33387: URL: https://github.com/apache/doris/pull/33387#issuecomment-2048909669 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [improvement](spill) fuzzy spill and improve config [doris]

2024-04-10 Thread via GitHub
jacktengg commented on PR #33291: URL: https://github.com/apache/doris/pull/33291#issuecomment-2048907571 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Fix](compaction) Fix single compaction to get all local versions [doris]

2024-04-10 Thread via GitHub
xiaokang commented on code in PR #33480: URL: https://github.com/apache/doris/pull/33480#discussion_r1560421164 ## be/src/olap/tablet.cpp: ## @@ -1641,10 +1641,11 @@ void Tablet::execute_single_replica_compaction(SingleReplicaCompaction& compacti std::vector Tablet::get_all_ve

Re: [PR] [Fix](inverted index) fix fast execute problem when need read data opt enabled [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #33526: URL: https://github.com/apache/doris/pull/33526#issuecomment-2048905190 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [enhancement](memory) Allocator support address sanitizers [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #33396: URL: https://github.com/apache/doris/pull/33396#issuecomment-2048902292 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](compaction)Fix single compaction to get all local versions [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33524: URL: https://github.com/apache/doris/pull/33524#issuecomment-2048902087 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit b9535aa51e2d4893dd82e3f32cfbb5f7163dce80 with default session variables Stream

Re: [PR] [Fix](inverted index) fix fast execute problem when need read data opt enabled [doris]

2024-04-10 Thread via GitHub
airborne12 commented on PR #33526: URL: https://github.com/apache/doris/pull/33526#issuecomment-2048901681 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Fix](inverted index) fix fast execute problem when need read data opt enabled [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33526: URL: https://github.com/apache/doris/pull/33526#issuecomment-2048901614 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [Fix](inverted index) fix fast execute problem when need read data opt enabled [doris]

2024-04-10 Thread via GitHub
airborne12 opened a new pull request, #33526: URL: https://github.com/apache/doris/pull/33526 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mail

Re: [PR] [Feature](Variant) support aggregation model for Variant type [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on code in PR #33493: URL: https://github.com/apache/doris/pull/33493#discussion_r1560416827 ## be/src/olap/tablet_schema.h: ## @@ -426,6 +429,22 @@ class TabletSchema { return str; } +string dump_full_schema() const { Review Co

Re: [PR] [fix](compaction)Fix single compaction to get all local versions [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33524: URL: https://github.com/apache/doris/pull/33524#issuecomment-2048900075 ClickBench: Total hot run time: 32.6 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [enhancement](memory) Allocator support address sanitizers [doris]

2024-04-10 Thread via GitHub
xinyiZzz commented on PR #33396: URL: https://github.com/apache/doris/pull/33396#issuecomment-2048898689 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](compaction)Fix single compaction to get all local versions [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33524: URL: https://github.com/apache/doris/pull/33524#issuecomment-2048896465 TPC-DS: Total hot run time: 201741 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

(doris) branch branch-2.1 updated: fix compile

2024-04-10 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new 55d969fc4c0 fix compile 55d969fc4c0 is

Re: [PR] [Feature](Variant) support aggregation model for Variant type [doris]

2024-04-10 Thread via GitHub
eldenmoon commented on code in PR #33493: URL: https://github.com/apache/doris/pull/33493#discussion_r1560407874 ## be/src/vec/columns/column_array.cpp: ## @@ -412,6 +412,24 @@ void ColumnArray::insert(const Field& x) { } } +void ColumnArray::replace(const Field& f, size

Re: [PR] [Feature](Variant) support aggregation model for Variant type [doris]

2024-04-10 Thread via GitHub
eldenmoon commented on PR #33493: URL: https://github.com/apache/doris/pull/33493#issuecomment-2048891348 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](routine-load) fix get Kafka offset timeout may too long [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33502: URL: https://github.com/apache/doris/pull/33502#issuecomment-204638 TeamCity be ut coverage result: Function Coverage: 35.60% (8904/25011) Line Coverage: 27.31% (73088/267631) Region Coverage: 26.44% (37793/142950) Branch Coverage: 23.2

Re: [PR] [Feature](Variant) support aggregation model for Variant type [doris]

2024-04-10 Thread via GitHub
eldenmoon commented on code in PR #33493: URL: https://github.com/apache/doris/pull/33493#discussion_r1560405580 ## be/src/olap/tablet_schema.h: ## @@ -426,6 +429,22 @@ class TabletSchema { return str; } +string dump() const { +string str = "["; Revi

Re: [PR] [fix](compaction)Fix single compaction to get all local versions [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33524: URL: https://github.com/apache/doris/pull/33524#issuecomment-2048887792 TPC-H: Total hot run time: 50470 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Feature](Variant) support aggregation model for Variant type [doris]

2024-04-10 Thread via GitHub
eldenmoon commented on code in PR #33493: URL: https://github.com/apache/doris/pull/33493#discussion_r1560405662 ## be/src/vec/columns/column_object.cpp: ## @@ -735,6 +735,7 @@ void ColumnObject::get(size_t n, Field& res) const { if (!is_finalized()) { const_cast(t

Re: [PR] [fix](merge-cloud) disable ssl in meta check [doris]

2024-04-10 Thread via GitHub
dataroaring merged PR #33516: URL: https://github.com/apache/doris/pull/33516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

(doris) branch master updated: [fix](merge-cloud) disable ssl in meta check (#33516)

2024-04-10 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new b214962dbf8 [fix](merge-cloud) disable ssl i

Re: [I] [Bug] cannot get array internal type [doris]

2024-04-10 Thread via GitHub
caizj commented on issue #33461: URL: https://github.com/apache/doris/issues/33461#issuecomment-2048883034 Which version are you using? I can get the array internal type from information_schema.columns using doris 2.0 *** 2. row *** T

Re: [PR] [Feature](group commit) Group commit block sink support pipelineX [doris]

2024-04-10 Thread via GitHub
mymeiyi commented on code in PR #33481: URL: https://github.com/apache/doris/pull/33481#discussion_r1560402472 ## be/src/vec/sink/writer/vgroup_commit_block_writer.cpp: ## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] [opt](scan) read scan ranges in the order of partitions [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #33515: URL: https://github.com/apache/doris/pull/33515#issuecomment-2048881501 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [pipelineX](broadcast) Set dependency ready if a limited exchange returns EOS [doris]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #33525: URL: https://github.com/apache/doris/pull/33525#issuecomment-2048874200 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [pipelineX](broadcast) Set dependency ready if a limited exchange returns EOS [doris]

2024-04-10 Thread via GitHub
Gabriel39 commented on PR #33525: URL: https://github.com/apache/doris/pull/33525#issuecomment-2048871169 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [pipelineX](broadcast) Set dependency ready if a limited exchange returns EOS [doris]

2024-04-10 Thread via GitHub
Gabriel39 opened a new pull request, #33525: URL: https://github.com/apache/doris/pull/33525 … ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.o

Re: [PR] [pipelineX](broadcast) Set dependency ready if a limited exchange returns EOS [doris]

2024-04-10 Thread via GitHub
doris-robot commented on PR #33525: URL: https://github.com/apache/doris/pull/33525#issuecomment-2048870421 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [Feature](Variant) support aggregation model for Variant type [doris]

2024-04-10 Thread via GitHub
eldenmoon commented on code in PR #33493: URL: https://github.com/apache/doris/pull/33493#discussion_r1560392867 ## be/src/vec/columns/column_object.h: ## @@ -456,13 +460,11 @@ class ColumnObject final : public COWHelper { LOG(FATAL) << "should not call the method in co

  1   2   3   4   5   6   7   8   9   >