BiteTheDDDDt commented on code in PR #33454:
URL: https://github.com/apache/doris/pull/33454#discussion_r1560498437
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/mv/SelectMaterializedIndexWithAggregate.java:
##########
@@ -745,22 +748,22 @@ public PreAggStatus visit(Expression expr, CheckContext
context) {
@Override
public PreAggStatus visitAggregateFunction(AggregateFunction
aggregateFunction, CheckContext context) {
- return checkAggFunc(aggregateFunction, AggregateType.NONE,
context);
+ return checkAggFunc(aggregateFunction, AggregateType.NONE,
context, false);
}
@Override
public PreAggStatus visitMax(Max max, CheckContext context) {
- return checkAggFunc(max, AggregateType.MAX, context);
+ return checkAggFunc(max, AggregateType.MAX, context, true);
Review Comment:
I don't know why min/max should be different from other aggregation methods.
Can you explain it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
