github-actions[bot] commented on code in PR #33493:
URL: https://github.com/apache/doris/pull/33493#discussion_r1560416827
##########
be/src/olap/tablet_schema.h:
##########
@@ -426,6 +429,22 @@ class TabletSchema {
return str;
}
+ string dump_full_schema() const {
Review Comment:
warning: method 'dump_full_schema' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static string dump_full_schema() {
```
##########
be/src/vec/columns/column_array.cpp:
##########
@@ -412,6 +412,23 @@ void ColumnArray::insert(const Field& x) {
}
}
+void ColumnArray::replace(const Field& f, size_t self_row) {
Review Comment:
warning: method 'replace' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/columns/column_array.h:238:
```diff
- void replace(const Field& f, size_t self_row) override;
+ static void replace(const Field& f, size_t self_row) override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
