[GitHub] [doris] github-actions[bot] commented on pull request #21228: [Enhancement](heartbeat) make heartbeat ok when config repeated host-ip pairs

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21228: URL: https://github.com/apache/doris/pull/21228#issuecomment-1608900682 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] morningman commented on pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug

2023-06-26 Thread via GitHub
morningman commented on PR #20926: URL: https://github.com/apache/doris/pull/20926#issuecomment-1608900484 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] morningman commented on a diff in pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug

2023-06-26 Thread via GitHub
morningman commented on code in PR #20926: URL: https://github.com/apache/doris/pull/20926#discussion_r1243224061 ## be/src/service/doris_main.cpp: ## @@ -432,6 +433,12 @@ int main(int argc, char** argv) { doris::ExecEnv::init(exec_env, paths); doris::TabletSchemaCache

[GitHub] [doris] github-actions[bot] commented on pull request #21190: [Improve](modulo) improve modulo performance by eliminating std::fmod

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21190: URL: https://github.com/apache/doris/pull/21190#issuecomment-1608898612 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] zhuzhihao94 opened a new issue, #21234: [Bug] when using NGram index columns as query condition, be crash

2023-06-26 Thread via GitHub
zhuzhihao94 opened a new issue, #21234: URL: https://github.com/apache/doris/issues/21234 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version doris-2.0.0-alpha1

[GitHub] [doris] airborne12 commented on pull request #21190: [Improve](modulo) improve modulo performance by eliminating std::fmod

2023-06-26 Thread via GitHub
airborne12 commented on PR #21190: URL: https://github.com/apache/doris/pull/21190#issuecomment-1608893487 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] Kikyou1997 commented on pull request #21216: [revert](nereids) Revert data size agg

2023-06-26 Thread via GitHub
Kikyou1997 commented on PR #21216: URL: https://github.com/apache/doris/pull/21216#issuecomment-1608893466 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #21233: [fix](s3_writer) init member's value to avoid undefined behavior

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21233: URL: https://github.com/apache/doris/pull/21233#issuecomment-1608892853 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #21233: [fix](s3_writer) init member's value to avoid undefined behavior

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21233: URL: https://github.com/apache/doris/pull/21233#issuecomment-1608889255 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris-website] yagagagaga opened a new pull request, #252: [typo](docs) update spark-doris-connector.md

2023-06-26 Thread via GitHub
yagagagaga opened a new pull request, #252: URL: https://github.com/apache/doris-website/pull/252 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [doris] morningman commented on pull request #21233: [fix](s3_writer) init member's value to avoid undefined behavior

2023-06-26 Thread via GitHub
morningman commented on PR #21233: URL: https://github.com/apache/doris/pull/21233#issuecomment-1608886332 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #21177: [Feature](Compaction)Support full compaction

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21177: URL: https://github.com/apache/doris/pull/21177#issuecomment-1608885538 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] morningman opened a new pull request, #21233: [fix](s3_writer) init member's value to avoid undefined behavior

2023-06-26 Thread via GitHub
morningman opened a new pull request, #21233: URL: https://github.com/apache/doris/pull/21233 ## Proposed changes Must init the value of member, otherwise, the init value is undefined, may causing undefined behavior, for example, when write data using s3 file writer, the `append

[GitHub] [doris] hello-stephen commented on pull request #21215: [chore](build) Fix compilation errors reported by GCC-13

2023-06-26 Thread via GitHub
hello-stephen commented on PR #21215: URL: https://github.com/apache/doris/pull/21215#issuecomment-1608881580 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 41.96 seconds stream load tsv: 462 seconds loaded 74807831229 Bytes, about 154 MB/s

[GitHub] [doris] liutang123 commented on pull request #20389: [debug](executor) Enable workload and debug

2023-06-26 Thread via GitHub
liutang123 commented on PR #20389: URL: https://github.com/apache/doris/pull/20389#issuecomment-1608881102 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #20926: URL: https://github.com/apache/doris/pull/20926#issuecomment-1608879324 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #21201: [Improve](func)support array to window-func first-last-value arg type

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21201: URL: https://github.com/apache/doris/pull/21201#issuecomment-1608878199 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] amorynan commented on pull request #21201: [Improve](func)support array to window-func first-last-value arg type

2023-06-26 Thread via GitHub
amorynan commented on PR #21201: URL: https://github.com/apache/doris/pull/21201#issuecomment-1608875105 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] HHoflittlefish777 commented on pull request #21209: [Refactor](load) Using OwnedSlice to replace Slice

2023-06-26 Thread via GitHub
HHoflittlefish777 commented on PR #21209: URL: https://github.com/apache/doris/pull/21209#issuecomment-1608872421 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [doris] amorynan commented on a diff in pull request #21201: [Improve](func)support array to window-func first-last-value arg type

2023-06-26 Thread via GitHub
amorynan commented on code in PR #21201: URL: https://github.com/apache/doris/pull/21201#discussion_r1243200129 ## be/src/vec/utils/template_helpers.hpp: ## @@ -67,7 +67,8 @@ NUMERIC_TYPE_TO_COLUMN_TYPE(M) \ DECIMAL_TYPE_TO_COLUMN_TYPE(M) \ STRING_TYPE_TO_COLU

[GitHub] [doris] zy-kkk merged pull request #21227: [typo](docs) delete no-used ENABLE-FEATURE doc

2023-06-26 Thread via GitHub
zy-kkk merged PR #21227: URL: https://github.com/apache/doris/pull/21227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apach

[doris] branch master updated: [typo](docs) delete no-used ENABLE-FEATURE doc (#21227)

2023-06-26 Thread zykkk
This is an automated email from the ASF dual-hosted git repository. zykkk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new f7fd891cd3 [typo](docs) delete no-used ENABLE-FEAT

[GitHub] [doris] liutang123 commented on pull request #20389: [debug](executor) Enable workload and debug

2023-06-26 Thread via GitHub
liutang123 commented on PR #20389: URL: https://github.com/apache/doris/pull/20389#issuecomment-1608863579 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [doris] github-actions[bot] commented on pull request #21215: [chore](build) Fix compilation errors reported by GCC-13

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21215: URL: https://github.com/apache/doris/pull/21215#issuecomment-1608862442 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated: [Improve](tools)Add IssueNavigationLink to make IDEA support hyperlink on GitHub PR on Git plugin. (#21231)

2023-06-26 Thread zykkk
This is an automated email from the ASF dual-hosted git repository. zykkk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 20d441aab4 [Improve](tools)Add IssueNavigationLink

[GitHub] [doris] zy-kkk merged pull request #21231: [Improve](tools)Add IssueNavigationLink to make IDEA support hyperlink on GitHub PR on Git plugin.

2023-06-26 Thread via GitHub
zy-kkk merged PR #21231: URL: https://github.com/apache/doris/pull/21231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apach

[GitHub] [doris] amorynan commented on a diff in pull request #21201: [Improve](func)support array to window-func first-last-value arg type

2023-06-26 Thread via GitHub
amorynan commented on code in PR #21201: URL: https://github.com/apache/doris/pull/21201#discussion_r1243189545 ## fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java: ## @@ -1348,6 +1348,38 @@ private void initAggregateBuiltins() { addBuiltin(

[GitHub] [doris] wangbo commented on a diff in pull request #21226: [Opt](scan) opt the scanner schedule logic

2023-06-26 Thread via GitHub
wangbo commented on code in PR #21226: URL: https://github.com/apache/doris/pull/21226#discussion_r1243188593 ## be/src/vec/exec/scan/pip_scanner_context.h: ## @@ -152,23 +152,10 @@ class PipScannerContext : public vectorized::ScannerContext { } bool has_enough_spac

[GitHub] [doris] morningman commented on a diff in pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug

2023-06-26 Thread via GitHub
morningman commented on code in PR #20926: URL: https://github.com/apache/doris/pull/20926#discussion_r1243188619 ## be/src/runtime/exec_env.h: ## @@ -185,6 +185,9 @@ class ExecEnv { void set_stream_load_executor(std::shared_ptr stream_load_executor) { this->_stre

[GitHub] [doris] Chris-Arith closed issue #21128: [Bug] Audit Log stmt not completed

2023-06-26 Thread via GitHub
Chris-Arith closed issue #21128: [Bug] Audit Log stmt not completed URL: https://github.com/apache/doris/issues/21128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [doris] github-actions[bot] commented on pull request #20389: [debug](executor) Enable workload and debug

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #20389: URL: https://github.com/apache/doris/pull/20389#issuecomment-1608858064 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Chris-Arith commented on issue #21128: [Bug] Audit Log stmt not completed

2023-06-26 Thread via GitHub
Chris-Arith commented on issue #21128: URL: https://github.com/apache/doris/issues/21128#issuecomment-1608858005 > You can edit the plugin.conf in auditloader,the parameter 'max_stmt_length' controls the max stmt length to be loaded in audit table, default is 4096. Thanks a lot, it w

[GitHub] [doris-flink-connector] DongLiang-0 commented on pull request #150: Fix issue 149 by appointing a unique uid to each sink operator.

2023-06-26 Thread via GitHub
DongLiang-0 commented on PR #150: URL: https://github.com/apache/doris-flink-connector/pull/150#issuecomment-1608856800 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] adonis0147 commented on pull request #21215: [chore](build) Fix compilation errors reported by GCC-13

2023-06-26 Thread via GitHub
adonis0147 commented on PR #21215: URL: https://github.com/apache/doris/pull/21215#issuecomment-1608856169 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #21232: [Fix](invert index)fix s3 Failed to check the directory

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21232: URL: https://github.com/apache/doris/pull/21232#issuecomment-1608854220 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #21232: [Fix](invert index)fix s3 Failed to check the directory

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21232: URL: https://github.com/apache/doris/pull/21232#issuecomment-1608854014 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] airborne12 commented on pull request #21232: [Fix](invert index)fix s3 Failed to check the directory

2023-06-26 Thread via GitHub
airborne12 commented on PR #21232: URL: https://github.com/apache/doris/pull/21232#issuecomment-1608853468 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] hello-stephen commented on pull request #21229: [improve](error) include detailed messages in rowset reader init error

2023-06-26 Thread via GitHub
hello-stephen commented on PR #21229: URL: https://github.com/apache/doris/pull/21229#issuecomment-1608851590 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 42.68 seconds stream load tsv: 451 seconds loaded 74807831229 Bytes, about 158 MB/s

[GitHub] [doris] github-actions[bot] commented on pull request #21231: [Improve](tools)Add IssueNavigationLink to make IDEA support hyperlink on GitHub PR on Git plugin.

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21231: URL: https://github.com/apache/doris/pull/21231#issuecomment-1608851217 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #21231: [Improve](tools)Add IssueNavigationLink to make IDEA support hyperlink on GitHub PR on Git plugin.

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21231: URL: https://github.com/apache/doris/pull/21231#issuecomment-1608851175 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] zzzxl1993 opened a new pull request, #21232: [Fix](invert index)fix s3 Failed to check the directory

2023-06-26 Thread via GitHub
zzzxl1993 opened a new pull request, #21232: URL: https://github.com/apache/doris/pull/21232 ## Proposed changes Issue Number: close #xxx 1. s3 does not support checking directories ## Further comments If this is a relatively large or complex change, kick o

[GitHub] [doris] wangbo closed pull request #19443: [improvement](executor)Split free block when using shared scan

2023-06-26 Thread via GitHub
wangbo closed pull request #19443: [improvement](executor)Split free block when using shared scan URL: https://github.com/apache/doris/pull/19443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [doris] github-actions[bot] commented on pull request #21139: [Bug](javaudf) fix BE crash if javaudf is push down

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21139: URL: https://github.com/apache/doris/pull/21139#issuecomment-1608846848 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Gabriel39 commented on pull request #21139: [Bug](javaudf) fix BE crash if javaudf is push down

2023-06-26 Thread via GitHub
Gabriel39 commented on PR #21139: URL: https://github.com/apache/doris/pull/21139#issuecomment-1608842497 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] github-actions[bot] commented on pull request #21228: [Enhancement](heartbeat) make heartbeat ok when config repeated host-ip pairs

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21228: URL: https://github.com/apache/doris/pull/21228#issuecomment-1608841894 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] dutyu commented on pull request #21228: [Enhancement](heartbeat) make heartbeat ok when config repeated host-ip pairs

2023-06-26 Thread via GitHub
dutyu commented on PR #21228: URL: https://github.com/apache/doris/pull/21228#issuecomment-1608838148 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] CalvinKirs commented on pull request #21231: [Improve](tools)Add IssueNavigationLink to make IDEA support hyperlink on GitHub PR on Git plugin.

2023-06-26 Thread via GitHub
CalvinKirs commented on PR #21231: URL: https://github.com/apache/doris/pull/21231#issuecomment-1608837218 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] CalvinKirs opened a new pull request, #21231: [Improve](tools)Add IssueNavigationLink to make IDEA support hyperlink on GitHub PR on Git plugin.

2023-06-26 Thread via GitHub
CalvinKirs opened a new pull request, #21231: URL: https://github.com/apache/doris/pull/21231 https://github.com/apache/doris/assets/16631152/6ef6663f-06c6-4caa-a509-b8ae101e6328";> Now we can directly click the link to the pr corresponding to GitHub, without going through the boring

[GitHub] [doris] hello-stephen commented on pull request #21153: [enhance](BufferedReader) don't blocking wait on buffered reader's condition variable

2023-06-26 Thread via GitHub
hello-stephen commented on PR #21153: URL: https://github.com/apache/doris/pull/21153#issuecomment-1608829981 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 42.83 seconds stream load tsv: 457 seconds loaded 74807831229 Bytes, about 156 MB/s

[GitHub] [doris] github-actions[bot] commented on pull request #21230: [Chore](profile) add EnableValuePredicatesRowsetNumber to profile

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21230: URL: https://github.com/apache/doris/pull/21230#issuecomment-1608823672 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] gavinchou commented on a diff in pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug

2023-06-26 Thread via GitHub
gavinchou commented on code in PR #20926: URL: https://github.com/apache/doris/pull/20926#discussion_r1243148303 ## be/src/runtime/exec_env.h: ## @@ -185,6 +185,9 @@ class ExecEnv { void set_stream_load_executor(std::shared_ptr stream_load_executor) { this->_strea

[GitHub] [doris] xzj7019 commented on pull request #21114: [improvement](nereids) Support rf into cte

2023-06-26 Thread via GitHub
xzj7019 commented on PR #21114: URL: https://github.com/apache/doris/pull/21114#issuecomment-1608820326 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] BiteTheDDDDt commented on pull request #21230: [Chore](profile) add EnableValuePredicatesRowsetNumber to profile

2023-06-26 Thread via GitHub
BiteThet commented on PR #21230: URL: https://github.com/apache/doris/pull/21230#issuecomment-1608819972 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] BiteTheDDDDt opened a new pull request, #21230: [Chore](profile) add EnableValuePredicatesRowsetNumber to profile

2023-06-26 Thread via GitHub
BiteThet opened a new pull request, #21230: URL: https://github.com/apache/doris/pull/21230 ## Proposed changes We can use this to see if the push-down predicate on value column is in effect https://github.com/apache/doris/assets/7939630/99c2e589-b49f-4357-9df9-0f80d8e4be20";>

[GitHub] [doris] github-actions[bot] commented on pull request #21228: [Enhancement](heartbeat) make heartbeat ok when config repeated host-ip pairs

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21228: URL: https://github.com/apache/doris/pull/21228#issuecomment-1608812752 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] dutyu commented on pull request #21228: [Enhancement](heartbeat) make heartbeat ok when config repeated host-ip pairs

2023-06-26 Thread via GitHub
dutyu commented on PR #21228: URL: https://github.com/apache/doris/pull/21228#issuecomment-1608809264 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] xzj7019 commented on pull request #21114: [improvement](nereids) Support rf into cte

2023-06-26 Thread via GitHub
xzj7019 commented on PR #21114: URL: https://github.com/apache/doris/pull/21114#issuecomment-1608808062 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #20926: URL: https://github.com/apache/doris/pull/20926#issuecomment-1608807944 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature][fix](fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #20926: URL: https://github.com/apache/doris/pull/20926#issuecomment-1608807632 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] morningman commented on pull request #20926: [feature](fix)(fs)(s3)add fs_s3 benchmark tool and fix s3 file writer bug

2023-06-26 Thread via GitHub
morningman commented on PR #20926: URL: https://github.com/apache/doris/pull/20926#issuecomment-1608807354 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #21228: [Enhancement](heartbeat) make heartbeat ok when config repeated host-ip pairs

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21228: URL: https://github.com/apache/doris/pull/21228#issuecomment-1608798147 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #21227: [typo](docs) delete no-used ENABLE-FEATURE doc

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21227: URL: https://github.com/apache/doris/pull/21227#issuecomment-1608796956 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #21227: [typo](docs) delete no-used ENABLE-FEATURE doc

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21227: URL: https://github.com/apache/doris/pull/21227#issuecomment-1608796996 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #21229: [improve](error) include detailed messages in rowset reader init error

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21229: URL: https://github.com/apache/doris/pull/21229#issuecomment-1608796692 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] zy-kkk commented on pull request #21227: [typo](docs) delete no-used ENABLE-FEATURE doc

2023-06-26 Thread via GitHub
zy-kkk commented on PR #21227: URL: https://github.com/apache/doris/pull/21227#issuecomment-1608796654 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] kaijchen commented on pull request #21229: [improve](error) include detailed messages in rowset reader init error

2023-06-26 Thread via GitHub
kaijchen commented on PR #21229: URL: https://github.com/apache/doris/pull/21229#issuecomment-1608796023 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] dutyu commented on pull request #21228: [Enhancement](heartbeat) make heartbeat ok when config repeated host-ip pairs

2023-06-26 Thread via GitHub
dutyu commented on PR #21228: URL: https://github.com/apache/doris/pull/21228#issuecomment-1608794962 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] github-actions[bot] commented on pull request #21174: [improvement](workloadgroup)add check when drop/set workload group

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21174: URL: https://github.com/apache/doris/pull/21174#issuecomment-1608794528 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] kaijchen opened a new pull request, #21229: [improve](error) include detailed messages in rowset reader init error

2023-06-26 Thread via GitHub
kaijchen opened a new pull request, #21229: URL: https://github.com/apache/doris/pull/21229 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto

[GitHub] [doris] hello-stephen commented on pull request #21221: [typo](nativeInsertStmt) fix object-stored column exception description

2023-06-26 Thread via GitHub
hello-stephen commented on PR #21221: URL: https://github.com/apache/doris/pull/21221#issuecomment-1608793119 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.96 seconds stream load tsv: 460 seconds loaded 74807831229 Bytes, about 155 MB/s

[GitHub] [doris] architectpub commented on issue #21081: [Bug] ERROR when upgrade 1.2.4.1 to 1.2.5

2023-06-26 Thread via GitHub
architectpub commented on issue #21081: URL: https://github.com/apache/doris/issues/21081#issuecomment-1608790661 > Check that all of your lib packages have been replaced. according the document ,copy the meta-data of 1.2.4 to 1.2.5 ,still has issue with FE. Finally installed t

[GitHub] [doris] github-actions[bot] commented on pull request #21182: [fix](planner)the resultExprs should be substituted using table function node's outputSmap

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21182: URL: https://github.com/apache/doris/pull/21182#issuecomment-1608787967 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #21182: [fix](planner)the resultExprs should be substituted using table function node's outputSmap

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21182: URL: https://github.com/apache/doris/pull/21182#issuecomment-1608788015 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #21205: [enhancement](query) enable strong consistency by syncing max journal id from master

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21205: URL: https://github.com/apache/doris/pull/21205#issuecomment-1608787754 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #21228: [Enhancement](heartbeat) make heartbeat ok when config repeated host-ip pairs

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21228: URL: https://github.com/apache/doris/pull/21228#issuecomment-1608785475 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Gabriel39 commented on pull request #21139: [Bug](javaudf) fix BE crash if javaudf is push down

2023-06-26 Thread via GitHub
Gabriel39 commented on PR #21139: URL: https://github.com/apache/doris/pull/21139#issuecomment-1608785243 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] TangSiyang2001 commented on pull request #21205: [enhancement](query) enable strong consistency by syncing max journal id from master

2023-06-26 Thread via GitHub
TangSiyang2001 commented on PR #21205: URL: https://github.com/apache/doris/pull/21205#issuecomment-1608783821 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] morrySnow commented on pull request #21168: [refactor](Nereids) refactor physical properties and plan translator

2023-06-26 Thread via GitHub
morrySnow commented on PR #21168: URL: https://github.com/apache/doris/pull/21168#issuecomment-1608782415 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] dutyu opened a new pull request, #21228: [Enhancement](heartbeat) make heartbeat ok when config repeated host-ip pairs

2023-06-26 Thread via GitHub
dutyu opened a new pull request, #21228: URL: https://github.com/apache/doris/pull/21228 ## Proposed changes Add some deduplication code when analysing BE's hostname. ## Further comments If this is a relatively large or complex change, kick off the discussion

[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature](fs)add fs_s3 benchmark tool

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #20926: URL: https://github.com/apache/doris/pull/20926#issuecomment-1608781624 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] ixzc opened a new pull request, #21227: Modify sidebars.json

2023-06-26 Thread via GitHub
ixzc opened a new pull request, #21227: URL: https://github.com/apache/doris/pull/21227 ## Proposed changes I modified the sidebars.json document in docs, removed the description of ENABLE-FEATURE.md, and deleted its corresponding Chinese and English documents. ## F

[GitHub] [doris] github-actions[bot] commented on pull request #21226: [Opt](scan) opt the scanner schedule logic

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21226: URL: https://github.com/apache/doris/pull/21226#issuecomment-1608774366 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] amorynan commented on a diff in pull request #21201: [Improve](func)support array to window-func first-last-value arg type

2023-06-26 Thread via GitHub
amorynan commented on code in PR #21201: URL: https://github.com/apache/doris/pull/21201#discussion_r1243123358 ## be/src/vec/utils/template_helpers.hpp: ## @@ -67,7 +67,8 @@ NUMERIC_TYPE_TO_COLUMN_TYPE(M) \ DECIMAL_TYPE_TO_COLUMN_TYPE(M) \ STRING_TYPE_TO_COLU

[GitHub] [doris] HappenLee commented on pull request #21225: [opt](hashmap) memset the hashmap memory to improve performance

2023-06-26 Thread via GitHub
HappenLee commented on PR #21225: URL: https://github.com/apache/doris/pull/21225#issuecomment-1608770412 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] HappenLee commented on pull request #21226: [Opt](scan) opt the scanner schedule logic

2023-06-26 Thread via GitHub
HappenLee commented on PR #21226: URL: https://github.com/apache/doris/pull/21226#issuecomment-1608770325 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] HappenLee opened a new pull request, #21226: [Opt](scan) opt the scanner schedule logic

2023-06-26 Thread via GitHub
HappenLee opened a new pull request, #21226: URL: https://github.com/apache/doris/pull/21226 ## Proposed changes Opt scanner schedule logic, delete useless profile timer before: 50ms after: 15ms ## Further comments If this is a relatively large or comple

[GitHub] [doris] zhangstar333 commented on a diff in pull request #21201: [Improve](func)support array to window-func first-last-value arg type

2023-06-26 Thread via GitHub
zhangstar333 commented on code in PR #21201: URL: https://github.com/apache/doris/pull/21201#discussion_r1243118886 ## fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java: ## @@ -1348,6 +1348,38 @@ private void initAggregateBuiltins() { addBuiltin(

[GitHub] [doris] zhangstar333 commented on a diff in pull request #21201: [Improve](func)support array to window-func first-last-value arg type

2023-06-26 Thread via GitHub
zhangstar333 commented on code in PR #21201: URL: https://github.com/apache/doris/pull/21201#discussion_r1243118224 ## be/src/vec/utils/template_helpers.hpp: ## @@ -67,7 +67,8 @@ NUMERIC_TYPE_TO_COLUMN_TYPE(M) \ DECIMAL_TYPE_TO_COLUMN_TYPE(M) \ STRING_TYPE_TO_

[GitHub] [doris] amorynan commented on a diff in pull request #21109: [Improve](serde)update serialize and deserialize text for data type

2023-06-26 Thread via GitHub
amorynan commented on code in PR #21109: URL: https://github.com/apache/doris/pull/21109#discussion_r1243114148 ## be/src/vec/data_types/serde/data_type_number_serde.cpp: ## @@ -92,6 +95,63 @@ void DataTypeNumberSerDe::write_column_to_arrow(const IColumn& column, const }

[GitHub] [doris] github-actions[bot] commented on pull request #21205: [enhancement](query) enable strong consistency by syncing max journal id from master

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21205: URL: https://github.com/apache/doris/pull/21205#issuecomment-1608758344 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] xzj7019 commented on pull request #21114: [improvement](nereids) Support rf into cte

2023-06-26 Thread via GitHub
xzj7019 commented on PR #21114: URL: https://github.com/apache/doris/pull/21114#issuecomment-1608758282 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #21139: [Bug](javaudf) fix BE crash if javaudf is push down

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21139: URL: https://github.com/apache/doris/pull/21139#issuecomment-1608755911 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #21201: [Improve](func)support array to window-func first-last-value arg type

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21201: URL: https://github.com/apache/doris/pull/21201#issuecomment-1608753139 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] TangSiyang2001 commented on pull request #21205: [enhancement](query) enable strong consistency by syncing max journal id from master

2023-06-26 Thread via GitHub
TangSiyang2001 commented on PR #21205: URL: https://github.com/apache/doris/pull/21205#issuecomment-1608752962 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[doris] branch master updated (70ddf64126 -> 4b94d34ec2)

2023-06-26 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 70ddf64126 [Chore](agg-state) add documentation about agg_state, add group_concat agg_state test case (#21147)

[GitHub] [doris] dataroaring merged pull request #21198: [fix](regression) Add get master token into regression framework

2023-06-26 Thread via GitHub
dataroaring merged PR #21198: URL: https://github.com/apache/doris/pull/21198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[GitHub] [doris] github-actions[bot] commented on pull request #21225: [opt](hashmap) memset the hashmap memory to improve performance

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21225: URL: https://github.com/apache/doris/pull/21225#issuecomment-1608751192 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #21209: [Refactor](load) Using OwnedSlice to replace Slice

2023-06-26 Thread via GitHub
github-actions[bot] commented on PR #21209: URL: https://github.com/apache/doris/pull/21209#issuecomment-1608741865 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] HappenLee commented on pull request #21225: [opt](hashmap) memset the hashmap memory to improve performance

2023-06-26 Thread via GitHub
HappenLee commented on PR #21225: URL: https://github.com/apache/doris/pull/21225#issuecomment-1608741839 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] HappenLee opened a new pull request, #21225: [opt](hashmap) memset the hashmap memory to improve performance

2023-06-26 Thread via GitHub
HappenLee opened a new pull request, #21225: URL: https://github.com/apache/doris/pull/21225 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt

  1   2   3   4   5   6   >