gavinchou commented on code in PR #20926:
URL: https://github.com/apache/doris/pull/20926#discussion_r1243148303
##########
be/src/runtime/exec_env.h:
##########
@@ -185,6 +185,9 @@ class ExecEnv {
void set_stream_load_executor(std::shared_ptr<StreamLoadExecutor>
stream_load_executor) {
this->_stream_load_executor = stream_load_executor;
}
+ void set_buffered_reader_prefetch_thread_pool(ThreadPool* thread_pool) {
Review Comment:
Is this function referenced somewhere?
##########
be/src/service/doris_main.cpp:
##########
@@ -432,6 +433,12 @@ int main(int argc, char** argv) {
doris::ExecEnv::init(exec_env, paths);
doris::TabletSchemaCache::create_global_schema_cache();
+ // init s3 write buffer pool
+ doris::io::S3FileBufferPool* s3_buffer_pool =
doris::io::S3FileBufferPool::GetInstance();
+ s3_buffer_pool->init(doris::config::s3_write_buffer_whole_size,
+ doris::config::s3_write_buffer_size,
+ exec_env->buffered_reader_prefetch_thread_pool());
Review Comment:
Is it intent to reuse the "reader thread pool"?
It seems not a good idea. I suggest making them isolated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
