zhangstar333 commented on code in PR #21201: URL: https://github.com/apache/doris/pull/21201#discussion_r1243118224
########## be/src/vec/utils/template_helpers.hpp: ########## @@ -67,7 +67,8 @@ NUMERIC_TYPE_TO_COLUMN_TYPE(M) \ DECIMAL_TYPE_TO_COLUMN_TYPE(M) \ STRING_TYPE_TO_COLUMN_TYPE(M) \ - TIME_TYPE_TO_COLUMN_TYPE(M) + TIME_TYPE_TO_COLUMN_TYPE(M) \ + COMPLEX_TYPE_TO_COLUMN_TYPE(M) #define TYPE_TO_COLUMN_TYPE(M) \ TYPE_TO_BASIC_COLUMN_TYPE(M) \ Review Comment: seems could use this macro dirctly in be/src/vec/aggregate_functions/aggregate_function_window.cpp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org