[GitHub] [doris] luozenglin opened a new pull request, #16468: [fix](func) fix truncate float type result error

2023-02-06 Thread via GitHub
luozenglin opened a new pull request, #16468: URL: https://github.com/apache/doris/pull/16468 # Proposed changes Issue Number: close #16467 ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [

[GitHub] [doris] englefly commented on a diff in pull request #16442: [fix](planner) fix bug in agg on constant column

2023-02-06 Thread via GitHub
englefly commented on code in PR #16442: URL: https://github.com/apache/doris/pull/16442#discussion_r1098296944 ## fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java: ## @@ -1291,11 +1291,54 @@ private void analyzeAggregation(Analyzer analyzer) throws AnalysisEx

[GitHub] [doris] englefly commented on pull request #16442: [fix](planner) fix bug in agg on constant column

2023-02-06 Thread via GitHub
englefly commented on PR #16442: URL: https://github.com/apache/doris/pull/16442#issuecomment-1420342741 @starocean999 PTAL. This pr is related to ur previous fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] Tanya-W commented on a diff in pull request #16371: [Feature-WIP](inverted index) Implementation for alter inverted index.

2023-02-06 Thread via GitHub
Tanya-W commented on code in PR #16371: URL: https://github.com/apache/doris/pull/16371#discussion_r1098289372 ## be/src/olap/schema_change.cpp: ## @@ -576,6 +583,248 @@ Status VSchemaChangeWithSorting::_external_sorting(vector& src_ return Status::OK(); } +SchemaChange

[GitHub] [doris] hello-stephen commented on pull request #16463: [Bug](pipeline) Fix bug in non-local exchange on pipeline engine

2023-02-06 Thread via GitHub
hello-stephen commented on PR #16463: URL: https://github.com/apache/doris/pull/16463#issuecomment-1420326777 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.48 seconds load time: 490 seconds storage size: 17170484342 Bytes https://doris-co

[GitHub] [doris] englefly commented on a diff in pull request #16449: [enhancement](nereids)enhance InnerJoinLAsscomProject rule

2023-02-06 Thread via GitHub
englefly commented on code in PR #16449: URL: https://github.com/apache/doris/pull/16449#discussion_r1098272279 ## fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java: ## @@ -311,6 +311,23 @@ public static List replaceJoinConjuncts(List joinConjunc

[GitHub] [doris] luozenglin opened a new issue, #16467: [Bug] truncate function calculates float type result error

2023-02-06 Thread via GitHub
luozenglin opened a new issue, #16467: URL: https://github.com/apache/doris/issues/16467 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version master ### Wha

[GitHub] [doris] github-actions[bot] commented on pull request #16258: [feature](cooldown)Add cooldown delete

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16258: URL: https://github.com/apache/doris/pull/16258#issuecomment-1420321293 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16466: [Pipeline][WIP] Introduce pipeline tracing

2023-02-06 Thread via GitHub
github-actions[bot] commented on code in PR #16466: URL: https://github.com/apache/doris/pull/16466#discussion_r1098272444 ## be/src/runtime/thread_context.h: ## @@ -182,15 +191,24 @@ // to nullptr, but the object it points to is not initialized. At this time, when the mem

[GitHub] [doris] Tanya-W commented on a diff in pull request #16371: [Feature-WIP](inverted index) Implementation for alter inverted index.

2023-02-06 Thread via GitHub
Tanya-W commented on code in PR #16371: URL: https://github.com/apache/doris/pull/16371#discussion_r1098271701 ## be/src/vec/olap/olap_data_convertor.h: ## @@ -46,13 +46,16 @@ class IOlapColumnDataAccessor { class OlapBlockDataConvertor { public: +OlapBlockDataConvertor(

[GitHub] [doris] englefly commented on pull request #16449: [enhancement](nereids)enhance InnerJoinLAsscomProject rule

2023-02-06 Thread via GitHub
englefly commented on PR #16449: URL: https://github.com/apache/doris/pull/16449#issuecomment-1420317616 Could you explain the enhance point? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [doris] github-actions[bot] commented on pull request #16466: [Pipeline][WIP] Introduce pipeline tracing

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16466: URL: https://github.com/apache/doris/pull/16466#issuecomment-1420315927 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4111551468";) output. shellcheck err

[GitHub] [doris] zclllyybb opened a new pull request, #16466: [Pipeline][WIP] Introduce pipeline tracing

2023-02-06 Thread via GitHub
zclllyybb opened a new pull request, #16466: URL: https://github.com/apache/doris/pull/16466 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Y

[GitHub] [doris] luzhijing commented on pull request #14856: [doc](flink-connector) Update the flink connector docs to the latest version

2023-02-06 Thread via GitHub
luzhijing commented on PR #14856: URL: https://github.com/apache/doris/pull/14856#issuecomment-1420314378 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [doris] Tanya-W commented on a diff in pull request #16371: [Feature-WIP](inverted index) Implementation for alter inverted index.

2023-02-06 Thread via GitHub
Tanya-W commented on code in PR #16371: URL: https://github.com/apache/doris/pull/16371#discussion_r1098265163 ## gensrc/thrift/PlanNodes.thrift: ## @@ -574,6 +574,7 @@ struct TOlapScanNode { 11: optional bool enable_unique_key_merge_on_write 12: optional TPushAggOp push_d

[GitHub] [doris] Tanya-W commented on a diff in pull request #16371: [Feature-WIP](inverted index) Implementation for alter inverted index.

2023-02-06 Thread via GitHub
Tanya-W commented on code in PR #16371: URL: https://github.com/apache/doris/pull/16371#discussion_r1098264968 ## fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java: ## @@ -2367,4 +2403,212 @@ public void replayModifyTableAddOrDropColumns(TableAddOrDropCol

[GitHub] [doris] Tanya-W commented on a diff in pull request #16371: [Feature-WIP](inverted index) Implementation for alter inverted index.

2023-02-06 Thread via GitHub
Tanya-W commented on code in PR #16371: URL: https://github.com/apache/doris/pull/16371#discussion_r1098264569 ## fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java: ## @@ -337,6 +366,10 @@ protected void runPendingJob() throws AlterCancelException { }

[GitHub] [doris] Tanya-W commented on a diff in pull request #16371: [Feature-WIP](inverted index) Implementation for alter inverted index.

2023-02-06 Thread via GitHub
Tanya-W commented on code in PR #16371: URL: https://github.com/apache/doris/pull/16371#discussion_r1098264089 ## be/src/olap/schema_change.cpp: ## @@ -576,6 +583,248 @@ Status VSchemaChangeWithSorting::_external_sorting(vector& src_ return Status::OK(); } +SchemaChange

[GitHub] [doris] Tanya-W commented on a diff in pull request #16371: [Feature-WIP](inverted index) Implementation for alter inverted index.

2023-02-06 Thread via GitHub
Tanya-W commented on code in PR #16371: URL: https://github.com/apache/doris/pull/16371#discussion_r1098264279 ## be/src/olap/task/engine_alter_tablet_task.cpp: ## @@ -45,4 +45,34 @@ Status EngineAlterTabletTask::execute() { return res; } // execute +EngineAlterInvertedI

[GitHub] [doris] nextdreamblue commented on a diff in pull request #16461: [fix](compute_node) fix backend_num_for_federation bug for federation…

2023-02-06 Thread via GitHub
nextdreamblue commented on code in PR #16461: URL: https://github.com/apache/doris/pull/16461#discussion_r1098258094 ## docs/en/docs/advanced/compute_node.md: ## @@ -96,15 +96,17 @@ HeartbeatFailureCounter: 0 ``` ### Usage -When using the [MultiCatalog](../lakehouse/multi-ca

[GitHub] [doris] luzhijing commented on pull request #16465: [typo](doc)retention function add 1.2 tags

2023-02-06 Thread via GitHub
luzhijing commented on PR #16465: URL: https://github.com/apache/doris/pull/16465#issuecomment-1420303204 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [doris] nextdreamblue commented on a diff in pull request #16461: [fix](compute_node) fix backend_num_for_federation bug for federation…

2023-02-06 Thread via GitHub
nextdreamblue commented on code in PR #16461: URL: https://github.com/apache/doris/pull/16461#discussion_r1098256138 ## fe/fe-common/src/main/java/org/apache/doris/common/Config.java: ## @@ -1819,6 +1819,8 @@ public class Config extends ConfigBase { * The candidate of the

[GitHub] [doris] caoliang-web opened a new pull request, #16465: [typo](doc)retention function add 1.2 tags

2023-02-06 Thread via GitHub
caoliang-web opened a new pull request, #16465: URL: https://github.com/apache/doris/pull/16465 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [

[GitHub] [doris] SaintBacchus commented on a diff in pull request #16461: [fix](compute_node) fix backend_num_for_federation bug for federation…

2023-02-06 Thread via GitHub
SaintBacchus commented on code in PR #16461: URL: https://github.com/apache/doris/pull/16461#discussion_r1098245293 ## docs/en/docs/advanced/compute_node.md: ## @@ -96,15 +96,17 @@ HeartbeatFailureCounter: 0 ``` ### Usage -When using the [MultiCatalog](../lakehouse/multi-cat

[GitHub] [doris] caoliang-web opened a new pull request, #16464: [typo](doc)Modify thrift_rpc_timeout_ms default value documentation

2023-02-06 Thread via GitHub
caoliang-web opened a new pull request, #16464: URL: https://github.com/apache/doris/pull/16464 ## Problem summary 1.Modify thrift_rpc_timeout_ms default value documentation ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No

[GitHub] [doris] SaintBacchus commented on a diff in pull request #16461: [fix](compute_node) fix backend_num_for_federation bug for federation…

2023-02-06 Thread via GitHub
SaintBacchus commented on code in PR #16461: URL: https://github.com/apache/doris/pull/16461#discussion_r1098242232 ## fe/fe-common/src/main/java/org/apache/doris/common/Config.java: ## @@ -1819,6 +1819,8 @@ public class Config extends ConfigBase { * The candidate of the b

[GitHub] [doris] github-actions[bot] commented on pull request #16463: [Bug](pipeline) Fix bug in non-local exchange on pipeline engine

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16463: URL: https://github.com/apache/doris/pull/16463#issuecomment-1420282912 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] caoliang-web closed pull request #15887: [regression](flink)add flink doris connector case

2023-02-06 Thread via GitHub
caoliang-web closed pull request #15887: [regression](flink)add flink doris connector case URL: https://github.com/apache/doris/pull/15887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [doris] caoliang-web closed pull request #16334: [typo](doc)The retention function adds 1.2 tags

2023-02-06 Thread via GitHub
caoliang-web closed pull request #16334: [typo](doc)The retention function adds 1.2 tags URL: https://github.com/apache/doris/pull/16334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [doris] github-actions[bot] commented on pull request #15249: [pipeline](test) test regression

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #15249: URL: https://github.com/apache/doris/pull/15249#issuecomment-1420280114 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] caoliang-web closed pull request #14723: [improvement](doriswriter)Modify the maxRetries parameter to take effect

2023-02-06 Thread via GitHub
caoliang-web closed pull request #14723: [improvement](doriswriter)Modify the maxRetries parameter to take effect URL: https://github.com/apache/doris/pull/14723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [doris] hello-stephen commented on pull request #16461: [fix](compute_node) fix backend_num_for_federation bug for federation…

2023-02-06 Thread via GitHub
hello-stephen commented on PR #16461: URL: https://github.com/apache/doris/pull/16461#issuecomment-1420279869 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.38 seconds load time: 471 seconds storage size: 17170856498 Bytes https://doris-co

[GitHub] [doris] Gabriel39 opened a new pull request, #16463: [Bug](pipeline) Fix bug in non-local exchange on pipeline engine

2023-02-06 Thread via GitHub
Gabriel39 opened a new pull request, #16463: URL: https://github.com/apache/doris/pull/16463 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Y

[GitHub] [doris] siriume commented on issue #16392: Doris Roadmap 2023

2023-02-06 Thread via GitHub
siriume commented on issue #16392: URL: https://github.com/apache/doris/issues/16392#issuecomment-1420276689 mutil group_concat(distinct xxx) is a function we urgently need now. The current solution is to implement it through the join of multiple subqueries. Because the scanned rows are too

[GitHub] [doris] yixiutt opened a new pull request, #16462: [enhancement](compaction) set base compaction idle schedule

2023-02-06 Thread via GitHub
yixiutt opened a new pull request, #16462: URL: https://github.com/apache/doris/pull/16462 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes

[GitHub] [doris] YangShaw commented on a diff in pull request #14397: [feature](nereids)support window function

2023-02-06 Thread via GitHub
YangShaw commented on code in PR #14397: URL: https://github.com/apache/doris/pull/14397#discussion_r1098228130 ## fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4: ## @@ -327,6 +332,32 @@ functionIdentifier | LEFT | RIGHT ; +windowSpec +: name=

[GitHub] [doris] nextdreamblue opened a new pull request, #16461: [fix](compute_node) fix backend_num_for_federation bug for federation…

2023-02-06 Thread via GitHub
nextdreamblue opened a new pull request, #16461: URL: https://github.com/apache/doris/pull/16461 … query Signed-off-by: nextdreamblue # Proposed changes Issue Number: close #13144 ## Problem summary Describe your changes. ## Checklist(Required)

[GitHub] [doris] Accelarator commented on issue #16446: [WIP] Release Note 1.2.2

2023-02-06 Thread via GitHub
Accelarator commented on issue #16446: URL: https://github.com/apache/doris/issues/16446#issuecomment-1420261737 https://github.com/apache/doris/commit/c61be0cb8a85cda1b61b1bc0535020488207b46c 这个不发吗 -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [doris] caiconghui commented on a diff in pull request #15830: [enhancement](load) change transaction limit from global level to db level

2023-02-06 Thread via GitHub
caiconghui commented on code in PR #15830: URL: https://github.com/apache/doris/pull/15830#discussion_r1098197861 ## fe/fe-core/src/main/java/org/apache/doris/catalog/Database.java: ## @@ -603,6 +619,13 @@ public void readFields(DataInput in) throws IOException { if (

[GitHub] [doris] caiconghui commented on a diff in pull request #15830: [enhancement](load) change transaction limit from global level to db level

2023-02-06 Thread via GitHub
caiconghui commented on code in PR #15830: URL: https://github.com/apache/doris/pull/15830#discussion_r1098196704 ## fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java: ## @@ -1532,9 +1530,10 @@ protected void checkRunningTxnExceedLimit(Transactio

[GitHub] [doris] caiconghui commented on a diff in pull request #15830: [enhancement](load) change transaction limit from global level to db level

2023-02-06 Thread via GitHub
caiconghui commented on code in PR #15830: URL: https://github.com/apache/doris/pull/15830#discussion_r1098195999 ## fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java: ## @@ -1532,9 +1530,10 @@ protected void checkRunningTxnExceedLimit(Transactio

[GitHub] [doris] caiconghui commented on a diff in pull request #15830: [enhancement](load) change transaction limit from global level to db level

2023-02-06 Thread via GitHub
caiconghui commented on code in PR #15830: URL: https://github.com/apache/doris/pull/15830#discussion_r1098195000 ## fe/fe-core/src/main/java/org/apache/doris/load/sync/canal/CanalSyncChannel.java: ## @@ -124,7 +124,9 @@ public void beginTxn(long batchId) throws UserException,

[doris] branch master updated: [DecimalV3](opt) opt the function of decimalv3 to_string logic (#16427)

2023-02-06 Thread gabriellee
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 9114896178 [DecimalV3](opt) opt the function

[GitHub] [doris] Gabriel39 merged pull request #16427: [DecimalV3](opt) opt the function of decimalv3 to_string logic

2023-02-06 Thread via GitHub
Gabriel39 merged PR #16427: URL: https://github.com/apache/doris/pull/16427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] github-actions[bot] commented on pull request #16453: [bugfix](writer) add _is_closed state to DeltaWriter and avoid write/close core after close

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16453: URL: https://github.com/apache/doris/pull/16453#issuecomment-1420217563 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated: [enhance](fuzzy)set rewriteOrToInPredicateThreshold=2/10000 in fuzzy mode (#16456)

2023-02-06 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 796d51ae2e [enhance](fuzzy)set rewriteOrToInPre

[GitHub] [doris] yiguolei merged pull request #16456: [enhance](fuzzy)set rewriteOrToInPredicateThreshold=2/10000 in fuzzy mode

2023-02-06 Thread via GitHub
yiguolei merged PR #16456: URL: https://github.com/apache/doris/pull/16456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [enhancement](stream receiver) make stream receiver exception safe (#16412)

2023-02-06 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new d390e63a03 [enhancement](stream receiver) make

[GitHub] [doris] yiguolei merged pull request #16412: [enhancement](stream receiver) make stream receiver exception safe

2023-02-06 Thread via GitHub
yiguolei merged PR #16412: URL: https://github.com/apache/doris/pull/16412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] hello-stephen commented on pull request #16460: [Bug](sort) disable 2phase read for sort by expressions exclude slotref

2023-02-06 Thread via GitHub
hello-stephen commented on PR #16460: URL: https://github.com/apache/doris/pull/16460#issuecomment-1420190980 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.78 seconds load time: 469 seconds storage size: 17170899382 Bytes https://doris-co

[GitHub] [doris] hello-stephen commented on pull request #16459: [fix](planner)Fix colocate query failed

2023-02-06 Thread via GitHub
hello-stephen commented on PR #16459: URL: https://github.com/apache/doris/pull/16459#issuecomment-1420186361 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.31 seconds load time: 474 seconds storage size: 17170930960 Bytes https://doris-co

[doris] branch master updated (bed1ab7c19 -> 6fdd35a6f2)

2023-02-06 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from bed1ab7c19 [Feature](Nereids) Add hint to enable pre-aggregation when scan OLAP table. (#15614) add 6fdd35a6f2

[GitHub] [doris] yiguolei merged pull request #16441: [enhancement](mpp process) remove unused method and make report process more clear

2023-02-06 Thread via GitHub
yiguolei merged PR #16441: URL: https://github.com/apache/doris/pull/16441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] eldenmoon opened a new pull request, #16460: [Bug](sort) disable 2phase read for sort by expressions exclude slotref

2023-02-06 Thread via GitHub
eldenmoon opened a new pull request, #16460: URL: https://github.com/apache/doris/pull/16460 ``` create table tbl1 (k1 varchar(100), k2 string) distributed by hash(k1) buckets 1 properties("replication_num" = "1"); insert into tbl1 values(1, "alice"); select cast(k1 as INT)

[GitHub] [doris] zddr commented on a diff in pull request #16091: [feature](auth)Implementing privilege management with rbac model

2023-02-06 Thread via GitHub
zddr commented on code in PR #16091: URL: https://github.com/apache/doris/pull/16091#discussion_r1098155911 ## fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserRoleManager.java: ## @@ -0,0 +1,137 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

[GitHub] [doris] zddr commented on a diff in pull request #16091: [feature](auth)Implementing privilege management with rbac model

2023-02-06 Thread via GitHub
zddr commented on code in PR #16091: URL: https://github.com/apache/doris/pull/16091#discussion_r1098155028 ## fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserManager.java: ## @@ -0,0 +1,342 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or m

[GitHub] [doris] wangbo commented on pull request #16459: (#16458)Fix colocate query failed

2023-02-06 Thread via GitHub
wangbo commented on PR #16459: URL: https://github.com/apache/doris/pull/16459#issuecomment-1420172435 I will add regression test later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [doris] wangbo opened a new pull request, #16459: (#16458)Fix colocate query failed

2023-02-06 Thread via GitHub
wangbo opened a new pull request, #16459: URL: https://github.com/apache/doris/pull/16459 # Proposed changes Issue Number: close #16458 ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Ye

[GitHub] [doris] wangbo opened a new issue, #16458: [Bug] Query same tablet but hits different rollup should not use colocate join

2023-02-06 Thread via GitHub
wangbo opened a new issue, #16458: URL: https://github.com/apache/doris/issues/16458 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version master ### What's

[GitHub] [doris] github-actions[bot] commented on pull request #16412: [enhancement](stream receiver) make stream receiver exception safe

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16412: URL: https://github.com/apache/doris/pull/16412#issuecomment-1420168667 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16412: [enhancement](stream receiver) make stream receiver exception safe

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16412: URL: https://github.com/apache/doris/pull/16412#issuecomment-1420168619 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16441: [enhancement](mpp process) remove unused method and make report process more clear

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16441: URL: https://github.com/apache/doris/pull/16441#issuecomment-1420167548 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16441: [enhancement](mpp process) remove unused method and make report process more clear

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16441: URL: https://github.com/apache/doris/pull/16441#issuecomment-1420167509 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[doris] branch master updated (27216dc7e0 -> bed1ab7c19)

2023-02-06 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 27216dc7e0 [improvement](multi-catalog) push down all predicates into rowgroup/page filtering for ParquetReader (#1

[GitHub] [doris] morrySnow merged pull request #15614: [Feature](Nereids) Add hint to enable pre-aggregation when scan OLAP table.

2023-02-06 Thread via GitHub
morrySnow merged PR #15614: URL: https://github.com/apache/doris/pull/15614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] github-actions[bot] commented on pull request #15614: [Feature](Nereids) Add hint to enable pre-aggregation when scan OLAP table.

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #15614: URL: https://github.com/apache/doris/pull/15614#issuecomment-1420161107 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #15614: [Feature](Nereids) Add hint to enable pre-aggregation when scan OLAP table.

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #15614: URL: https://github.com/apache/doris/pull/15614#issuecomment-1420161078 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16451: [Chore](build) make compile option work on C objects && some refactor of cmakelists

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16451: URL: https://github.com/apache/doris/pull/16451#issuecomment-1420160164 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Yukang-Lian commented on a diff in pull request #16382: [Feature](array-function) Support array functions for nested type datev2 and datetimev2

2023-02-06 Thread via GitHub
Yukang-Lian commented on code in PR #16382: URL: https://github.com/apache/doris/pull/16382#discussion_r1098144948 ## fe/fe-common/src/main/java/org/apache/doris/common/Config.java: ## @@ -1717,7 +1717,7 @@ public class Config extends ConfigBase { * If set to TRUE, FE will

[GitHub] [doris] Yukang-Lian commented on a diff in pull request #16382: [Feature](array-function) Support array functions for nested type datev2 and datetimev2

2023-02-06 Thread via GitHub
Yukang-Lian commented on code in PR #16382: URL: https://github.com/apache/doris/pull/16382#discussion_r1098144948 ## fe/fe-common/src/main/java/org/apache/doris/common/Config.java: ## @@ -1717,7 +1717,7 @@ public class Config extends ConfigBase { * If set to TRUE, FE will

[GitHub] [doris] hello-stephen commented on pull request #16456: [enhance](fuzzy)set rewriteOrToInPredicateThreshold=2/10000 in fuzzy mode

2023-02-06 Thread via GitHub
hello-stephen commented on PR #16456: URL: https://github.com/apache/doris/pull/16456#issuecomment-1420156964 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.08 seconds load time: 468 seconds storage size: 17170978889 Bytes https://doris-co

[GitHub] [doris] github-actions[bot] commented on pull request #16427: [DecimalV3](opt) opt the function of decimalv3 to_string logic

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16427: URL: https://github.com/apache/doris/pull/16427#issuecomment-1420155067 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated: [improvement](multi-catalog) push down all predicates into rowgroup/page filtering for ParquetReader (#16388)

2023-02-06 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 27216dc7e0 [improvement](multi-catalog) push

[GitHub] [doris] morningman merged pull request #16388: [improvement](multi-catalog) push down all predicates into rowgroup/page filtering for ParquetReader

2023-02-06 Thread via GitHub
morningman merged PR #16388: URL: https://github.com/apache/doris/pull/16388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[doris] branch master updated: [fix](broker load) Fix hll_hash(null) in broker load report incorrect Exception (#16293)

2023-02-06 Thread caiconghui
This is an automated email from the ASF dual-hosted git repository. caiconghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 0b8c6315fb [fix](broker load) Fix hll_hash(nu

[GitHub] [doris] caiconghui merged pull request #16293: [Bug](broker load) fix hll_hash(null) in broker load report incorrect Exception

2023-02-06 Thread via GitHub
caiconghui merged PR #16293: URL: https://github.com/apache/doris/pull/16293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] caiconghui closed issue #16294: [Bug](broker load) hll_hash(null) report incorrect exception `label already used`

2023-02-06 Thread via GitHub
caiconghui closed issue #16294: [Bug](broker load) hll_hash(null) report incorrect exception `label already used` URL: https://github.com/apache/doris/issues/16294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [doris] liugs0213 opened a new issue, #16457: [Feature] Now support simple k8s deployment?

2023-02-06 Thread via GitHub
liugs0213 opened a new issue, #16457: URL: https://github.com/apache/doris/issues/16457 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description _No response_

[GitHub] [doris] BePPPower commented on a diff in pull request #16454: [Doc](Jdbc Catlog) JDBC Catalog support `Insert` operation

2023-02-06 Thread via GitHub
BePPPower commented on code in PR #16454: URL: https://github.com/apache/doris/pull/16454#discussion_r1098138211 ## docs/zh-CN/docs/lakehouse/multi-catalog/jdbc.md: ## @@ -164,6 +164,32 @@ JDBC Catalog 通过标准 JDBC 协议,连接其他数据源。 > > 3. Http > 地址。如:`https://doris-community-test-1

[GitHub] [doris] github-actions[bot] commented on pull request #16258: [feature](cooldown)Add cooldown delete

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16258: URL: https://github.com/apache/doris/pull/16258#issuecomment-1420147056 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #16382: [Feature](array-function) Support array functions for nested type datev2 and datetimev2

2023-02-06 Thread via GitHub
carlvinhust2012 commented on code in PR #16382: URL: https://github.com/apache/doris/pull/16382#discussion_r1098137325 ## fe/fe-common/src/main/java/org/apache/doris/common/Config.java: ## @@ -1717,7 +1717,7 @@ public class Config extends ConfigBase { * If set to TRUE, FE

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16258: [feature](cooldown)Add cooldown delete

2023-02-06 Thread via GitHub
github-actions[bot] commented on code in PR #16258: URL: https://github.com/apache/doris/pull/16258#discussion_r1098136797 ## be/src/olap/tablet.cpp: ## @@ -1661,10 +1670,107 @@ Status Tablet::cooldown() { } DCHECK(atol(dest_fs->id().c_str()) == storage_policy->resourc

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16402: [fix](hashjoin) join produce blocks with rows larger than batch size: handle join with other conjuncts

2023-02-06 Thread via GitHub
github-actions[bot] commented on code in PR #16402: URL: https://github.com/apache/doris/pull/16402#discussion_r1098133140 ## be/src/vec/exec/join/process_hash_table_probe_impl.h: ## @@ -766,6 +988,42 @@ Status ProcessHashTableProbe::do_process_with_other_join_conjuncts( }

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16258: [feature](cooldown)Add cooldown delete

2023-02-06 Thread via GitHub
github-actions[bot] commented on code in PR #16258: URL: https://github.com/apache/doris/pull/16258#discussion_r1098130695 ## be/src/olap/tablet.cpp: ## @@ -1752,6 +1861,8 @@ return Status::InternalError("version not continuous"); } TabletMetaPB tablet_meta_pb

[GitHub] [doris] zddr commented on a diff in pull request #16091: [feature](auth)Implementing privilege management with rbac model

2023-02-06 Thread via GitHub
zddr commented on code in PR #16091: URL: https://github.com/apache/doris/pull/16091#discussion_r1098130582 ## fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserManager.java: ## @@ -0,0 +1,342 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or m

[GitHub] [doris] zddr commented on a diff in pull request #16091: [feature](auth)Implementing privilege management with rbac model

2023-02-06 Thread via GitHub
zddr commented on code in PR #16091: URL: https://github.com/apache/doris/pull/16091#discussion_r1098129744 ## fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/RoleManager.java: ## @@ -40,19 +44,25 @@ import java.util.stream.Stream; public class RoleManager implemen

[GitHub] [doris] englefly opened a new pull request, #16456: [enhance](fuzzy)set rewriteOrToInPredicateThreshold=2/10000 in fuzzy mode

2023-02-06 Thread via GitHub
englefly opened a new pull request, #16456: URL: https://github.com/apache/doris/pull/16456 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Ye

[GitHub] [doris] zddr commented on a diff in pull request #16091: [feature](auth)Implementing privilege management with rbac model

2023-02-06 Thread via GitHub
zddr commented on code in PR #16091: URL: https://github.com/apache/doris/pull/16091#discussion_r1098123841 ## fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/PrivEntry.java: ## @@ -82,108 +112,7 @@ protected PrivEntry(PatternMatcher hostPattern, String origHost, Patt

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16258: [feature](cooldown)Add cooldown delete

2023-02-06 Thread via GitHub
github-actions[bot] commented on code in PR #16258: URL: https://github.com/apache/doris/pull/16258#discussion_r1098122073 ## be/src/olap/rowset/beta_rowset.cpp: ## @@ -88,7 +93,8 @@ std::string BetaRowset::remote_segment_path(int64_t tablet_id, const std::string& rowset_id,

[GitHub] [doris] nextdreamblue commented on a diff in pull request #16172: [fix-core](block) clear block row_same_bit when block reuse

2023-02-06 Thread via GitHub
nextdreamblue commented on code in PR #16172: URL: https://github.com/apache/doris/pull/16172#discussion_r1098119810 ## regression-test/suites/datev2/tpcds_sf1_p1/sql/row_same_bit.sql: ## @@ -0,0 +1,22 @@ +SELECT Review Comment: ok, i try some clear case, and add some commen

[GitHub] [doris] wangbo closed pull request #14287: [refactor] (vectorization)remove useless branch for semi-anti join

2023-02-06 Thread via GitHub
wangbo closed pull request #14287: [refactor] (vectorization)remove useless branch for semi-anti join URL: https://github.com/apache/doris/pull/14287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [doris] zddr commented on a diff in pull request #16091: [feature](auth)Implementing privilege management with rbac model

2023-02-06 Thread via GitHub
zddr commented on code in PR #16091: URL: https://github.com/apache/doris/pull/16091#discussion_r1098111817 ## fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/GlobalPrivEntry.java: ## @@ -18,144 +18,52 @@ package org.apache.doris.mysql.privilege; import org.apache.

[GitHub] [doris] caoliang-web closed pull request #15033: [regression](round)Add round and cast function tests in regression tests

2023-02-06 Thread via GitHub
caoliang-web closed pull request #15033: [regression](round)Add round and cast function tests in regression tests URL: https://github.com/apache/doris/pull/15033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [doris] carlvinhust2012 commented on pull request #16452: [typo](docs) Fix some errors in the description

2023-02-06 Thread via GitHub
carlvinhust2012 commented on PR #16452: URL: https://github.com/apache/doris/pull/16452#issuecomment-1420093068 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16258: [feature](cooldown)Add cooldown delete

2023-02-06 Thread via GitHub
github-actions[bot] commented on code in PR #16258: URL: https://github.com/apache/doris/pull/16258#discussion_r1098099725 ## be/src/olap/tablet.cpp: ## @@ -1627,7 +1635,7 @@ Status Tablet::create_rowset(RowsetMetaSharedPtr rowset_meta, RowsetSharedPtr* r return RowsetFact

[GitHub] [doris] github-actions[bot] commented on pull request #16388: [improvement](multi-catalog) push down all predicates into rowgroup/page filtering for ParquetReader

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16388: URL: https://github.com/apache/doris/pull/16388#issuecomment-1420058823 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16388: [improvement](multi-catalog) push down all predicates into rowgroup/page filtering for ParquetReader

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16388: URL: https://github.com/apache/doris/pull/16388#issuecomment-1420058907 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #16388: [improvement](multi-catalog) push down all predicates into rowgroup/page filtering for ParquetReader

2023-02-06 Thread via GitHub
github-actions[bot] commented on PR #16388: URL: https://github.com/apache/doris/pull/16388#issuecomment-1420057423 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] morningman commented on a diff in pull request #16091: [feature](auth)Implementing privilege management with rbac model

2023-02-06 Thread via GitHub
morningman commented on code in PR #16091: URL: https://github.com/apache/doris/pull/16091#discussion_r1098088468 ## fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Role.java: ## @@ -0,0 +1,584 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mo

[GitHub] [doris] dutyu commented on issue #16446: [WIP] Release Note 1.2.2

2023-02-06 Thread via GitHub
dutyu commented on issue #16446: URL: https://github.com/apache/doris/issues/16446#issuecomment-1420052310 > > https://doris.apache.org/docs/dev/sql-manual/sql-reference/Data-Manipulation-Statements/Manipulation/CANCEL-EXPORT > > It works in my env, have you tried to clean the cookie?

  1   2   >