github-actions[bot] commented on code in PR #16258:
URL: https://github.com/apache/doris/pull/16258#discussion_r1098130695
##########
be/src/olap/tablet.cpp:
##########
@@ -1752,6 +1861,8 @@
return Status::InternalError("version not continuous");
}
TabletMetaPB tablet_meta_pb;
+ tablet_meta_pb.mutable_cooldown_meta_id()->set_hi(_cooldown_meta_id.hi);
+ tablet_meta_pb.mutable_cooldown_meta_id()->set_lo(_cooldown_meta_id.lo);
Review Comment:
warning: use of undeclared identifier '_cooldown_meta_id'; did you mean
'cooldown_meta_id'? [clang-diagnostic-error]
```suggestion
->set_hi(cooldown_meta_id.hi);
```
**be/src/olap/tablet.cpp:1847:** 'cooldown_meta_id' declared here
```cpp
io::RemoteFileSystem>& dest_fs,
^
```
##########
be/src/olap/tablet.cpp:
##########
@@ -1698,9 +1804,10 @@ Status Tablet::_cooldown_data(const
std::shared_ptr<io::RemoteFileSystem>& dest_
new_rowset_meta->set_resource_id(dest_fs->id());
new_rowset_meta->set_fs(dest_fs);
new_rowset_meta->set_creation_time(time(nullptr));
+ TUniqueId cooldown_meta_id = generate_uuid();
// upload cooldowned rowset meta to remote fs
- RETURN_IF_ERROR(_write_cooldown_meta(dest_fs.get(),
new_rowset_meta.get()));
+ RETURN_IF_ERROR(_write_cooldown_meta(dest_fs.get(), cooldown_meta_id,
new_rowset_meta.get()));
Review Comment:
warning: reference to type 'const std::shared_ptr<io::RemoteFileSystem>'
could not bind to an rvalue of type
'std::__shared_ptr<doris::io::RemoteFileSystem,
__gnu_cxx::_S_atomic>::element_type *' (aka 'doris::io::RemoteFileSystem *')
[clang-diagnostic-error]
```cpp
downed rowset meta to remote fs
^
```
**be/src/common/status.h:497:** expanded from macro 'RETURN_IF_ERROR'
```cpp
Status _status_ = (stmt); \
^
```
**be/src/olap/tablet.h:411:** passing argument to parameter 'dest_fs' here
```cpp
Status _write_cooldown_meta(const std::shared_ptr<io::RemoteFileSystem>&
dest_fs,
^
```
##########
be/src/olap/tablet.cpp:
##########
@@ -1752,6 +1861,8 @@
return Status::InternalError("version not continuous");
}
TabletMetaPB tablet_meta_pb;
+ tablet_meta_pb.mutable_cooldown_meta_id()->set_hi(_cooldown_meta_id.hi);
+ tablet_meta_pb.mutable_cooldown_meta_id()->set_lo(_cooldown_meta_id.lo);
auto rs_metas = tablet_meta_pb.mutable_rs_metas();
Review Comment:
warning: use of undeclared identifier '_cooldown_meta_id'; did you mean
'cooldown_meta_id'? [clang-diagnostic-error]
```suggestion
->set_lo(cooldown_meta_id.lo);
```
**be/src/olap/tablet.cpp:1847:** 'cooldown_meta_id' declared here
```cpp
io::RemoteFileSystem>& dest_fs,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
