github-actions[bot] commented on code in PR #16258:
URL: https://github.com/apache/doris/pull/16258#discussion_r1098122073
##########
be/src/olap/rowset/beta_rowset.cpp:
##########
@@ -88,7 +93,8 @@
std::string BetaRowset::remote_segment_path(int64_t tablet_id, const
std::string& rowset_id,
int segment_id) {
// data/{tablet_id}/{rowset_id}_{seg_num}.dat
- return fmt::format("{}/{}_{}.dat", remote_tablet_path(tablet_id),
rowset_id, segment_id);
+ return fmt::format("{}/{}", remote_tablet_path(tablet_id),
+ segment_file_name(rowset_id, segment_id));
Review Comment:
warning: too few arguments to function call, expected 3, have 2
[clang-diagnostic-error]
```cpp
segment_file_name(rowset_id, segment_id));
^
```
**be/src/olap/rowset/beta_rowset.h:57:** 'segment_file_name' declared here
```cpp
static std::string segment_file_name(int64_t tablet_id, const
std::string& rowset_id,
^
```
##########
be/src/olap/tablet.cpp:
##########
@@ -1752,6 +1861,8 @@ Status Tablet::_write_cooldown_meta(io::RemoteFileSystem*
fs, RowsetMeta* new_rs
return Status::InternalError("version not continuous");
}
TabletMetaPB tablet_meta_pb;
+ tablet_meta_pb.mutable_cooldown_meta_id()->set_hi(_cooldown_meta_id.hi);
+ tablet_meta_pb.mutable_cooldown_meta_id()->set_lo(_cooldown_meta_id.lo);
Review Comment:
warning: use of undeclared identifier '_cooldown_meta_id'; did you mean
'cooldown_meta_id'? [clang-diagnostic-error]
```suggestion
->set_hi(cooldown_meta_id.hi);
```
**be/src/olap/tablet.cpp:1847:** 'cooldown_meta_id' declared here
```cpp
st TUniqueId& cooldown_meta_id,
^
```
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -501,11 +501,17 @@ void TabletMeta::init_from_pb(const TabletMetaPB&
tablet_meta_pb) {
// init _schema
_schema->init_from_pb(tablet_meta_pb.schema());
+ _cooldowned_version = -1;
// init _rs_metas
for (auto& it : tablet_meta_pb.rs_metas()) {
RowsetMetaSharedPtr rs_meta(new RowsetMeta());
rs_meta->init_from_pb(it);
_rs_metas.push_back(std::move(rs_meta));
+ if (_tablet_meta->storage_policy_id() > 0 &&
Review Comment:
warning: use of undeclared identifier '_tablet_meta'; did you mean
'tablet_meta_pb'? [clang-diagnostic-error]
```suggestion
if (tablet_meta_pb->storage_policy_id() > 0 &&
```
**be/src/olap/tablet_meta.cpp:462:** 'tablet_meta_pb' declared here
```cpp
void TabletMeta::init_from_pb(const TabletMetaPB& tablet_meta_pb) {
^
```
##########
be/src/olap/tablet.cpp:
##########
@@ -1752,6 +1861,8 @@
return Status::InternalError("version not continuous");
}
TabletMetaPB tablet_meta_pb;
+ tablet_meta_pb.mutable_cooldown_meta_id()->set_hi(_cooldown_meta_id.hi);
+ tablet_meta_pb.mutable_cooldown_meta_id()->set_lo(_cooldown_meta_id.lo);
auto rs_metas = tablet_meta_pb.mutable_rs_metas();
Review Comment:
warning: use of undeclared identifier '_cooldown_meta_id'; did you mean
'cooldown_meta_id'? [clang-diagnostic-error]
```suggestion
->set_lo(cooldown_meta_id.lo);
```
**be/src/olap/tablet.cpp:1847:** 'cooldown_meta_id' declared here
```cpp
st TUniqueId& cooldown_meta_id,
^
```
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -501,11 +501,17 @@
// init _schema
_schema->init_from_pb(tablet_meta_pb.schema());
+ _cooldowned_version = -1;
// init _rs_metas
for (auto& it : tablet_meta_pb.rs_metas()) {
RowsetMetaSharedPtr rs_meta(new RowsetMeta());
rs_meta->init_from_pb(it);
_rs_metas.push_back(std::move(rs_meta));
+ if (_tablet_meta->storage_policy_id() > 0 &&
Review Comment:
warning: member reference type 'const doris::TabletMetaPB' is not a pointer;
did you mean to use '.'? [clang-diagnostic-error]
```suggestion
if (_tablet_meta.storage_policy_id() > 0 &&
```
##########
be/src/olap/rowset/beta_rowset.cpp:
##########
@@ -79,6 +79,11 @@ std::string BetaRowset::remote_tablet_meta_path(int64_t
tablet_id, int64_t repli
return fmt::format("{}/{}.meta", remote_tablet_path(tablet_id),
replica_id);
}
+std::string BetaRowset::segment_file_name(const std::string& rowset_id, int
segment_id) {
Review Comment:
warning: out-of-line definition of 'segment_file_name' does not match any
declaration in 'doris::BetaRowset' [clang-diagnostic-error]
```cpp
std::string BetaRowset::segment_file_name(const std::string& rowset_id, int
segment_id) {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
