[GitHub] [incubator-doris] vagetablechicken commented on pull request #4118: [Bug] fix use-after-poison bug in ut schema_change_test

2020-07-20 Thread GitBox
vagetablechicken commented on pull request #4118: URL: https://github.com/apache/incubator-doris/pull/4118#issuecomment-661669648 > > > You can simplify the commit message to easy understand. > > > > > > How about this commit message? > > You should make another to know wha

[GitHub] [incubator-doris] morningman opened a new pull request #4125: [Bug][Load][Json] #4124 Load json format with stream load failed

2020-07-20 Thread GitBox
morningman opened a new pull request #4125: URL: https://github.com/apache/incubator-doris/pull/4125 ## Proposed changes Stream load should read all the data completely before parsing the json. And also add a new BE config `streaming_load_max_batch_read_mb` to limit the data siz

[GitHub] [incubator-doris] morningman opened a new issue #4124: [Bug][Load][Json] Load json format with stream load failed

2020-07-20 Thread GitBox
morningman opened a new issue #4124: URL: https://github.com/apache/incubator-doris/issues/4124 **Describe the bug** if the json data is larger than 4096 bytes, the data will be truncated, making it impossible to obtain the json data completely **To Reproduce** Load a large jso

[GitHub] [incubator-doris] chaoyli commented on pull request #4118: [Bug] fix use-after-poison bug in ut schema_change_test

2020-07-20 Thread GitBox
chaoyli commented on pull request #4118: URL: https://github.com/apache/incubator-doris/pull/4118#issuecomment-661661928 > > You can simplify the commit message to easy understand. > > How about this commit message? You should make another to know what the commit's addressing p

[GitHub] [incubator-doris] xy720 edited a comment on issue #4101: [Proposal]Create a repository for SparkLoad‘s dependencies

2020-07-20 Thread GitBox
xy720 edited a comment on issue #4101: URL: https://github.com/apache/incubator-doris/issues/4101#issuecomment-661636359 **The repository structure** will be like this: ``` __spark_repository__/ |-__archive_1_0_0/ ||-__lib_990325d2c0d1d5e45bf675e54e44fb16_spa

[GitHub] [incubator-doris] xy720 edited a comment on issue #4101: [Proposal]Create a repository for SparkLoad‘s dependencies

2020-07-20 Thread GitBox
xy720 edited a comment on issue #4101: URL: https://github.com/apache/incubator-doris/issues/4101#issuecomment-661636359 **The repository structure** will be like this: ``` __spark_repository__/ |-__archive_1_0_0/ ||-__lib_990325d2c0d1d5e45bf675e54e44fb16_spa

[GitHub] [incubator-doris] xy720 edited a comment on issue #4101: [Proposal]Create a repository for SparkLoad‘s dependencies

2020-07-20 Thread GitBox
xy720 edited a comment on issue #4101: URL: https://github.com/apache/incubator-doris/issues/4101#issuecomment-661630805 1、I am not going to remove the old version yet,because it's not a big problem for now. 2、At present, I plan to save a DppVersion in FeConstant, fe will try to find o

[GitHub] [incubator-doris] xy720 edited a comment on issue #4101: [Proposal]Create a repository for SparkLoad‘s dependencies

2020-07-20 Thread GitBox
xy720 edited a comment on issue #4101: URL: https://github.com/apache/incubator-doris/issues/4101#issuecomment-661630805 1、I am not going to remove the old version yet,because it's not a big problem for now. 2、At present, I plan to save a DppVersion in FeConstant, fe will try to find o

[GitHub] [incubator-doris] xy720 edited a comment on issue #4101: [Proposal]Create a repository for SparkLoad‘s dependencies

2020-07-20 Thread GitBox
xy720 edited a comment on issue #4101: URL: https://github.com/apache/incubator-doris/issues/4101#issuecomment-661636359 **The repository structure** will be like this: ``` __spark_repository__/ |-__archive_1_0_0/ ||-__lib_990325d2c0d1d5e45bf675e54e44fb16_spa

[GitHub] [incubator-doris] xy720 commented on issue #4101: [Proposal]Create a repository for SparkLoad‘s dependencies

2020-07-20 Thread GitBox
xy720 commented on issue #4101: URL: https://github.com/apache/incubator-doris/issues/4101#issuecomment-661636359 **The repository structure** will be like this: __spark_repository__/ |-__archive_1_0_0/ ||-__lib_990325d2c0d1d5e45bf675e54e44fb16_spark-dpp.zip

[GitHub] [incubator-doris] xy720 edited a comment on issue #4101: [Proposal]Create a repository for SparkLoad‘s dependencies

2020-07-20 Thread GitBox
xy720 edited a comment on issue #4101: URL: https://github.com/apache/incubator-doris/issues/4101#issuecomment-661630805 1、I am not going to remove the old version yet,because it's not a big problem for now. 2、At present, I plan to save a DppVersion in FeConstant, fe will try to find o

[GitHub] [incubator-doris] xy720 commented on issue #4101: [Proposal]Create a repository for SparkLoad‘s dependencies

2020-07-20 Thread GitBox
xy720 commented on issue #4101: URL: https://github.com/apache/incubator-doris/issues/4101#issuecomment-661630805 1、I am not going to remove the old version yet,because it's not a big problem for now. 2、At present, I plan to save a DppVersion in FeConstant, fe will try to find or creat

[GitHub] [incubator-doris] morningman merged pull request #4099: [CodeRefactor] #4098 Make FE multi module

2020-07-20 Thread GitBox
morningman merged pull request #4099: URL: https://github.com/apache/incubator-doris/pull/4099 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #4110: [Feature][ThreadPool]Add Web Page to display thread's stats

2020-07-20 Thread GitBox
WingsGo commented on a change in pull request #4110: URL: https://github.com/apache/incubator-doris/pull/4110#discussion_r457829956 ## File path: be/src/util/thread.cpp ## @@ -397,8 +477,15 @@ Status ThreadJoiner::join() { } waited_ms += wait_for; } -

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #4110: [Feature][ThreadPool]Add Web Page to display thread's stats

2020-07-20 Thread GitBox
WingsGo commented on a change in pull request #4110: URL: https://github.com/apache/incubator-doris/pull/4110#discussion_r457821922 ## File path: be/src/util/thread.cpp ## @@ -74,18 +78,17 @@ class ThreadMgr { // already been removed, this is a no-op. void remove_thre

[GitHub] [incubator-doris] vagetablechicken commented on pull request #4118: [Bug] fix use-after-poison bug in ut schema_change_test

2020-07-20 Thread GitBox
vagetablechicken commented on pull request #4118: URL: https://github.com/apache/incubator-doris/pull/4118#issuecomment-661573386 > You can simplify the commit message to easy understand. How about this commit message?

[GitHub] [incubator-doris] yangzhg opened a new pull request #4123: fix boolean support

2020-07-20 Thread GitBox
yangzhg opened a new pull request #4123: URL: https://github.com/apache/incubator-doris/pull/4123 ## Proposed changes Fixes the bug describeed in #4122: * add type check when add bloom filter index * support add boolean column ## Types of changes What types of cha

[GitHub] [incubator-doris] yangzhg opened a new issue #4122: [BUG] Boolean support not incomplete

2020-07-20 Thread GitBox
yangzhg opened a new issue #4122: URL: https://github.com/apache/incubator-doris/issues/4122 **Describe the bug** support create bloom filter index in boolean colunm incorrectly **To Reproduce** `CREATE TABLE create_table_wrong_3_tb ( k1 BOOLEAN NOT NULL, k2 INT NOT NULL, v1 BO

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #4110: [Feature][ThreadPool]Add Web Page to display thread's stats

2020-07-20 Thread GitBox
chaoyli commented on a change in pull request #4110: URL: https://github.com/apache/incubator-doris/pull/4110#discussion_r457803906 ## File path: be/src/env/env.h ## @@ -271,13 +260,10 @@ class RandomAccessFile { // one of Append or PositionedAppend. We support only Append her

[GitHub] [incubator-doris] vagetablechicken commented on pull request #4068: [Compaction] track RowsetReader's mem & add metric

2020-07-20 Thread GitBox
vagetablechicken commented on pull request #4068: URL: https://github.com/apache/incubator-doris/pull/4068#issuecomment-661597974 > Hi @vagetablechicken , Plz add this new metrics to the document `be-metrics.md`, Thank you Finished. -

[GitHub] [incubator-doris] chaoyli commented on issue #3930: [Proposal] Doris support version column for REPLACE aggregate type

2020-07-20 Thread GitBox
chaoyli commented on issue #3930: URL: https://github.com/apache/incubator-doris/issues/3930#issuecomment-661576076 How about discuss it using WeChat. It may be efficient. My WeChat : 15652918147 This is an automated mess

[GitHub] [incubator-doris] liutang123 edited a comment on issue #4104: No available BE to choose when repair

2020-07-20 Thread GitBox
liutang123 edited a comment on issue #4104: URL: https://github.com/apache/incubator-doris/issues/4104#issuecomment-661555852 > > There are A, B, C and D 4 BEs. > > tablet t has 3 replicas in A(good), B(good) and C(version miss). > > If now mark D as decommissioned. FE will never dele

[GitHub] [incubator-doris] liutang123 edited a comment on issue #4104: No available BE to choose when repair

2020-07-20 Thread GitBox
liutang123 edited a comment on issue #4104: URL: https://github.com/apache/incubator-doris/issues/4104#issuecomment-661555852 > > There are A, B, C and D 4 BEs. > > tablet t has 3 replicas in A(good), B(good) and C(version miss). > > If now mark D as decommissioned. FE will never dele

[GitHub] [incubator-doris] liutang123 commented on issue #4104: No available BE to choose when repair

2020-07-20 Thread GitBox
liutang123 commented on issue #4104: URL: https://github.com/apache/incubator-doris/issues/4104#issuecomment-661555852 > > There are A, B, C and D 4 BEs. > > tablet t has 3 replicas in A(good), B(good) and C(version miss). > > If now mark D as decommissioned. FE will never delete repl

[GitHub] [incubator-doris] liutang123 edited a comment on issue #4104: No available BE to choose when repair

2020-07-20 Thread GitBox
liutang123 edited a comment on issue #4104: URL: https://github.com/apache/incubator-doris/issues/4104#issuecomment-661555852 > > There are A, B, C and D 4 BEs. > > tablet t has 3 replicas in A(good), B(good) and C(version miss). > > If now mark D as decommissioned. FE will never dele

[GitHub] [incubator-doris] morningman commented on issue #4104: No available BE to choose when repair

2020-07-20 Thread GitBox
morningman commented on issue #4104: URL: https://github.com/apache/incubator-doris/issues/4104#issuecomment-661081118 > There are A, B, C and D 4 BEs. > tablet t has 3 replicas in A(good), B(good) and C(version miss). > If now mark D as decommissioned. FE will never delete replica in

[GitHub] [incubator-doris] morningman edited a comment on issue #4104: No available BE to choose when repair

2020-07-20 Thread GitBox
morningman edited a comment on issue #4104: URL: https://github.com/apache/incubator-doris/issues/4104#issuecomment-661081118 > There are A, B, C and D 4 BEs. > tablet t has 3 replicas in A(good), B(good) and C(version miss). > If now mark D as decommissioned. FE will never delete rep

[GitHub] [incubator-doris] morningman closed pull request #4108: Remove unused session variables

2020-07-20 Thread GitBox
morningman closed pull request #4108: URL: https://github.com/apache/incubator-doris/pull/4108 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] morningman commented on pull request #4108: Remove unused session variables

2020-07-20 Thread GitBox
morningman commented on pull request #4108: URL: https://github.com/apache/incubator-doris/pull/4108#issuecomment-661069749 Should not remove. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-doris] Youngwb commented on issue #3930: [Proposal] Doris support version column for REPLACE aggregate type

2020-07-20 Thread GitBox
Youngwb commented on issue #3930: URL: https://github.com/apache/incubator-doris/issues/3930#issuecomment-660995010 > I see it. You want to replace the recored according to the the version specified by user's application. > If we add a replace property in load command, can we use it to

[GitHub] [incubator-doris] chaoyli commented on issue #3930: [Proposal] Doris support version column for REPLACE aggregate type

2020-07-20 Thread GitBox
chaoyli commented on issue #3930: URL: https://github.com/apache/incubator-doris/issues/3930#issuecomment-660950736 I see it. You want to replace the recored according to the the version specified by user's application. If we add a replace property in load command, can we use it to do r

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #4110: [Feature][ThreadPool]Add Web Page to display thread's stats

2020-07-20 Thread GitBox
WingsGo commented on a change in pull request #4110: URL: https://github.com/apache/incubator-doris/pull/4110#discussion_r457225286 ## File path: be/src/util/url_coding.cpp ## @@ -122,59 +122,47 @@ static void encode_base64_internal(const std::string& in, std::string* out,

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #4110: [Feature][ThreadPool]Add Web Page to display thread's stats

2020-07-20 Thread GitBox
WingsGo commented on a change in pull request #4110: URL: https://github.com/apache/incubator-doris/pull/4110#discussion_r457223557 ## File path: be/src/util/thread.cpp ## @@ -169,6 +174,81 @@ void ThreadMgr::remove_thread(const pthread_t& pthread_id, const std::string& ca

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #4110: [Feature][ThreadPool]Add Web Page to display thread's stats

2020-07-20 Thread GitBox
WingsGo commented on a change in pull request #4110: URL: https://github.com/apache/incubator-doris/pull/4110#discussion_r457221304 ## File path: be/src/util/thread.cpp ## @@ -169,6 +174,81 @@ void ThreadMgr::remove_thread(const pthread_t& pthread_id, const std::string& ca

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #4110: [Feature][ThreadPool]Add Web Page to display thread's stats

2020-07-20 Thread GitBox
WingsGo commented on a change in pull request #4110: URL: https://github.com/apache/incubator-doris/pull/4110#discussion_r457220064 ## File path: be/src/http/default_path_handlers.h ## @@ -20,6 +20,8 @@ #include +#include "util/thread.h" Review comment: I remove i

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #4110: [Feature][ThreadPool]Add Web Page to display thread's stats

2020-07-20 Thread GitBox
WingsGo commented on a change in pull request #4110: URL: https://github.com/apache/incubator-doris/pull/4110#discussion_r457219681 ## File path: be/src/util/thread.cpp ## @@ -74,18 +78,17 @@ class ThreadMgr { // already been removed, this is a no-op. void remove_thre

[GitHub] [incubator-doris] morningman closed issue #3344: [Proposal] Materialized View 2.0

2020-07-20 Thread GitBox
morningman closed issue #3344: URL: https://github.com/apache/incubator-doris/issues/3344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-doris] branch master updated (fbf7bd6 -> 2de4f24)

2020-07-20 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from fbf7bd6 [Bug] Change get load state interface (#4081) add 2de4f24 [MV] Add framework of mv select

[GitHub] [incubator-doris] morningman merged pull request #4014: Add framework of mv selector

2020-07-20 Thread GitBox
morningman merged pull request #4014: URL: https://github.com/apache/incubator-doris/pull/4014 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] chaoyli commented on pull request #4118: [Bug] fix use-after-poison bug in ut schema_change_test

2020-07-20 Thread GitBox
chaoyli commented on pull request #4118: URL: https://github.com/apache/incubator-doris/pull/4118#issuecomment-660911743 You can simplify the commit message to easy understand. This is an automated message from the Apache Git

[GitHub] [incubator-doris] vagetablechicken opened a new issue #4121: [UT] TestTimestampedVersionTracker assumes the local tz is UTC+8

2020-07-20 Thread GitBox
vagetablechicken opened a new issue #4121: URL: https://github.com/apache/incubator-doris/issues/4121 **Describe the bug** `TimestampedVersionTracker::get_stale_version_path_json_doc()` will return time string by using the local time. We just assume that the local time zone is utc+8,

[GitHub] [incubator-doris] chaoyli opened a new issue #4120: [Enhancement] Add HTTP RestFul interface to get QueryPlan by QueryID

2020-07-20 Thread GitBox
chaoyli opened a new issue #4120: URL: https://github.com/apache/incubator-doris/issues/4120 1. Doris is lack of get QueryPlan by QueryID, so I add it. 2. Insert is not be taken into consideration when been profiled. So we lack of profile for insert query.

[GitHub] [incubator-doris] vagetablechicken commented on issue #4113: 源码编译报错

2020-07-20 Thread GitBox
vagetablechicken commented on issue #4113: URL: https://github.com/apache/incubator-doris/issues/4113#issuecomment-660902383 ``` /opt/apache-doris/apache-doris-0.12.0/be/src/common/logconfig.cpp:68:5: error: ‘FLAGS_log_filenum_quota’ was not declared in this scope ``` So you'd bet

[GitHub] [incubator-doris] chaoyli opened a new pull request #4119: [Enhancement] Add HTTP RestFul interface to get QueryPlan by QueryID

2020-07-20 Thread GitBox
chaoyli opened a new pull request #4119: URL: https://github.com/apache/incubator-doris/pull/4119 1. Doris is lack of get QueryPlan by QueryID, so I add it. 2. Insert is not be taken into consideration when been profiled. Now I add it into QueryDetailQueue to be collected. ---

[GitHub] [incubator-doris] vagetablechicken opened a new pull request #4118: [Bug] fix use-after-poison bug in ut schema_change_test

2020-07-20 Thread GitBox
vagetablechicken opened a new pull request #4118: URL: https://github.com/apache/incubator-doris/pull/4118 ## Proposed changes https://github.com/apache/incubator-doris/issues/4116 ## Types of changes What types of changes does your code introduce to Doris? _Put an `x

[incubator-doris] branch master updated: [Bug] Change get load state interface (#4081)

2020-07-20 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new fbf7bd6 [Bug] Change get load stat

[GitHub] [incubator-doris] chaoyli closed issue #4082: [Bug] PathTrie match error

2020-07-20 Thread GitBox
chaoyli closed issue #4082: URL: https://github.com/apache/incubator-doris/issues/4082 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-doris] chaoyli merged pull request #4081: [Bug] Change get load state interface

2020-07-20 Thread GitBox
chaoyli merged pull request #4081: URL: https://github.com/apache/incubator-doris/pull/4081 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t