liutang123 commented on issue #4104: URL: https://github.com/apache/incubator-doris/issues/4104#issuecomment-661555852
> > There are A, B, C and D 4 BEs. > > tablet t has 3 replicas in A(good), B(good) and C(version miss). > > If now mark D as decommissioned. FE will never delete replica in C and can not choose D to create new replica. > > I think this case will fall into this branch: > > https://github.com/apache/incubator-doris/blob/2de4f2471bd729e9f723ca8cdd5d9abfe69bf8eb/fe/src/main/java/org/apache/doris/catalog/Tablet.java#L476-L478 > > So it can not run to the code you modified in #4105 Sorry, I skip a step. Think about follows: There are A, B, C and D 4 BEs. tablet t has 3 replicas in A(good), B(good) and C(version miss). Choose D to create new replica, A(good), B(good) and C(version miss), D(good). Now, `aliveAndVersionComplete` is equal to `replicationNum`. If decommission D before delete replica in C, repair will hang. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
