[GitHub] [incubator-doris] WingsGo commented on a change in pull request #4110: [Feature][ThreadPool]Add Web Page to display thread's stats

[GitBox]

WingsGo commented on a change in pull request #4110:
URL: https://github.com/apache/incubator-doris/pull/4110#discussion_r457821922



##########
File path: be/src/util/thread.cpp
##########
@@ -74,18 +78,17 @@ class ThreadMgr {
     // already been removed, this is a no-op.
     void remove_thread(const pthread_t& pthread_id, const std::string& 
category);
 
-private:
+    void display_thread_callback(const WebPageHandler::ArgumentMap& args, 
EasyJson* ej) const;

Review comment:
       easy_json is imported in line 38.

##########
File path: be/src/env/env_util.h
##########
@@ -30,14 +31,21 @@ struct WritableFileOptions;
 
 namespace env_util {
 
-Status open_file_for_write(Env *env, const std::string& path, 
std::shared_ptr<WritableFile> *file);
+Status open_file_for_write(Env* env, const std::string& path, 
std::shared_ptr<WritableFile>* file);
 
-Status open_file_for_write(const WritableFileOptions& opts, Env *env,
-                           const std::string& path, 
std::shared_ptr<WritableFile> *file);
+Status open_file_for_write(const WritableFileOptions& opts, Env* env, const 
std::string& path,
+                           std::shared_ptr<WritableFile>* file);
 
-Status open_file_for_random(Env *env, const std::string& path,
-                            std::shared_ptr<RandomAccessFile> *file);
+Status open_file_for_random(Env* env, const std::string& path,
+                            std::shared_ptr<RandomAccessFile>* file);
+
+// A utility routine: write "data" to the named file.
+extern Status write_string_to_file(Env* env, const Slice& data, const 
std::string& fname);
+// Like above but also fsyncs the new file.
+extern Status write_string_to_file_sync(Env* env, const Slice& data, const 
std::string& fname);

Review comment:
       done

##########
File path: be/src/env/env.h
##########
@@ -35,15 +35,10 @@ class Env {
     // CREATE_OR_OPEN               | opens             | creates
     // MUST_CREATE                  | fails             | creates
     // MUST_EXIST                   | opens             | fails
-    enum OpenMode {
-        CREATE_OR_OPEN_WITH_TRUNCATE,
-        CREATE_OR_OPEN,
-        MUST_CREATE,
-        MUST_EXIST
-    };
+    enum OpenMode { CREATE_OR_OPEN_WITH_TRUNCATE, CREATE_OR_OPEN, MUST_CREATE, 
MUST_EXIST };

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org