[GitHub] [incubator-doris] liutang123 commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-11 Thread GitBox
liutang123 commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294#discussion_r407078047 ## File path: be/src/olap/tablet_manager.cpp ## @@ -960,28 +960,

[GitHub] [incubator-doris] wuyunfeng commented on issue #3306: [Doris On Elasticsearch] 2020 Develop Roadmap

2020-04-11 Thread GitBox
wuyunfeng commented on issue #3306: [Doris On Elasticsearch] 2020 Develop Roadmap URL: https://github.com/apache/incubator-doris/issues/3306#issuecomment-612444094 @stalary OK This is an automated message from the Apache Git

[GitHub] [incubator-doris] stalary commented on issue #3306: [Doris On Elasticsearch] 2020 Develop Roadmap

2020-04-11 Thread GitBox
stalary commented on issue #3306: [Doris On Elasticsearch] 2020 Develop Roadmap URL: https://github.com/apache/incubator-doris/issues/3306#issuecomment-612443072 `index mapping和shard location的检测分成两个阶段` 这个我来搞下 This is an au

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-11 Thread GitBox
kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407070222 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/SparkDpp.java ## @@ -0,0 +1,84

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-11 Thread GitBox
kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407071305 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/SparkDpp.java ## @@ -0,0 +1,84

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-11 Thread GitBox
kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407068924 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/DppColumns.java ## @@ -0,0 +1,

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-11 Thread GitBox
kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407071143 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/SparkDpp.java ## @@ -0,0 +1,84

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-11 Thread GitBox
kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407069586 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/MinimalCoverRollupTreeBuilder.java ###

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-11 Thread GitBox
kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407069068 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/DppColumns.java ## @@ -0,0 +1,

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-11 Thread GitBox
kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407069506 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/DppUtils.java ## @@ -0,0 +1,23

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-11 Thread GitBox
kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407069192 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/DppColumns.java ## @@ -0,0 +1,

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-11 Thread GitBox
kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407070343 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/SparkDpp.java ## @@ -0,0 +1,84

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295

2020-04-11 Thread GitBox
kangkaisen commented on a change in pull request #3296: spark data preparation process, issue #3295 URL: https://github.com/apache/incubator-doris/pull/3296#discussion_r407068566 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/dpp/BitmapUnion.java ## @@ -0,0 +1

[GitHub] [incubator-doris] morningman commented on a change in pull request #3191: DeleteV2

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r407065963 ## File path: fe/src/main/java/org/apache/doris/task/DeleteJob.java ## @@ -0,0 +1,170 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] morningman commented on a change in pull request #3191: DeleteV2

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r407066340 ## File path: fe/src/main/java/org/apache/doris/task/DeleteJob.java ## @@ -0,0 +1,170 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] morningman commented on a change in pull request #3191: DeleteV2

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r407065902 ## File path: fe/src/main/java/org/apache/doris/task/DeleteJob.java ## @@ -0,0 +1,170 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] morningman commented on a change in pull request #3191: DeleteV2

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r407067181 ## File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java ## @@ -0,0 +1,549 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] morningman commented on a change in pull request #3191: DeleteV2

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r407067834 ## File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java ## @@ -0,0 +1,549 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] morningman commented on a change in pull request #3191: DeleteV2

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r407066403 ## File path: fe/src/main/java/org/apache/doris/task/DeleteJob.java ## @@ -0,0 +1,170 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] morningman commented on a change in pull request #3191: DeleteV2

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r407065663 ## File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java ## @@ -0,0 +1,549 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] morningman commented on a change in pull request #3191: DeleteV2

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r407067217 ## File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java ## @@ -0,0 +1,549 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] morningman commented on a change in pull request #3191: DeleteV2

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r407065509 ## File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java ## @@ -0,0 +1,549 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] kangkaisen closed issue #3290: Multi subquery does not supported in having clause

2020-04-11 Thread GitBox
kangkaisen closed issue #3290: Multi subquery does not supported in having clause URL: https://github.com/apache/incubator-doris/issues/3290 This is an automated message from the Apache Git Service. To respond to the message

[incubator-doris] branch master updated (5b69c70 -> 7c07083)

2020-04-11 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 5b69c70 [Bug] Fix bug that user plugin dir is removed after installing the plugin (#3302) add 7c0

[GitHub] [incubator-doris] kangkaisen merged pull request #3291: Forbidden multi subquery in having clause

2020-04-11 Thread GitBox
kangkaisen merged pull request #3291: Forbidden multi subquery in having clause URL: https://github.com/apache/incubator-doris/pull/3291 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3305: Add field context for string field keyword type

2020-04-11 Thread GitBox
kangkaisen commented on a change in pull request #3305: Add field context for string field keyword type URL: https://github.com/apache/incubator-doris/pull/3305#discussion_r407066649 ## File path: be/src/exec/es/es_predicate.cpp ## @@ -298,8 +302,12 @@ Status EsPredicate::

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3305: Add field context for string field keyword type

2020-04-11 Thread GitBox
kangkaisen commented on a change in pull request #3305: Add field context for string field keyword type URL: https://github.com/apache/incubator-doris/pull/3305#discussion_r407066649 ## File path: be/src/exec/es/es_predicate.cpp ## @@ -298,8 +302,12 @@ Status EsPredicate::

[GitHub] [incubator-doris] morningman commented on a change in pull request #3283: Support setting replica quota in db level

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3283: Support setting replica quota in db level URL: https://github.com/apache/incubator-doris/pull/3283#discussion_r407063056 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -714,9 +714,9 @@ alter_stmt ::= {:

[GitHub] [incubator-doris] morningman commented on issue #3305: Add field context for string field keyword type

2020-04-11 Thread GitBox
morningman commented on issue #3305: Add field context for string field keyword type URL: https://github.com/apache/incubator-doris/pull/3305#issuecomment-612418725 > #3304 > > 这个方案其实是一个过度的解决方案,最佳的解决方案应该是将对EsScanNode的谓词转换在FE中完成,BE只负责扫描,这样将对查询的处理和执行完全分开。 > > 建表时增加一个 `enable_ke

[GitHub] [incubator-doris] morningman commented on a change in pull request #3305: Add field context for string field keyword type

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3305: Add field context for string field keyword type URL: https://github.com/apache/incubator-doris/pull/3305#discussion_r407062599 ## File path: be/src/exec/es/es_predicate.h ## @@ -198,6 +198,10 @@ class EsPredicate {

[GitHub] [incubator-doris] morningman commented on a change in pull request #3305: Add field context for string field keyword type

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3305: Add field context for string field keyword type URL: https://github.com/apache/incubator-doris/pull/3305#discussion_r407062113 ## File path: be/src/exec/es/es_predicate.h ## @@ -198,6 +198,10 @@ class EsPredicate {

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down.

2020-04-11 Thread GitBox
WingsGo commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down. URL: https://github.com/apache/incubator-doris/pull/3293#discussion_r407061906 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java #

[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down.

2020-04-11 Thread GitBox
WingsGo commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down. URL: https://github.com/apache/incubator-doris/pull/3293#discussion_r407061859 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java #

[GitHub] [incubator-doris] morningman commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3294: Use read lock when iterate tablet_map in TabletManager::start_trash_sweep URL: https://github.com/apache/incubator-doris/pull/3294#discussion_r407061670 ## File path: be/src/olap/tablet_manager.cpp ## @@ -960,28 +960,

[GitHub] [incubator-doris] morningman commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down.

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down. URL: https://github.com/apache/incubator-doris/pull/3293#discussion_r407059051 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ##

[GitHub] [incubator-doris] morningman commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down.

2020-04-11 Thread GitBox
morningman commented on a change in pull request #3293: [Transaction]Cancel all txns whose coordinate be is down. URL: https://github.com/apache/incubator-doris/pull/3293#discussion_r407060372 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ##

[incubator-doris] branch master updated: [Bug] Fix bug that user plugin dir is removed after installing the plugin (#3302)

2020-04-11 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 5b69c70 [Bug] Fix bug that user pl

[GitHub] [incubator-doris] morningman merged pull request #3302: [Bug] Fix bug that user plugin dir is removed after installing the plugin

2020-04-11 Thread GitBox
morningman merged pull request #3302: [Bug] Fix bug that user plugin dir is removed after installing the plugin URL: https://github.com/apache/incubator-doris/pull/3302 This is an automated message from the Apache Git Servic

[GitHub] [incubator-doris] blackfox1983 commented on issue #3306: [Doris On Elasticsearch] 2020 Develop Roadmap

2020-04-11 Thread GitBox
blackfox1983 commented on issue #3306: [Doris On Elasticsearch] 2020 Develop Roadmap URL: https://github.com/apache/incubator-doris/issues/3306#issuecomment-612393825 简直就是业务线同学福音! 非常期待这些feature的上线。也希望有机会一起开发。 This is

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #3305: Add field context for string field keyword type

2020-04-11 Thread GitBox
wuyunfeng commented on a change in pull request #3305: Add field context for string field keyword type URL: https://github.com/apache/incubator-doris/pull/3305#discussion_r407048747 ## File path: fe/src/main/java/org/apache/doris/planner/EsScanNode.java ## @@ -123,6 +123,9

[GitHub] [incubator-doris] wuyunfeng commented on issue #3306: [Doris On ES] 2020 Develop Roadmap

2020-04-11 Thread GitBox
wuyunfeng commented on issue #3306: [Doris On ES] 2020 Develop Roadmap URL: https://github.com/apache/incubator-doris/issues/3306#issuecomment-612390154 https://github.com/apache/incubator-doris/issues/3249 This is an automat

[GitHub] [incubator-doris] stalary commented on a change in pull request #3305: Add field context for string field keyword type

2020-04-11 Thread GitBox
stalary commented on a change in pull request #3305: Add field context for string field keyword type URL: https://github.com/apache/incubator-doris/pull/3305#discussion_r407048050 ## File path: fe/src/main/java/org/apache/doris/planner/EsScanNode.java ## @@ -123,6 +123,9 @

[GitHub] [incubator-doris] wuyunfeng opened a new issue #3306: [Doris On ES] 2020 roadmap

2020-04-11 Thread GitBox
wuyunfeng opened a new issue #3306: [Doris On ES] 2020 roadmap URL: https://github.com/apache/incubator-doris/issues/3306 - 1. 过滤条件转换从BE 上推至 FE,BE只负责扫描数据,FE处理过滤条件 将查询层 和 执行层完全分离,这样很多需求都可以直接在FE中更方便处理了,另外降低社区用户开发成本 - 2. 增加对CastExpr过滤条件的处理 例: k 是float类型,如果 k > 2.

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #3305: Add field context for string field keyword type

2020-04-11 Thread GitBox
wuyunfeng opened a new pull request #3305: Add field context for string field keyword type URL: https://github.com/apache/incubator-doris/pull/3305 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] wuyunfeng opened a new issue #3304: [Doris On ES] ES字符串类型且有分词的字段的过滤在精确匹配的场景下语义缺失

2020-04-11 Thread GitBox
wuyunfeng opened a new issue #3304: [Doris On ES] ES字符串类型且有分词的字段的过滤在精确匹配的场景下语义缺失 URL: https://github.com/apache/incubator-doris/issues/3304 ES不需要建立索引就可以导入数据,这时候遇到字符串类型的字段时,ES会建立两种类型的字段,如: ``` { "test": { "mappings": { "doc": { "properties": {

[GitHub] [incubator-doris] HangyuanLiu commented on issue #3303: hdfs导入到doris时报这个错误:type:LOAD_RUN_FAIL; msg:errCode = 2, detailMessage = Parse timestamp (-2208988800) error

2020-04-11 Thread GitBox
HangyuanLiu commented on issue #3303: hdfs导入到doris时报这个错误:type:LOAD_RUN_FAIL; msg:errCode = 2, detailMessage = Parse timestamp (-2208988800) error URL: https://github.com/apache/incubator-doris/issues/3303#issuecomment-612382192 这个功能,在目前你不改变orc数值类型的前提下,是无法支持的。 但是这个功能是可以支持的,只不过目前被另一个PR阻塞住

[GitHub] [incubator-doris] zougengwei commented on issue #3303: hdfs导入到doris时报这个错误:type:LOAD_RUN_FAIL; msg:errCode = 2, detailMessage = Parse timestamp (-2208988800) error

2020-04-11 Thread GitBox
zougengwei commented on issue #3303: hdfs导入到doris时报这个错误:type:LOAD_RUN_FAIL; msg:errCode = 2, detailMessage = Parse timestamp (-2208988800) error URL: https://github.com/apache/incubator-doris/issues/3303#issuecomment-612381195 导入的是orc --

[GitHub] [incubator-doris] HangyuanLiu commented on issue #3303: hdfs导入到doris时报这个错误:type:LOAD_RUN_FAIL; msg:errCode = 2, detailMessage = Parse timestamp (-2208988800) error

2020-04-11 Thread GitBox
HangyuanLiu commented on issue #3303: hdfs导入到doris时报这个错误:type:LOAD_RUN_FAIL; msg:errCode = 2, detailMessage = Parse timestamp (-2208988800) error URL: https://github.com/apache/incubator-doris/issues/3303#issuecomment-612378738 你的导入文件是什么类型?

[GitHub] [incubator-doris] zougengwei opened a new issue #3303: hdfs导入到doris时报这个错误:type:LOAD_RUN_FAIL; msg:errCode = 2, detailMessage = Parse timestamp (-2208988800) error

2020-04-11 Thread GitBox
zougengwei opened a new issue #3303: hdfs导入到doris时报这个错误:type:LOAD_RUN_FAIL; msg:errCode = 2, detailMessage = Parse timestamp (-2208988800) error URL: https://github.com/apache/incubator-doris/issues/3303 LOAD LABEL example_db.label ( DATA INFILE("hdfs://hdfs_host:hdfs_port/

[GitHub] [incubator-doris] HangyuanLiu commented on issue #3300: Use Google/CCTZ to replace boost at timezone function

2020-04-11 Thread GitBox
HangyuanLiu commented on issue #3300: Use Google/CCTZ to replace boost at timezone function URL: https://github.com/apache/incubator-doris/pull/3300#issuecomment-612349756 > We have to update the thirdparty dependency of our CI environment, or the compilation will be failed. > I will up