morningman commented on a change in pull request #3191: DeleteV2 URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r407065663
########## File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java ########## @@ -0,0 +1,549 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.load; + +import com.google.common.base.Joiner; +import com.google.common.collect.Lists; +import com.google.common.collect.Maps; +import org.apache.doris.analysis.BinaryPredicate; +import org.apache.doris.analysis.DeleteStmt; +import org.apache.doris.analysis.IsNullPredicate; +import org.apache.doris.analysis.LiteralExpr; +import org.apache.doris.analysis.Predicate; +import org.apache.doris.analysis.SlotRef; +import org.apache.doris.catalog.Catalog; +import org.apache.doris.catalog.Column; +import org.apache.doris.catalog.Database; +import org.apache.doris.catalog.KeysType; +import org.apache.doris.catalog.MaterializedIndex; +import org.apache.doris.catalog.MaterializedIndex.IndexExtState; +import org.apache.doris.catalog.OlapTable; +import org.apache.doris.catalog.Partition; +import org.apache.doris.catalog.PartitionType; +import org.apache.doris.catalog.Replica; +import org.apache.doris.catalog.Table; +import org.apache.doris.catalog.Tablet; +import org.apache.doris.catalog.TabletInvertedIndex; +import org.apache.doris.catalog.Type; +import org.apache.doris.common.AnalysisException; +import org.apache.doris.common.Config; +import org.apache.doris.common.DdlException; +import org.apache.doris.common.ErrorCode; +import org.apache.doris.common.ErrorReport; +import org.apache.doris.common.MarkedCountDownLatch; +import org.apache.doris.common.UserException; +import org.apache.doris.common.io.Writable; +import org.apache.doris.common.util.ListComparator; +import org.apache.doris.common.util.TimeUtils; +import org.apache.doris.mysql.privilege.PrivPredicate; +import org.apache.doris.qe.ConnectContext; +import org.apache.doris.service.FrontendOptions; +import org.apache.doris.task.AgentBatchTask; +import org.apache.doris.task.AgentTaskExecutor; +import org.apache.doris.task.AgentTaskQueue; +import org.apache.doris.task.DeleteJob; +import org.apache.doris.task.DeleteJob.DeleteState; +import org.apache.doris.task.PushTask; +import org.apache.doris.thrift.TPriority; +import org.apache.doris.thrift.TPushType; +import org.apache.doris.thrift.TTaskType; +import org.apache.doris.transaction.GlobalTransactionMgr; +import org.apache.doris.transaction.TabletCommitInfo; +import org.apache.doris.transaction.TransactionState; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.io.DataInput; +import java.io.DataOutput; +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.LinkedList; +import java.util.List; +import java.util.Map; +import java.util.Map.Entry; +import java.util.UUID; +import java.util.concurrent.TimeUnit; + +public class DeleteHandler implements Writable { + private static final Logger LOG = LogManager.getLogger(DeleteHandler.class); + + // TransactionId -> DeleteJob + private Map<Long, DeleteJob> idToDeleteJob; + + // Db -> DeleteInfo list + private Map<Long, List<DeleteInfo>> dbToDeleteInfos; + + public DeleteHandler() { + idToDeleteJob = Maps.newConcurrentMap(); + dbToDeleteInfos = Maps.newConcurrentMap(); + } + + public void process(DeleteStmt stmt) throws DdlException { + String dbName = stmt.getDbName(); + String tableName = stmt.getTableName(); + String partitionName = stmt.getPartitionName(); + List<Predicate> conditions = stmt.getDeleteConditions(); + Database db = Catalog.getInstance().getDb(dbName); + if (db == null) { + throw new DdlException("Db does not exist. name: " + dbName); + } + + DeleteJob deleteJob = null; + DeleteInfo deleteInfo = null; + long transactionId; + MarkedCountDownLatch<Long, Long> countDownLatch; + db.readLock(); + try { + Table table = db.getTable(tableName); + if (table == null) { + throw new DdlException("Table does not exist. name: " + tableName); + } + + if (table.getType() != Table.TableType.OLAP) { + throw new DdlException("Not olap type table. type: " + table.getType().name()); + } + OlapTable olapTable = (OlapTable) table; + + if (olapTable.getState() != OlapTable.OlapTableState.NORMAL) { + throw new DdlException("Table's state is not normal: " + tableName); + } + + if (partitionName == null) { + if (olapTable.getPartitionInfo().getType() == PartitionType.RANGE) { + throw new DdlException("This is a range partitioned table." + + " You should specify partition in delete stmt"); + } else { + // this is a unpartitioned table, use table name as partition name + partitionName = olapTable.getName(); + } + } + + Partition partition = olapTable.getPartition(partitionName); + if (partition == null) { + throw new DdlException("Partition does not exist. name: " + partitionName); + } + + List<String> deleteConditions = Lists.newArrayList(); + + // pre check + checkDeleteV2(olapTable, partition, conditions, deleteConditions, true); + + // generate label + String label = "delete_" + UUID.randomUUID(); + + // begin txn here and generate txn id + transactionId = Catalog.getCurrentGlobalTransactionMgr().beginTransaction(db.getId(), + Lists.newArrayList(table.getId()), label,"FE: " + FrontendOptions.getLocalHostAddress(), + TransactionState.LoadJobSourceType.FRONTEND, Config.stream_load_default_timeout_second); + + deleteInfo = new DeleteInfo(db.getId(), olapTable.getId(), tableName, + partition.getId(), partitionName, + -1, 0, deleteConditions); + deleteJob = new DeleteJob(transactionId, deleteInfo); + idToDeleteJob.put(deleteJob.getTransactionId(), deleteJob); Review comment: If you put deleteInfo in `idToDeleteJob`, you need to make sure that the `deleteInfo` will be cleaned finally, even if any exception is thrown. So I think you should clear the deleteInfo in `finally` block. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
