kangkaisen commented on a change in pull request #3305: Add field context for string field keyword type URL: https://github.com/apache/incubator-doris/pull/3305#discussion_r407066649
########## File path: be/src/exec/es/es_predicate.cpp ########## @@ -298,8 +302,12 @@ Status EsPredicate::build_disjuncts_list(const Expr* conjunct) { } else { is_not_null = true; } + std::string col = slot_desc->col_name(); Review comment: Repeat four times. ``` std::string col = slot_desc->col_name(); if (_field_context.find(col) != _field_context.end()) { col = _field_context[col]; } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org