[GitHub] [incubator-doris] chaoyli edited a comment on issue #2946: coalesce date result is wrong

2020-02-18 Thread GitBox
chaoyli edited a comment on issue #2946: coalesce date result is wrong URL: https://github.com/apache/incubator-doris/issues/2946#issuecomment-588081302 I test the case in the 0.11.28 branch, it is OK. But it is not OK in master. ![Screen Shot 2020-02-19 at 3 48 18 PM](https://user-i

[GitHub] [incubator-doris] chaoyli commented on issue #2946: coalesce date result is wrong

2020-02-18 Thread GitBox
chaoyli commented on issue #2946: coalesce date result is wrong URL: https://github.com/apache/incubator-doris/issues/2946#issuecomment-588081302 I test the case in the master branch, it is OK. It may be fixed by another people. ![Screen Shot 2020-02-19 at 3 48 18 PM](https://user-im

[GitHub] [incubator-doris] imay commented on issue #2944: create pprof_profile_dir before heap profiling

2020-02-18 Thread GitBox
imay commented on issue #2944: create pprof_profile_dir before heap profiling URL: https://github.com/apache/incubator-doris/pull/2944#issuecomment-588065768 #2943 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] imay commented on a change in pull request #2944: create pprof_profile_dir before heap profiling

2020-02-18 Thread GitBox
imay commented on a change in pull request #2944: create pprof_profile_dir before heap profiling URL: https://github.com/apache/incubator-doris/pull/2944#discussion_r381102021 ## File path: be/src/http/action/pprof_actions.cpp ## @@ -243,23 +242,20 @@ void SymbolAction::ha

[GitHub] [incubator-doris] kangkaisen merged pull request #2902: bitmap_union_count support window function

2020-02-18 Thread GitBox
kangkaisen merged pull request #2902: bitmap_union_count support window function URL: https://github.com/apache/incubator-doris/pull/2902 This is an automated message from the Apache Git Service. To respond to the message, pl

[incubator-doris] branch master updated (87a84a7 -> a76f2b8)

2020-02-18 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 87a84a7 Add more doc content about hdfs broker auth and config detail (#2935) add a76f2b8 bitmap

[GitHub] [incubator-doris] kangkaisen opened a new pull request #2947: Fix some function with date type bug

2020-02-18 Thread GitBox
kangkaisen opened a new pull request #2947: Fix some function with date type bug URL: https://github.com/apache/incubator-doris/pull/2947 For https://github.com/apache/incubator-doris/issues/2946 For https://github.com/apache/incubator-doris/issues/2932 --

[GitHub] [incubator-doris] WingsGo commented on issue #2751: Fix bug for SIGFPE produced in AlphaRowset::split_range

2020-02-18 Thread GitBox
WingsGo commented on issue #2751: Fix bug for SIGFPE produced in AlphaRowset::split_range URL: https://github.com/apache/incubator-doris/pull/2751#issuecomment-588054993 > If you can reproduce this bug, you can use watch command in GDB. This command can used to know the variable modified i

[GitHub] [incubator-doris] kangkaisen opened a new issue #2946: coalesce date result is wrong

2020-02-18 Thread GitBox
kangkaisen opened a new issue #2946: coalesce date result is wrong URL: https://github.com/apache/incubator-doris/issues/2946 **Describe the bug** ``` CREATE TABLE `baseall_date` ( `k1` date not NULL COMMENT "", `k3` int(11) not NULL COMMENT "", `k9` float not NULL COMME

[GitHub] [incubator-doris] WingsGo opened a new pull request #2945: [Alter]Make max create replicas timeout configurable

2020-02-18 Thread GitBox
WingsGo opened a new pull request #2945: [Alter]Make max create replicas timeout configurable URL: https://github.com/apache/incubator-doris/pull/2945 For #2942 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-doris] wangbo commented on a change in pull request #2939: spark etl design

2020-02-18 Thread GitBox
wangbo commented on a change in pull request #2939: spark etl design URL: https://github.com/apache/incubator-doris/pull/2939#discussion_r381090187 ## File path: docs/documentation/cn/internal/spark_etl.md ## @@ -0,0 +1,342 @@ + + +# Doris spark导入ETL逻辑设计 + +## 背景 + +Doris为了

[GitHub] [incubator-doris] vagetablechicken opened a new pull request #2944: create pprof_profile_dir before heap profiling

2020-02-18 Thread GitBox
vagetablechicken opened a new pull request #2944: create pprof_profile_dir before heap profiling URL: https://github.com/apache/incubator-doris/pull/2944 only add contains clang-format diff If `config::heap_profile_dir` is no use, I'd like to remove it in this pr. http

[GitHub] [incubator-doris] kangkaisen commented on issue #2932: TupleIsNullPredicate lead BE core

2020-02-18 Thread GitBox
kangkaisen commented on issue #2932: TupleIsNullPredicate lead BE core URL: https://github.com/apache/incubator-doris/issues/2932#issuecomment-588043385 **So we could fix this issue by make `if` fn support date type or make `date_format` fn support date type**

[GitHub] [incubator-doris] kangkaisen commented on issue #2932: TupleIsNullPredicate lead BE core

2020-02-18 Thread GitBox
kangkaisen commented on issue #2932: TupleIsNullPredicate lead BE core URL: https://github.com/apache/incubator-doris/issues/2932#issuecomment-588043016 The logic chain is following: 1. `date_format(if(, NULL, `dt`), '%Y%m%d')` as HASH_PARTITIONED exprs,which is not right, we should use

[GitHub] [incubator-doris] vagetablechicken opened a new issue #2943: dump heap profile failed if config::pprof/heap_profile_dir is non-existing

2020-02-18 Thread GitBox
vagetablechicken opened a new issue #2943: dump heap profile failed if config::pprof/heap_profile_dir is non-existing URL: https://github.com/apache/incubator-doris/issues/2943 If we set an non-existing pprof_profile_dir, https://github.com/apache/incubator-doris/blob/9d03ba236b8d00e65

[GitHub] [incubator-doris] WingsGo opened a new issue #2942: [Alter]Schema Change in a big table will cause FE timeout and cancel this job

2020-02-18 Thread GitBox
WingsGo opened a new issue #2942: [Alter]Schema Change in a big table will cause FE timeout and cancel this job URL: https://github.com/apache/incubator-doris/issues/2942 **Describe the bug** When I doing a schema change job in a table which has 147 partitions,each partitions have 175 t

[GitHub] [incubator-doris] wangbo commented on a change in pull request #2939: spark etl design

2020-02-18 Thread GitBox
wangbo commented on a change in pull request #2939: spark etl design URL: https://github.com/apache/incubator-doris/pull/2939#discussion_r381064301 ## File path: docs/documentation/cn/internal/spark_etl.md ## @@ -0,0 +1,342 @@ + + +# Doris spark导入ETL逻辑设计 + +## 背景 + +Doris为了

[GitHub] [incubator-doris] wangbo commented on a change in pull request #2939: spark etl design

2020-02-18 Thread GitBox
wangbo commented on a change in pull request #2939: spark etl design URL: https://github.com/apache/incubator-doris/pull/2939#discussion_r381064301 ## File path: docs/documentation/cn/internal/spark_etl.md ## @@ -0,0 +1,342 @@ + + +# Doris spark导入ETL逻辑设计 + +## 背景 + +Doris为了

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2941: drop index when index column is dropped

2020-02-18 Thread GitBox
kangpinghuang commented on a change in pull request #2941: drop index when index column is dropped URL: https://github.com/apache/incubator-doris/pull/2941#discussion_r381058492 ## File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java ## @@ -224,7 +22

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2941: drop index when index column is dropped

2020-02-18 Thread GitBox
kangpinghuang commented on a change in pull request #2941: drop index when index column is dropped URL: https://github.com/apache/incubator-doris/pull/2941#discussion_r381058566 ## File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java ## @@ -157,7 +15

[GitHub] [incubator-doris] yangzhg opened a new pull request #2941: drop index when index column is dropped

2020-02-18 Thread GitBox
yangzhg opened a new pull request #2941: drop index when index column is dropped URL: https://github.com/apache/incubator-doris/pull/2941 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] imay commented on a change in pull request #2856: add spark load design

2020-02-18 Thread GitBox
imay commented on a change in pull request #2856: add spark load design URL: https://github.com/apache/incubator-doris/pull/2856#discussion_r381054500 ## File path: docs/documentation/cn/internal/spark_load.md ## @@ -0,0 +1,181 @@ +# Doris支持spark导入设计文档 Review comment:

[GitHub] [incubator-doris] crazyleeyang commented on a change in pull request #2939: spark etl design

2020-02-18 Thread GitBox
crazyleeyang commented on a change in pull request #2939: spark etl design URL: https://github.com/apache/incubator-doris/pull/2939#discussion_r381042007 ## File path: docs/documentation/cn/internal/spark_etl.md ## @@ -0,0 +1,323 @@ +# Doris spark导入ETL逻辑设计 + +## 背景 + +Doris

[GitHub] [incubator-doris] crazyleeyang commented on a change in pull request #2939: spark etl design

2020-02-18 Thread GitBox
crazyleeyang commented on a change in pull request #2939: spark etl design URL: https://github.com/apache/incubator-doris/pull/2939#discussion_r381041474 ## File path: docs/documentation/cn/internal/spark_etl.md ## @@ -0,0 +1,323 @@ +# Doris spark导入ETL逻辑设计 + +## 背景 + +Doris

[GitHub] [incubator-doris] wangbo opened a new pull request #2940: spark etl build global dict doc

2020-02-18 Thread GitBox
wangbo opened a new pull request #2940: spark etl build global dict doc URL: https://github.com/apache/incubator-doris/pull/2940 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] imay commented on a change in pull request #2933: Fix the flush_status bug in flush-executor

2020-02-18 Thread GitBox
imay commented on a change in pull request #2933: Fix the flush_status bug in flush-executor URL: https://github.com/apache/incubator-doris/pull/2933#discussion_r381026199 ## File path: be/src/olap/memtable_flush_executor.cpp ## @@ -35,15 +31,15 @@ std::ostream& operator<<

[GitHub] [incubator-doris] chaoyli closed issue #2919: Invalid memory address in doris::memory_copy

2020-02-18 Thread GitBox
chaoyli closed issue #2919: Invalid memory address in doris::memory_copy URL: https://github.com/apache/incubator-doris/issues/2919 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2933: Use `std::bind` to replace `boost::bind` in flush-executor

2020-02-18 Thread GitBox
lingbin commented on a change in pull request #2933: Use `std::bind` to replace `boost::bind` in flush-executor URL: https://github.com/apache/incubator-doris/pull/2933#discussion_r380753659 ## File path: be/src/olap/memtable_flush_executor.cpp ## @@ -35,15 +31,15 @@ std::

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #2939: spark etl design

2020-02-18 Thread GitBox
kangpinghuang opened a new pull request #2939: spark etl design URL: https://github.com/apache/incubator-doris/pull/2939 to resolve issue #2938 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-doris] imay commented on a change in pull request #2933: Use `std::bind` to replace `boost::bind` in flush-executor

2020-02-18 Thread GitBox
imay commented on a change in pull request #2933: Use `std::bind` to replace `boost::bind` in flush-executor URL: https://github.com/apache/incubator-doris/pull/2933#discussion_r380666858 ## File path: be/src/olap/memtable_flush_executor.cpp ## @@ -35,15 +31,15 @@ std::ost

[GitHub] [incubator-doris] kangpinghuang opened a new issue #2938: spark load etl design

2020-02-18 Thread GitBox
kangpinghuang opened a new issue #2938: spark load etl design URL: https://github.com/apache/incubator-doris/issues/2938 To resolve #2855, should realize spark etl job. here is issue to track the design. This is an automated

[GitHub] [incubator-doris] imay commented on a change in pull request #2925: fix bug: Error of exporting double type data to hdfs (#2924)

2020-02-18 Thread GitBox
imay commented on a change in pull request #2925: fix bug: Error of exporting double type data to hdfs (#2924) URL: https://github.com/apache/incubator-doris/pull/2925#discussion_r380665345 ## File path: be/src/runtime/export_sink.cpp ## @@ -142,10 +142,10 @@ Status Export

[GitHub] [incubator-doris] imay merged pull request #2935: Add more doc content about hdfs broker auth and config detail

2020-02-18 Thread GitBox
imay merged pull request #2935: Add more doc content about hdfs broker auth and config detail URL: https://github.com/apache/incubator-doris/pull/2935 This is an automated message from the Apache Git Service. To respond to t

[incubator-doris] branch master updated: Add more doc content about hdfs broker auth and config detail (#2935)

2020-02-18 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 87a84a7 Add more doc content about hdfs

[GitHub] [incubator-doris] chaoyli closed pull request #2934: Change boost::bind to std::bind

2020-02-18 Thread GitBox
chaoyli closed pull request #2934: Change boost::bind to std::bind URL: https://github.com/apache/incubator-doris/pull/2934 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] caiconghui commented on issue #2936: Missing some doc content about hdfs broker config for kerberos authentication

2020-02-18 Thread GitBox
caiconghui commented on issue #2936: Missing some doc content about hdfs broker config for kerberos authentication URL: https://github.com/apache/incubator-doris/issues/2936#issuecomment-587446753 #2935 This is an automated

[GitHub] [incubator-doris] caiconghui opened a new issue #2936: Missing some doc content about hdfs broker config for kerberos authentication

2020-02-18 Thread GitBox
caiconghui opened a new issue #2936: Missing some doc content about hdfs broker config for kerberos authentication URL: https://github.com/apache/incubator-doris/issues/2936 This is an automated message from the Apache Git S

[GitHub] [incubator-doris] tianxdcx opened a new issue #2937: nonsupport limit offset syntax

2020-02-18 Thread GitBox
tianxdcx opened a new issue #2937: nonsupport limit offset syntax URL: https://github.com/apache/incubator-doris/issues/2937 **Describe the bug** A clear and concise description of what the bug is. **To Reproduce** mysql> select * from testTable limit 3,1; ERROR 1064 (HY000):

[GitHub] [incubator-doris] caiconghui opened a new pull request #2935: Add more doc content about hdfs broker auth and config detail

2020-02-18 Thread GitBox
caiconghui opened a new pull request #2935: Add more doc content about hdfs broker auth and config detail URL: https://github.com/apache/incubator-doris/pull/2935 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] lingbin opened a new pull request #2933: Use `std::bind` to replace `boost::bind` in flush-executor

2020-02-18 Thread GitBox
lingbin opened a new pull request #2933: Use `std::bind` to replace `boost::bind` in flush-executor URL: https://github.com/apache/incubator-doris/pull/2933 This patch also removes some unneeded headers. this is an TODO in #2931 -

[GitHub] [incubator-doris] chaoyli opened a new pull request #2934: Change boost::bind to std::bind

2020-02-18 Thread GitBox
chaoyli opened a new pull request #2934: Change boost::bind to std::bind URL: https://github.com/apache/incubator-doris/pull/2934 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] kangkaisen opened a new issue #2932: TupleIsNullPredicate lead BE core

2020-02-18 Thread GitBox
kangkaisen opened a new issue #2932: TupleIsNullPredicate lead BE core URL: https://github.com/apache/incubator-doris/issues/2932 **Describe the bug** ``` *** Aborted at 1581922536 (unix time) try "date -d @1581922536" if you are using GNU date *** PC: @ 0xf522c9 doris::R

[incubator-doris] branch master updated: Use ThreadPool to refactor MemTableFlushExecutor (#2931)

2020-02-18 Thread lichaoyong
This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 1cf0fb9 Use ThreadPool to refactor

[GitHub] [incubator-doris] chaoyli merged pull request #2931: Use ThreadPool to refactor MemTableFlushExecutor

2020-02-18 Thread GitBox
chaoyli merged pull request #2931: Use ThreadPool to refactor MemTableFlushExecutor URL: https://github.com/apache/incubator-doris/pull/2931 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2931: Use ThreadPool to refactor MemTableFlushExecutor

2020-02-18 Thread GitBox
lingbin commented on a change in pull request #2931: Use ThreadPool to refactor MemTableFlushExecutor URL: https://github.com/apache/incubator-doris/pull/2931#discussion_r380576738 ## File path: be/src/olap/memtable_flush_executor.h ## @@ -38,132 +32,65 @@ class DeltaWrite

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2931: Use ThreadPool to refactor MemTableFlushExecutor

2020-02-18 Thread GitBox
lingbin commented on a change in pull request #2931: Use ThreadPool to refactor MemTableFlushExecutor URL: https://github.com/apache/incubator-doris/pull/2931#discussion_r380573580 ## File path: be/src/olap/memtable_flush_executor.cpp ## @@ -24,146 +24,62 @@ #include "ola

[GitHub] [incubator-doris] chaoyli commented on issue #2931: Use ThreadPool to refactor MemTableFlushExecutor

2020-02-18 Thread GitBox
chaoyli commented on issue #2931: Use ThreadPool to refactor MemTableFlushExecutor URL: https://github.com/apache/incubator-doris/pull/2931#issuecomment-587332412 ThreadPool related issue #2896 This is an automated message f

[GitHub] [incubator-doris] chaoyli closed issue #2896: Import a new ThreadPool Framework

2020-02-18 Thread GitBox
chaoyli closed issue #2896: Import a new ThreadPool Framework URL: https://github.com/apache/incubator-doris/issues/2896 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-doris] chaoyli opened a new pull request #2931: Use ThreadPool to refactor MemTableFlushExecutor

2020-02-18 Thread GitBox
chaoyli opened a new pull request #2931: Use ThreadPool to refactor MemTableFlushExecutor URL: https://github.com/apache/incubator-doris/pull/2931 1. MemTableFlushExecutor maintain a ThreadPool to receive FlushTask. 2. FlushToken is used to seperate different tasks from different tablets