imay commented on a change in pull request #2933: Fix the flush_status bug in
flush-executor
URL: https://github.com/apache/incubator-doris/pull/2933#discussion_r381026199
##########
File path: be/src/olap/memtable_flush_executor.cpp
##########
@@ -35,15 +31,15 @@ std::ostream& operator<<(std::ostream& os, const
FlushStatistic& stat) {
}
OLAPStatus FlushToken::submit(std::shared_ptr<MemTable> memtable) {
Review comment:
`std::bind` below copies `memtable`, which will keep it valid in your
mentioned situation. So I think it is OK to make the function's argument
reference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
