vagetablechicken opened a new issue #2943: dump heap profile failed if config::pprof/heap_profile_dir is non-existing URL: https://github.com/apache/incubator-doris/issues/2943 If we set an non-existing pprof_profile_dir, https://github.com/apache/incubator-doris/blob/9d03ba236b8d00e6558f177d768f8ce7ea77511f/be/src/http/action/pprof_actions.cpp#L72-L81 We simply pass it to HeapProfilerStart(). And in HeapProfilerStart(), it use `open(filename, O_WRONLY|O_CREAT|O_TRUNC, 0664);` to create file. If the file path is non-existing, it will fail to open file, then return `Failed dumping heap profile to ...` So, creating dir before `HeapProfilerStart()` is more humanized. config::heap_profile_dir is the same. BTW, use "heap_profile_file" is better than "dir", cause it should be a filename. https://github.com/apache/incubator-doris/blob/feef077520ba9dc843fa900febd43b8ed03c2b66/be/src/service/backend_service.cpp#L76
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
