Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-24 Thread via GitHub
davsclaus merged PR #12098: URL: https://github.com/apache/camel/pull/12098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.ap

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-24 Thread via GitHub
prasanthrao commented on code in PR #12098: URL: https://github.com/apache/camel/pull/12098#discussion_r1404157224 ## components/camel-quartz/src/test/java/org/apache/camel/component/quartz/QuartzCronRouteWithStartDateEndDateTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-24 Thread via GitHub
prasanthrao commented on code in PR #12098: URL: https://github.com/apache/camel/pull/12098#discussion_r1404154953 ## components/camel-quartz/src/main/docs/quartz-component.adoc: ## @@ -164,6 +164,22 @@ quartz://groupName/timerName?cron=0+0/5+12-18+?+*+MON-FRI&trigger.timeZone=

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-23 Thread via GitHub
orpiske commented on code in PR #12098: URL: https://github.com/apache/camel/pull/12098#discussion_r1404023389 ## components/camel-quartz/src/main/docs/quartz-component.adoc: ## @@ -164,6 +164,22 @@ quartz://groupName/timerName?cron=0+0/5+12-18+?+*+MON-FRI&trigger.timeZone=Euro

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-23 Thread via GitHub
orpiske commented on code in PR #12098: URL: https://github.com/apache/camel/pull/12098#discussion_r1404021387 ## components/camel-quartz/src/test/java/org/apache/camel/component/quartz/QuartzCronRouteWithStartDateEndDateTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apa

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-23 Thread via GitHub
prasanthrao commented on code in PR #12098: URL: https://github.com/apache/camel/pull/12098#discussion_r1403941565 ## components/camel-quartz/src/main/docs/quartz-component.adoc: ## @@ -164,6 +164,22 @@ quartz://groupName/timerName?cron=0+0/5+12-18+?+*+MON-FRI&trigger.timeZone=

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-23 Thread via GitHub
prasanthrao commented on code in PR #12098: URL: https://github.com/apache/camel/pull/12098#discussion_r1403941565 ## components/camel-quartz/src/main/docs/quartz-component.adoc: ## @@ -164,6 +164,22 @@ quartz://groupName/timerName?cron=0+0/5+12-18+?+*+MON-FRI&trigger.timeZone=

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-22 Thread via GitHub
prasanthrao commented on code in PR #12098: URL: https://github.com/apache/camel/pull/12098#discussion_r1401933589 ## components/camel-quartz/src/main/docs/quartz-component.adoc: ## @@ -164,6 +164,22 @@ quartz://groupName/timerName?cron=0+0/5+12-18+?+*+MON-FRI&trigger.timeZone=

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-21 Thread via GitHub
prasanthrao commented on code in PR #12098: URL: https://github.com/apache/camel/pull/12098#discussion_r1400212183 ## components/camel-quartz/src/main/docs/quartz-component.adoc: ## @@ -164,6 +164,22 @@ quartz://groupName/timerName?cron=0+0/5+12-18+?+*+MON-FRI&trigger.timeZone=

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
orpiske commented on code in PR #12098: URL: https://github.com/apache/camel/pull/12098#discussion_r1400053070 ## components/camel-quartz/src/main/docs/quartz-component.adoc: ## @@ -164,6 +164,22 @@ quartz://groupName/timerName?cron=0+0/5+12-18+?+*+MON-FRI&trigger.timeZone=Euro

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
prasanthrao commented on code in PR #12098: URL: https://github.com/apache/camel/pull/12098#discussion_r132894 ## components/camel-quartz/src/main/docs/quartz-component.adoc: ## @@ -164,6 +164,22 @@ quartz://groupName/timerName?cron=0+0/5+12-18+?+*+MON-FRI&trigger.timeZone=

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
davsclaus closed pull request #12089: CAMEL-20115: Support for Start Date and End Date in camel-quartz URL: https://github.com/apache/camel/pull/12089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
davsclaus commented on PR #12089: URL: https://github.com/apache/camel/pull/12089#issuecomment-1819855743 3.1.4 is EOL and we should only do this change in newer releases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
davsclaus commented on code in PR #12098: URL: https://github.com/apache/camel/pull/12098#discussion_r1399783137 ## components/camel-quartz/src/main/docs/quartz-component.adoc: ## @@ -164,6 +164,22 @@ quartz://groupName/timerName?cron=0+0/5+12-18+?+*+MON-FRI&trigger.timeZone=Eu

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
orpiske commented on code in PR #12098: URL: https://github.com/apache/camel/pull/12098#discussion_r1399495529 ## components/camel-quartz/src/main/docs/quartz-component.adoc: ## @@ -164,6 +164,22 @@ quartz://groupName/timerName?cron=0+0/5+12-18+?+*+MON-FRI&trigger.timeZone=Euro

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
prasanthrao commented on PR #12098: URL: https://github.com/apache/camel/pull/12098#issuecomment-1819299951 I might have found the issue. In [QuartzEndpoint](https://github.com/apache/camel/blob/99da2b85fbd897c5c52cff86eb285aedbdfb9b5e/components/camel-quartz/src/main/java/org/apache/camel/c

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
prasanthrao commented on PR #12098: URL: https://github.com/apache/camel/pull/12098#issuecomment-1819248819 My execution results are successful. I am building with "mvn clean install". Attaching the surefire reports for the failing classes. How can I check the failures? [org.apache.came

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
davsclaus commented on PR #12098: URL: https://github.com/apache/camel/pull/12098#issuecomment-1819084553 Do you have test errors locally ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
davsclaus commented on PR #12098: URL: https://github.com/apache/camel/pull/12098#issuecomment-1819084204 org.apache.camel.component.quartz.QuartzManuallyTriggerJobTest.testQuartzCronRoute | 10.54s | FAILURE -- | -- | -- org.apache.camel.component.quartz.QuartzAddRoutesAfterCamel

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
github-actions[bot] commented on PR #12098: URL: https://github.com/apache/camel/pull/12098#issuecomment-1818916338 :robot: The Apache Camel test robot will run the tests for you :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
oscerd commented on PR #12098: URL: https://github.com/apache/camel/pull/12098#issuecomment-1818914919 /component-test quartz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
github-actions[bot] commented on PR #12098: URL: https://github.com/apache/camel/pull/12098#issuecomment-1818838484 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committer

[PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
prasanthrao opened a new pull request, #12098: URL: https://github.com/apache/camel/pull/12098 # Description Cherry-pick of https://github.com/apache/camel/pull/12089 # Target - [ x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
prasanthrao commented on PR #12089: URL: https://github.com/apache/camel/pull/12089#issuecomment-1818826897 > Shouldn't this need to go on main first? Should I also create a PR for the main branch? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
oscerd commented on PR #12089: URL: https://github.com/apache/camel/pull/12089#issuecomment-1818824806 Shouldn't this need to go on main first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
prasanthrao commented on code in PR #12089: URL: https://github.com/apache/camel/pull/12089#discussion_r139893 ## components/camel-quartz/src/main/java/org/apache/camel/component/quartz/CamelJob.java: ## @@ -94,6 +101,18 @@ public void execute(JobExecutionContext context) th

Re: [PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
davsclaus commented on code in PR #12089: URL: https://github.com/apache/camel/pull/12089#discussion_r1398810047 ## components/camel-quartz/src/main/java/org/apache/camel/component/quartz/CamelJob.java: ## @@ -94,6 +101,18 @@ public void execute(JobExecutionContext context) thro

[PR] CAMEL-20115: Support for Start Date and End Date in camel-quartz [camel]

2023-11-20 Thread via GitHub
prasanthrao opened a new pull request, #12089: URL: https://github.com/apache/camel/pull/12089 # Description Fix for [CAMEL-20115](https://issues.apache.org/jira/browse/CAMEL-20115) Support for Start Date and End Date in camel-quartz # Target - [ ] I checked that the com