orpiske commented on code in PR #12098: URL: https://github.com/apache/camel/pull/12098#discussion_r1404021387
########## components/camel-quartz/src/test/java/org/apache/camel/component/quartz/QuartzCronRouteWithStartDateEndDateTest.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.quartz; + +import java.text.SimpleDateFormat; +import java.util.Calendar; +import java.util.Date; +import java.util.TimeZone; +import java.util.concurrent.TimeUnit; +import org.apache.camel.builder.RouteBuilder; +import org.apache.camel.component.mock.MockEndpoint; +import org.hamcrest.CoreMatchers; +import org.junit.jupiter.api.Test; + +import static org.hamcrest.MatcherAssert.assertThat; + +/** + * This test the CronTrigger as a timer endpoint in a route. + */ +public class QuartzCronRouteWithStartDateEndDateTest extends BaseQuartzTest { + + @Test + public void testQuartzCronRouteWithStartDateEndDateTest() throws Exception { + MockEndpoint mock = getMockEndpoint("mock:result"); + mock.expectedMinimumMessageCount(2); + mock.await(5, TimeUnit.SECONDS); + + MockEndpoint.assertIsSatisfied(context); + assertThat(mock.getReceivedExchanges().size() <= 3, CoreMatchers.is(true)); + } + + @Override + protected RouteBuilder createRouteBuilder() { + return new RouteBuilder() { + public void configure() { + SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssz"); + Calendar calendar = Calendar.getInstance(); + calendar.setTimeZone(TimeZone.getTimeZone("UTC")); + calendar.add(Calendar.SECOND, 3); + Date startDate = calendar.getTime(); + calendar.add(Calendar.SECOND, 2); + Date endDate = calendar.getTime(); + + // triggers every 1th second at precise 00,01,02,03..59 with startAt and endAt exactly 2 second apart. + // configuration will create a maximum of three messages + from("quartz://myGroup/myTimerName?cron=0/1 * * * * ?&trigger.startAt=" + dateFormat.format(startDate) Review Comment: I hope I am not nitpicking too much but, maybe use `fromF` for more legibility. These concatenations makes it harder to read. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
