prasanthrao commented on code in PR #12089:
URL: https://github.com/apache/camel/pull/12089#discussion_r1398944443
##########
components/camel-quartz/src/main/java/org/apache/camel/component/quartz/CamelJob.java:
##########
@@ -94,6 +101,18 @@ public void execute(JobExecutionContext context) throws
JobExecutionException {
}
}
+ private boolean hasTriggerExpired(JobExecutionContext context) {
+ Date fireTime = context.getFireTime();
+ if (context.getTrigger().getStartTime() != null &&
fireTime.before(context.getTrigger().getStartTime())) {
+ // Trigger invalid as Fire Time is before Start Time
+ return true;
+ } else if (context.getTrigger().getEndTime() != null &&
fireTime.after(context.getTrigger().getEndTime())) {
Review Comment:
Indeed I missed the case, and corrected it in the new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
