[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7df0f0b41067: [clang-tidy] Fixing a bug in `InfiniteLoopCheck` that raises false alarms on… (authored by ziqingluo-90). C

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 441816. ziqingluo-90 added a comment. I saw @aaron.ballman 's comment "//We typically don't add AST matchers until we have a need for them to be used in-tree (ASTMatchers.h is already really expensive to parse; adding matchers for everything possible wi

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 441832. ziqingluo-90 added a comment. adding a unit test for the ASTMatcher `objcMessageCallee` added in ASTMatcher.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128314/new/ https://reviews.llvm.org/D128

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 added a comment. In D128314#3605588 , @NoQ wrote: > Nice! > > There's usually some bureaucracy when creating new matchers, i.e. there > should be documentation and unittests covering them. I have added a unit test and auto-generated documen

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 added a comment. Hi @LegalizeAdulthood, @NoQ, @gribozavr2, @Eugene.Zelenko, Is there any further issue I should address for this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 _

[PATCH] D129398: Adding a new ASTMatcher for callee declarations of Obj-C message expressions

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, njames93, aaron.ballman, klimek, t-rasmud, usama54321, LegalizeAdulthood. ziqingluo-90 added a project: clang. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a subscriber: cfe-commits.

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 added a comment. In D128314#3635861 , @njames93 wrote: > Sorry to do this again, but could this be split up again, one patch for the > new matcher and the tests associated with it, then another for the actual bug > fix. > Also cc @klimek as

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 447854. ziqingluo-90 added a comment. The `callee` ASTMatcher overloading patch has landed in LLVM repo. I update this patch to use `callee` for matching objective-C message callee methods. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128314/

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, t-rasmud, usama54321, steakhal, vsavchenko, martong, Szelethus. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a pr

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

ziqingluo-90 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3853 +/// objcMessageExpr(objcMessageCallee(objcMethodDecl(hasName("foo" +AST_MATCHER_P(ObjCMessageExpr, objcMessageCallee, + internal::Matcher, InnerMatcher) {

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

ziqingluo-90 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3853 +/// objcMessageExpr(objcMessageCallee(objcMethodDecl(hasName("foo" +AST_MATCHER_P(ObjCMessageExpr, objcMessageCallee, + internal::Matcher, InnerMatcher) {

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

ziqingluo-90 updated this revision to Diff 444032. ziqingluo-90 added a comment. Taking @aaron.ballman 's advice to overload `callee` instead of creating a new matcher. Avoid to bloat `ASTMatchers.h`. Sorry to the reviewers that have to review this patch again. Repository: rG LLVM Github Mo

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

ziqingluo-90 updated this revision to Diff 49. ziqingluo-90 added a comment. Added a test to `unittests/ASTMatchers/Dynamic/RegistryTest.cpp` and confirms that the overloaded `callee` still works with dynamic matchers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129398/new/ https:

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

ziqingluo-90 added a comment. Thanks @aaron.ballman , I plan to commit this patch on Monday (18th July 2022). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129398/new/ https://reviews.llvm.org/D129398 ___ cfe-commits mailing list cfe-commits

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 added a comment. In D128401#3656559 , @NoQ wrote: > Looks great, thanks! > > Yes, I think refactoring can be done in a follow-up patch. Thank you, @NoQ! Let me politely ping the rest of the commenters: @LegalizeAdulthood, @gribozavr2, @Eug

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGb17baa1db613: [ASTMatchers] Adding a new matcher for callee declarations of Obj-C (authored by ziqingluo-90). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D158561: [-Wunsafe-buffer-usage] Add AST info to the unclaimed DRE debug notes for analysis

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4323586fcbb: [-Wunsafe-buffer-usage] Add AST info to the unclaimed DRE debug notes for… (authored by ziqingluo-90). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

ziqingluo-90 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp:313-315 + // Under ARC, blocks are retained and released automatically: + if (isArcManagedBlock(Referred, Ctx)) +return false; NoQ wrote

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

ziqingluo-90 updated this revision to Diff 453144. ziqingluo-90 added a comment. Addressing @NoQ 's comment. Let the symbolic execution simulator put a block object in an `UnknownSpaceRegion` from the start if ARC is enabled. Because in such cases whether the block is on stack or in heap depen

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

ziqingluo-90 added a comment. In D131009#3744416 , @NoQ wrote: > Aha perfect, now the entire static analyzer knows how to work with these > regions! > > I have one tiny remark and I think we can commit. Thank you! I will make the change then directly c

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:194 + } + return ContainsFunc && Overlap; +} njames93 wrote: > This will always be false as if it's true, the loop would return. Thanks for pointing this

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5e354ec4da1: [analyzer] Fixing a bug raising false positives of stack block object (authored by ziqingluo-90). Changed prior to commit: https://reviews.llvm.org/D131009?vs=453144&id=455992#toc Reposit

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9343ec861a2e: [clang-tidy] Adding the missing handling of "noreturn" attributes for Obj-C… (authored by ziqingluo-90). Re

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

ziqingluo-90 added reviewers: aaron.ballman, njames93, t-rasmud. ziqingluo-90 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersMacros.h:96 namespace internal { \ - class matcher_##DefineMatc

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

ziqingluo-90 updated this revision to Diff 484136. ziqingluo-90 added a comment. Did a rebase and addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138329/new/ https://reviews.llvm.org/D138329 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-u

[PATCH] D139233: [-Wunsafe-buffer-usage] Add an unsafe gadget for pointer-arithmetic operations

ziqingluo-90 updated this revision to Diff 484138. ziqingluo-90 added a comment. Did a rebase and addressed the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139233/new/ https://reviews.llvm.org/D139233 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadgets.de

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 484156. ziqingluo-90 added a comment. did a rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/lib/Analysis/UnsafeBufferU

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 484412. ziqingluo-90 added a comment. To follow LLVM's convention that global variables better have types that do NOT require construction, I change the type of the global variable from `std::string` to `constexpr const char * const`. CHANGES SINCE LA

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2ac5fd724c4: [-Wunsafe-buffer-usage] Add a new `forEachDescendant` matcher that skips… (authored by ziqingluo-90). Repository: rG LLVM Github Mon

[PATCH] D139233: [-Wunsafe-buffer-usage] Add an unsafe gadget for pointer-arithmetic operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf84f17c489f7: [-Wunsafe-buffer-usage] Add an unsafe gadget for pointer-arithmetic operations (authored by ziqingluo-90). Changed prior to commit:

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 487527. ziqingluo-90 added a comment. Rebase the patch with respect to the re-architecture: https://reviews.llvm.org/D140062. Since we do not have any `FixableGadget` to trigger fix-its at this point, I let fix-its of local variable declarations alway

[PATCH] D141338: [-Wunsafe-buffer-usage] Filter out conflicting fix-its

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a subscriber: mgrang. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Two fix-it

[PATCH] D137379: -Wunsafe-buffer-usage: adding warnings for unsafe buffer accesses by array subscript operations

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, t-rasmud, malavikasamak, jkorous, xazax.hun, aaron.ballman, gribozavr2. Herald added a subscriber: rnkovacs. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald add

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 491917. ziqingluo-90 added a comment. Addressed the minor comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/include/cl

[PATCH] D140179: [-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

ziqingluo-90 updated this revision to Diff 491960. ziqingluo-90 retitled this revision from "[WIP][-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas" to "[-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas". ziqingluo-90 added reviewers: aaron.ballman, xazax.hun, gr

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 marked 8 inline comments as done. ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:637 -static Strategy -getNaiveStrategy(const llvm::SmallVectorImpl &UnsafeVars) { NoQ wrote: > Hmm, did this need to be moved

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 492882. ziqingluo-90 added a comment. Addressing comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/include/clang/Analy

[PATCH] D141338: [-Wunsafe-buffer-usage] Filter out conflicting fix-its

ziqingluo-90 updated this revision to Diff 492914. ziqingluo-90 added a comment. Rebase the change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141338/new/ https://reviews.llvm.org/D141338 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/lib/Analysis/UnsafeBu

[PATCH] D141338: [-Wunsafe-buffer-usage] Filter out conflicting fix-its

ziqingluo-90 updated this revision to Diff 492918. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141338/new/ https://reviews.llvm.org/D141338 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/lib/Analysis/UnsafeBufferUsage.cpp clang/unittests/Analysis/CMakeList

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 494053. ziqingluo-90 marked 2 inline comments as done. ziqingluo-90 added a comment. To attach fix-its to notes instead of warnings. Fix the ending '\0' issue raised by @jkorous CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 494075. ziqingluo-90 added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/include/clang/Analysis/Analyses/

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[*]` to `DRE.data() + *`

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: t-rasmud, NoQ, jkorous, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Work in progress. So far, there is some glit

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 494689. ziqingluo-90 added a comment. address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/include/clang/Analysis

[PATCH] D140179: [-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

ziqingluo-90 updated this revision to Diff 494693. ziqingluo-90 added a comment. Change the fix-it test style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140179/new/ https://reviews.llvm.org/D140179 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/include/cl

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[any]` to `DRE.data() + any`

ziqingluo-90 updated this revision to Diff 494711. ziqingluo-90 retitled this revision from "[-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[*]` to `DRE.data() + *`" to "[-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[any]` to `DRE.data() + any`". ziqingluo-90 edited the summary o

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 495250. ziqingluo-90 added a comment. Fixed a bug in manipulating source locations: Using `SourceLocation::getLocWithOffset` to get a new source location `L` with a relative offset is convenient. But it requires extra care to make sure that `L` has the

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 495263. ziqingluo-90 added a comment. To avoid emitting incorrect fix-its for array subscripts on `span` objects: - For unsafe operations of the form `s[e]` where `s` is being transformed to be a `span`, we only emit fix-its for `s[e]` when `e` is a no

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:703 + case Strategy::Kind::Span: +return FixItList{}; + case Strategy::Kind::Wontfix: jkorous wrote: > jkorous wrote: > > jkorous wrote: > > > I am afraid I

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `&DRE[any]` to `DRE.data() + any`

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:508 + hasUnaryOperand(arraySubscriptExpr( + hasBase(ignoringParenImpCasts(declRefExpr()) +.bind(UPCAddressofArraySubscriptTag

[PATCH] D141338: [WIP][-Wunsafe-buffer-usage] Filter out conflicting fix-its

ziqingluo-90 updated this revision to Diff 488429. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141338/new/ https://reviews.llvm.org/D141338 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/lib/Analysis/UnsafeBufferUsage.cpp clang/unittests/Analysis/CMakeList

[PATCH] D141338: [WIP][-Wunsafe-buffer-usage] Filter out conflicting fix-its

ziqingluo-90 added a comment. In D141338#4042050 , @NoQ wrote: > Looks awesome! > > I'm worried that the test is going to rapidly become stale as you develop > fixits for `DeclStmt` further. It might make sense to write some > //unittests// for this cla

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:46 +/// The text indicating that the user needs to provide input there: +constexpr static const char *const UserFillPlaceHolder = "..."; } // end namespace clang ---

[PATCH] D140179: [WIP][-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

ziqingluo-90 updated this revision to Diff 489136. ziqingluo-90 added a comment. Rebase the patch. Move the check of whether a node is in an opt-out region to an earlier stage---the AST matching stage. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140179/new/ https://reviews.llvm.org/

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 490648. ziqingluo-90 added a comment. Rebased the code w.r.t. a series of refactoring in [-Wunsafe-buffer-usage]. Added a `FixableGadget` for array subscripts of the form `DRE[*]` in the context of lvalue-to-rvalue casting. Also did a refactoring at the

[PATCH] D140179: [WIP][-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

ziqingluo-90 added inline comments. Comment at: clang/include/clang/Basic/Diagnostic.h:1040-1043 + // An ordered sequence of "-Wunsafe-buffer-usage" opt-out regions in one + // translation unit. Each region is represented by a pair of start and end + // locations. + SmallVect

[PATCH] D140179: [WIP][-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:543 #define GADGET(x) \ -x ## Gadget::matcher().bind(#x), +allOf(x ## Gadget::matcher().bind(#x), notInSafeBuffe

[PATCH] D140179: [WIP][-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:551-555 +allOf(declStmt().bind("any_ds"), notInSafeBufferOptOut()) +// We match all DREs regardless of whether they are in safe-buffer +// opt-out region. Because an u

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 491581. ziqingluo-90 added a comment. Refactored the fix-it generation code to stop using the pretty-printer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 Files: clang/include/clang/Analysis/Anal

[PATCH] D128314: [Clang-tidy] Fixing bugs in clang-tidy infinite-loop checker

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, t-rasmud, usama54321, rsundahl, yln, kubamracek, krispy1994, jkorous, delcypher, chrisdangelo, thetruestblue, dcoughlin, aaron.ballman, alexfh, gribozavr, njames93, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, x

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 439132. ziqingluo-90 retitled this revision from "[Clang-tidy] Fixing bugs in clang-tidy infinite-loop checker" to "[Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker". ziqingluo-90 edited the summary of this revision. ziqingluo-90 added a com

[PATCH] D128401: [Clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, t-rasmud, usama54321, rsundahl, yln, kubamracek, krispy1994, jkorous, delcypher, chrisdangelo, thetruestblue, aaron.ballman, alexfh, gribozavr, njames93, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, kristof.beyl

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 439545. ziqingluo-90 removed reviewers: rsundahl, yln, kubamracek, krispy1994, jkorous, delcypher, chrisdangelo, thetruestblue, dcoughlin. ziqingluo-90 added a comment. rebased with the latest main's HEAD CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 439549. ziqingluo-90 added a comment. adjusted my changes with respect to the recent file structure changes in clang-tidy test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128314/new/ https://reviews.llvm.org/D128314 Files: clang-tools-ext

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 updated this revision to Diff 439573. ziqingluo-90 added a comment. rebased with the latest `main:HEAD` where clang-tidy file structure has changed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 Files: clang-tidy/bugprone/Infin

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 updated this revision to Diff 439580. ziqingluo-90 added a comment. Addressing Dmitri's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp clang-tools-e

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 updated this revision to Diff 439882. ziqingluo-90 added a comment. addressing more comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp clang-tools-extra/

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 updated this revision to Diff 439883. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp clang-tools-extra/test/clang-tidy/checkers/bugprone/infinite-loop.cpp cla

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 updated this revision to Diff 439884. ziqingluo-90 added a comment. trying to be consistent in that `auto` is used wherever possible CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 Files: clang-tools-extra/clang-tidy/bugprone/In

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 updated this revision to Diff 439903. ziqingluo-90 added a comment. I missed the part of coding standard about the usage of `auto`. Now change to conform to it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 Files: clang-too

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:34 /// Return whether `Var` was changed in `LoopStmt`. static bool isChanged(const Stmt *LoopStmt, const VarDecl *Var, ASTContext *Context) { -

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33f6161d9eaa: [-Wunsafe-buffer-usage] Group parameter fix-its (authored by ziqingluo-90). Changed prior to commit: https://reviews.llvm.org/D15305

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

ziqingluo-90 marked an inline comment as done. ziqingluo-90 added a comment. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2586 #endif it = FixablesForAllVars.byVar.erase(it); } else if (Tracker.hasUnclaimedUses(it->first)) { NoQ wrote:

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ziqingluo-90 marked an inline comment as done. Closed by commit rG700baeb765cf: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter (authored

[PATCH] D158561: [-Wunsafe-buffer-usage] Add AST info to the unclaimed DRE debug notes for analysis

ziqingluo-90 updated this revision to Diff 557330. ziqingluo-90 added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158561/new/ https://reviews.llvm.org/D158561 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-

[PATCH] D158561: [-Wunsafe-buffer-usage] Add AST info to the unclaimed DRE debug notes for analysis

ziqingluo-90 updated this revision to Diff 557579. ziqingluo-90 added a comment. address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158561/new/ https://reviews.llvm.org/D158561 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-d

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. When some unsafe operations are suppre

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 updated this revision to Diff 541269. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155524/new/ https://reviews.llvm.org/D155524 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-pragma-fixit.cpp Index: clang/test/SemaCXX/warn-u

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 updated this revision to Diff 541279. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155524/new/ https://reviews.llvm.org/D155524 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-pragma-fixit.cpp Index: clang/test/SemaCXX/warn-u

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 marked an inline comment as done. ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2346 + // computed above. We do not want to generate fix-its for such variables, + // since they are neither warned nor reachable from a warn

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 updated this revision to Diff 541652. ziqingluo-90 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155524/new/ https://reviews.llvm.org/D155524 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-pra

[PATCH] D155641: [-Wunsafe-buffer-usage] Do not assert that function parameters have names.

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: jkorous, NoQ, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is possible that a function parameter does

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1095-1102 // Gadgets "claim" variables they're responsible for. Once this loop finishes, // the tracker will only track DREs that weren't claimed by any gadgets, // i.e. not underst

[PATCH] D155667: [-Wunsafe-buffer-usage] Check source location validity before using `TypeLoc`s

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The safe-buffer analysis analyzes `TypeLoc`s

[PATCH] D155641: [-Wunsafe-buffer-usage] Do not assert that function parameters have names.

ziqingluo-90 marked an inline comment as done. ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1890-1891 + // A parameter of a function definition has no name. + // FIXME: We should create a name for the parameter as part of the

[PATCH] D155641: [-Wunsafe-buffer-usage] Do not assert that function parameters have names.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ziqingluo-90 marked an inline comment as done. Closed by commit rG4b5f17e008c6: [-Wunsafe-buffer-usage] Do not assert that function parameters have names (authored by z

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 updated this revision to Diff 542199. ziqingluo-90 added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155524/new/ https://reviews.llvm.org/D155524 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-p

[PATCH] D155667: [-Wunsafe-buffer-usage] Check source location validity before using `TypeLoc`s

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6302b6934b3: [-Wunsafe-buffer-usage] Check source location validity before using `TypeLoc`s (authored by ziqingluo-90). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

ziqingluo-90 abandoned this revision. ziqingluo-90 added a comment. In D150338#4503802 , @ziqingluo-90 wrote: > Re-landed in `a07a6f6c74a03405eccdcd3832acb2187d8b9c21` > > Moved the use of `clang::Sema` from `UnsafeBufferAnalysis` to > `AnalysisBasedWar

[PATCH] D156188: Refactor and improve for parameter fix-its

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Factor out the code that will be shared by

[PATCH] D156189: [-Wunsafe-buffer-usage] Refactor to let local variable fix-its and parameter fix-its share common code

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor the code for local variable fix-its

[PATCH] D156189: [-Wunsafe-buffer-usage] Refactor to let local variable fix-its and parameter fix-its share common code

ziqingluo-90 added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-local-var-span.cpp:242 ptr[2] = 30; - auto p = new int[10]; - // CHECK-DAG: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:11}:"std::span p" We no longer generat

[PATCH] D156192: [-Wunsafe-buffer-usage] Stop generating incorrect fix-its for variable declarations with unsupported specifiers

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have to give up on fixing a variable decla

[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

ziqingluo-90 accepted this revision. ziqingluo-90 added a comment. This revision is now accepted and ready to land. Thanks for cleaning the trailing whites. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155814/new/ https://reviews.llvm.org/D155814 __

[PATCH] D154880: [-Wunsafe-buffer-usage][WIP] Add a facility for debugging low fixit coverage.

ziqingluo-90 added a comment. This is a lot of work, thank you @t-rasmud & @NoQ ! I have a minor suggestion: can we use some macros to make the debug stub even shorter? The prefix `"failed to produce fixit for declaration"` is used in many places so probably we do not have to repeat it everywh

[PATCH] D156188: [-Wunsafe-buffer-usage] Refactor and improve for parameter fix-its

ziqingluo-90 updated this revision to Diff 544104. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156188/new/ https://reviews.llvm.org/D156188 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-parm-span.cpp clang/test/SemaCXX/warn-uns

[PATCH] D156189: [-Wunsafe-buffer-usage] Refactor to let local variable fix-its and parameter fix-its share common code

ziqingluo-90 updated this revision to Diff 544111. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156189/new/ https://reviews.llvm.org/D156189 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-local-var-span.cpp clang/test/SemaCXX/war

[PATCH] D156189: [-Wunsafe-buffer-usage] Refactor to let local variable fix-its and parameter fix-its share common code

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1824 + + if (!IdentText) +return {}; t-rasmud wrote: > When will this condition be satisfied? I just want to understand if there are > code examples where there is no i

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ziqingluo-90 marked an inline comment as done. Closed by commit rGcfcf76c6ad72: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an… (authore

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1095-1102 // Gadgets "claim" variables they're responsible for. Once this loop finishes, // the tracker will only track DREs that weren't claimed by any gadgets, // i.e. not underst

[PATCH] D156474: [-Wunsafe-buffer-usage][NFC] Slightly refactor and optimize the code

ziqingluo-90 created this revision. Herald added a reviewer: NoQ. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Slightly refactor and optimize the code in preparation for implementing grouping pa

  1   2   3   >