ziqingluo-90 added inline comments.
================ Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:46 +/// The text indicating that the user needs to provide input there: +constexpr static const char *const UserFillPlaceHolder = "..."; } // end namespace clang ---------------- jkorous wrote: > jkorous wrote: > > Should we rather pick something that is syntactically incorrect in C++ in > > order to prevent accidental silent corruption of the sources? > > FWIW Xcode uses `<#placeholder#>` syntax. > Correction - it is not Xcode, it is clang itself. > https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/CodeCompleteConsumer.cpp#L323 It looks like we could put different messages in between `<#` and `#>` to hint users in different situations. I'll make this member a function then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
