ziqingluo-90 added reviewers: aaron.ballman, njames93, t-rasmud.
ziqingluo-90 added inline comments.
================
Comment at: clang/include/clang/ASTMatchers/ASTMatchersMacros.h:96
namespace internal {
\
- class matcher_##DefineMatcher##Matcher
\
+ class matcher_##DefineMatcher##Matcher final
\
: public ::clang::ast_matchers::internal::MatcherInterface<Type> {
\
----------------
I was wondering if this change is necessary. This definition is so general
that it could affect a massive matchers. So any change to it should be very
careful and unnecessary changes may be avoided.
Other than that, this patch looks good to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135690/new/
https://reviews.llvm.org/D135690
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
