[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 414461. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaAttr.cpp clang/test/CodeGen/eval-method-fast-math.c Inde

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

zahiraam updated this revision to Diff 414467. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121380/new/ https://reviews.llvm.org/D121380 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/test/Sema/fp-eval-pragma.cpp Index: clang/test/Sema/fp-eval-pragma.cpp ==

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam added inline comments. Comment at: clang/test/CodeGen/eval-method-fast-math.c:83 +#pragma float_control(pop) + +int getFPEvalMethod() { aaron.ballman wrote: > What should happen in a case like this? > ``` > int whatever(float a, float b, float c) { > #

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15ef06f453c6: Diagnose when `#pragma clang fp eval_method` doesn't have a supported value. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 414729. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam added inline comments. Comment at: clang/test/CodeGen/eval-method-fast-math.c:113-116 +#pragma float_control(precise, on) +int val2 = __FLT_EVAL_METHOD__; + } + return __FLT_EVAL_METHOD__; aaron.ballman wrote: > Shouldn't there be CHECK lines for t

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 414739. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaAttr.cpp clang/t

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 416168. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 416180. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaAttr.cpp clang/t

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbf0d1932a3c: Currently the control of the eval-method is mixed with fast-math. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/

[PATCH] D118837: Methods visited for a special class must have an identifier.

zahiraam added a comment. In D118837#3395529 , @Fznamznon wrote: > Was this one submitted? Yes it was. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118837/new/ https://reviews.llvm.org/D118837 _

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, aaron.ballman, rjmccall, thakis, fhahn. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Setting the eval method via the `ffp-eval-method` option or via the `#pragma

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1065 + if (Tok.isNot(tok::annot_pragma_fp) && + getLangOpts().getFPEvalMethod() != LangOptions::FEM_UnsetOnCommandLine && aaron.ballman wrote: > This looks like it's going to diagno

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 417279. zahiraam marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/Sema/Sema.cpp clang/lib/Sema/Sema

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 417356. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/DiagnosticGroups.

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:492 +Diag(Loc, + diag::warn_eval_method_setting_via_pragma_in_value_unsafe_context); FpPragmaStack.Act(Loc, PSK_Set, StringRef(), NewFPFeatures); Not sure if I should repeat th

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +"results of

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam added a comment. In D121122#3402442 , @aaron.ballman wrote: > In D121122#3402334 , @bjope wrote: > >> Hello. We've got some problem in our downstream tests after this patch and >> I'm trying to figure o

[PATCH] D119290: [Clang] Add support for -fcx-limited-range, -fcx-fortran-rules options.

zahiraam added inline comments. Herald added a subscriber: MaskRay. Herald added a project: All. Comment at: clang/include/clang/Driver/Options.td:1853 +def fcx_fortran_rules : Flag<["-"], "fcx-fortran-rules">, Group; +def fnocx_fortran_rules : Flag<["-"], "fnocx-fortran-rules">,

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam created this revision. zahiraam added reviewers: aaron.ballman, andrew.w.kaylor, rjmccall, joerg, efriedma. Herald added a project: All. zahiraam requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. Currently the options ‘ffast-math’ and t

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3453770 , @glandium wrote: > Is it expected that `__FLT_EVAL_METHOD__` is not set at all anymore by > default after this change? @glandium would you mind giving a reproducer. We might have missed a flow path where t

[PATCH] D124004: Define __FLT_EVAL_METHOD__ when input source is stdin.

zahiraam created this revision. zahiraam added reviewers: aaron.ballman, andrew.w.kaylor. Herald added a subscriber: dschuff. Herald added a project: All. zahiraam requested review of this revision. Herald added a subscriber: aheejin. Herald added a project: clang. When the input source is stdin,

[PATCH] D124004: Define __FLT_EVAL_METHOD__ when input source is stdin.

zahiraam added a subscriber: glandium. zahiraam added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:845-855 + if (Input.isFile() && Input.getFile() == "-") { +Preprocessor &PP = CI.getPreprocessor(); +std::string PredefineBuffer; +PredefineBuffer

[PATCH] D124004: Define __FLT_EVAL_METHOD__ when input source is stdin.

zahiraam added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:845-855 + if (Input.isFile() && Input.getFile() == "-") { +Preprocessor &PP = CI.getPreprocessor(); +std::string PredefineBuffer; +PredefineBuffer.reserve(4080); +llvm::raw_string_o

[PATCH] D124004: Define __FLT_EVAL_METHOD__ when input source is stdin.

zahiraam added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:845-855 + if (Input.isFile() && Input.getFile() == "-") { +Preprocessor &PP = CI.getPreprocessor(); +std::string PredefineBuffer; +PredefineBuffer.reserve(4080); +llvm::raw_string_o

[PATCH] D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__

zahiraam created this revision. zahiraam added a reviewer: aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. This is to clarify that the macro __FLT_EVAL_METHOD__ it is not pre-defined like other preprocessor macros. It will

[PATCH] D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__

zahiraam updated this revision to Diff 424036. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124033/new/ https://reviews.llvm.org/D124033 Files: clang/docs/UsersManual.rst Index: clang/docs/UsersManual.rst === --- clang/

[PATCH] D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__

zahiraam added inline comments. Comment at: clang/docs/UsersManual.rst:1610-1618 The macro ``__FLT_EVAL_METHOD__`` will expand to either the value set from the command line option ``ffp-eval-method`` or to the value from the target info -setting. The ``__FLT_EVAL_METHOD__`` mac

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 405775. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp c

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 406443. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp c

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. @majnemer Review please :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam updated this revision to Diff 409307. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Basic/

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. @thakis, @ChuanqiXu I have fixed the warning and added a group to it. Can you please review? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailin

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3326874 , @thakis wrote: > Any idea what's going on in that Modules/cxx20-export-import.cpp failure? I don't see this failure? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam updated this revision to Diff 409349. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Basic/

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3326874 , @thakis wrote: > Any idea what's going on in that Modules/cxx20-export-import.cpp failure? @thakis I wasn't able to reproduce the issue with Modules/cxx20-export-import.cpp locally (tried a couple of build

[PATCH] D120066: FileCheck’s regexp stumped on Windows.

zahiraam created this revision. zahiraam added a reviewer: erichkeane. zahiraam requested review of this revision. Herald added a project: clang. We found that on Windows the regular expression used to describe the link command from the last RUN command of the LIT test debug-info-hotpatch.cpp, is

[PATCH] D120066: FileCheck’s regexp stumped on Windows.

zahiraam updated this revision to Diff 409678. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120066/new/ https://reviews.llvm.org/D120066 Files: clang/test/CodeGenCXX/debug-info-hotpatch.cpp Index: clang/test/CodeGenCXX/debug-info-hotpatch.c

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 430115. zahiraam marked an inline comment as done. Herald added subscribers: llvm-commits, hiraditya. Herald added projects: LLVM, All. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/La

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. Finally got around to work on this. @rjmccall, @andrew.w.kaylor at your convenience please let me know your thoughts. There are a couple of things I'm still not sure about! Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm

[PATCH] D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811)

zahiraam added a comment. In D91089#2383433 , @hans wrote: > Please take a look. @hans Thanks for looking at this. This test case is still crashing with the patch: ksh-3.2$ cat test.cpp template class __declspec(dllexport) foo { foo(int x = 0); };

[PATCH] D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811)

zahiraam added a comment. In D91089#2385821 , @hans wrote: >> clang.exe -c test.cpp >> Assertion failed: !hasUninstantiatedDefaultArg() && "Default argument is not >> yet instantiated!", file >> D:\IUSERS\zahiraam\llorg_ws\ws1\llvm\clang\lib\AST\Decl.cpp

[PATCH] D89960: Testing the use of arc.

zahiraam created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zahiraam requested review of this revision. Change-Id: I94cb7ac295acc8de9aa2c60bb31a1f5ee7d86fde Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89960 Files: clang/lib/Parse

[PATCH] D90165: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544.

zahiraam created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zahiraam requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90165 Files: clang/lib/Parse/ParseCXXInlineMethods.cpp clang/test/SemaCXX/invalid

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

zahiraam added a comment. In D80344#2796066 , @pengfei wrote: > We found another crush: https://godbolt.org/z/vcbvddEKr Even smaller https://godbolt.org/z/dbrGjGbaf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

zahiraam added a comment. Actually adding -O2 to all the LIT tests in this patch will trigger the same assertion at CGCleanup.cpp:1326. The code's assuming there is always an invoke destination in the program, but in these cases the InvokeDest is null. According to Microsoft's documentation,

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

zahiraam added a comment. wco Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7155 -if (EH.Asynch) - CmdArgs.push_back("-fasync-exceptions"); } Not really sure I understand this change. Isn't the case that if I compile with -EHa, I want the -fasy

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

zahiraam added a comment. In D103664#2799725 , @tentzen wrote: > In D103664#2798732 , @aganea wrote: > >> Thanks for the quick fix! Would you mind fixing the two failing tests >> please? (see above) > > Hmm, I ca

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

zahiraam added a comment. In D103664#2799852 , @tentzen wrote: > @zahiraam, are you removing all those CHECKs: > > - CHECK: invoke void @llvm.seh.scope.** > > those are placed there to ensure SEH scope semantic is preserved for Od.. I was just showing yo

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

zahiraam added a comment. In D103664#2799944 , @tentzen wrote: > since I cannot repro it locally, let's have this patch in to resolve -EHa -O2 > crashes for now. > I will add more -O2 tests in following patches. Sounds good to me! Repository: rG LLV

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

zahiraam added a comment. Files bug to edit the release not as suggested by @xbolva00 here: https://bugs.llvm.org/show_bug.cgi?id=51347 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 _

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

zahiraam added a comment. This patch was reverted because SPEC2006 and SPEC2017 are failing. More information here: https://bugs.llvm.org/show_bug.cgi?id=51346 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/ https://reviews.llvm.org/D93769

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

zahiraam added a comment. This patch had to be reverted because SPEC2006 and SPEC2017 are failing. More information here: https://bugs.llvm.org/show_bug.cgi?id=51346 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

zahiraam added a comment. This change has made this snippet fail. https://godbolt.org/z/3ehK784hY Pass https://godbolt.org/z/9q48WvsP7 fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

zahiraam added a comment. In D99005#2844365 , @mizvekov wrote: > In D99005#2844332 , @zahiraam wrote: > >> This change has made this snippet fail. >> https://godbolt.org/z/3ehK784hY Pass >> https://godbolt.org/z/9q4

[PATCH] D112094: Add support for floating-point option `ffp-eval-method` and for `pragma clang fp eval_method`.

zahiraam updated this revision to Diff 382392. zahiraam marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112094/new/ https://reviews.llvm.org/D112094 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptio

[PATCH] D112094: Add support for floating-point option `ffp-eval-method` and for `pragma clang fp eval_method`.

zahiraam added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3608-3609 +within a language linkage specification or at the start of a compound statement +(excluding comments). When used within a compound statement, the pragma is +active within the scope of the com

[PATCH] D112094: Add support for floating-point option `ffp-eval-method` and for `pragma clang fp eval_method`.

zahiraam updated this revision to Diff 382663. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112094/new/ https://reviews.llvm.org/D112094 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOpti

[PATCH] D112094: Add support for floating-point option `ffp-eval-method` and for `pragma clang fp eval_method`.

zahiraam added a comment. In D112094#3087531 , @aaron.ballman wrote: > One thing I think we need additional test coverage for is constant expression > evaluation. Should the pragma impact the resulting value stored into `f`: > > constexpr long double

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

zahiraam updated this revision to Diff 386014. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107994/new/ https://reviews.llvm.org/D107994 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contract-option.c

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

zahiraam updated this revision to Diff 386124. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107994/new/ https://reviews.llvm.org/D107994 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contract-option.c

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

zahiraam added inline comments. Comment at: clang/test/CodeGen/ffp-model.c:4 +// RUN: | FileCheck %s \ +// RUN: --check-prefixes=CHECK,CHECK-FAST --strict-whitespace + andrew.w.kaylor wrote: > Why did you add the strict-whitespace option? Because on some targets,

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

zahiraam updated this revision to Diff 386279. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107994/new/ https://reviews.llvm.org/D107994 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

zahiraam added a comment. In D107994#3115589 , @thakis wrote: > This fixes tests on macOS, but I don't know if the space is there > intentionally to check for presence of any attributes: > > % git diff > diff --git a/clang/test/CodeGen/ffp-contract-o

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

zahiraam added a comment. In D107994#3130494 , @wristow wrote: > The Release Note change here says: > > Floating Point Support in Clang > --- > - The -ffp-model=precise now implies -ffp-contract=on rather than > -ffp-

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

zahiraam updated this revision to Diff 387337. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107994/new/ https://reviews.llvm.org/D107994 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst === --- clan

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 387387. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/lib/Basic/Targets/X86.cpp clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Sema/SemaExpr.cpp clang/test/CodeGen/X86/Float16-aritmetic

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/test/CodeGen/X86/avx512fp16-complex.c:123 // X86-NOT: fdiv - // X86: call {{.*}} @__divhc3( + // X86: call {{.*}} @__divsc3( // X86: ret zahiraam wrote: > pengfei wrote: > > andrew.w.kaylor wrote: > > > Wh

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1315 + if ((SrcType->isHalfType() || iSFloat16Allowed) && + !CGF.getContext().getLangOpts().NativeHalfType) { // Cast to FP using the intrinsic if the half type itself isn't supported. -

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1315 + if ((SrcType->isHalfType() || iSFloat16Allowed) && + !CGF.getContext().getLangOpts().NativeHalfType) { // Cast to FP using the intrinsic if the half type itself isn't supported. -

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam created this revision. zahiraam added reviewers: rjmccall, pengfei, andrew.w.kaylor. zahiraam requested review of this revision. Herald added a project: clang. The _Float16 type is supported on x86 systems with SSE2 enabled. Operations are emulated by software emulation and “float” instr

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3136464 , @rjmccall wrote: > Does GCC actually change the formal types of expressions to `float`, or is it > doing this "no intermediate casts thing" as some sort of fp_contract-style > custom emission of trees of ex

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3138415 , @rjmccall wrote: > In D113107#3137921 , @zahiraam > wrote: > >> In D113107#3136464 , @rjmccall >> wrote: >> >>> Does GCC a

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam updated this revision to Diff 388179. zahiraam marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets/X86.cpp

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam updated this revision to Diff 388189. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets/X86.cpp clang/test/CodeGen/X86/Float16-arithmetic

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam updated this revision to Diff 388273. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets/X86.cpp clang/test/CodeGen/X86/Float16-arithmetic

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam added a comment. rG6623c02d70c3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 ___ cfe-commits mailing list cfe-commit

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

zahiraam added a comment. Added in the sycl_special_class attribute. This is still work in progress as I still have a few LIT tests failing and didn't address the issue of the separating sema from codegen work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/ https://reviews.l

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. Question about this comment: 3. “ Approaches #1 and #2 require a lot of intermediate conversions when hardware isn't available. In our example, a + b + c has to be calculated as (_Float16) ((float) (_Float16) ((float) a + (float) b) + (float) c), where the result of o

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam added a comment. In D114099#3148631 , @sylvestre.ledru wrote: > Actually, it breaks on all Debian. > Could you please revert it? Done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 __

[PATCH] D114483: Add support for sycl_special_class attribute

zahiraam created this revision. zahiraam added reviewers: bader, Naghasan, keryell, Fznamznon, aaron.ballman, erichkeane. Herald added subscribers: jdoerfert, Anastasia, ebevhan, yaxunl. zahiraam requested review of this revision. Herald added a project: clang. Special classes such as accessor, s

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam added a comment. In D114099#3148665 , @zahiraam wrote: > In D114099#3148631 , > @sylvestre.ledru wrote: > >> Actually, it breaks on all Debian. >> Could you please revert it? > > Done. I have reverted t

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added a comment. @rjmccall Would you mind looking at this when you have a moment? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 ___ cfe-commi

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3878422 , @ArcsinX wrote: > It seems for x86_32 case (e.g. with -m32 in command line) there is a > difference between clang and GCC: > clang: `__FLT_EVAL_METHOD__` == 0 > GCC: `__FLT_EVAL_METHOD__` == 2 > > Example: >

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865-1869 +if ((LangOpts.FastMath || + !LangOpts.FastMath && LangOpts.AllowFPReassoc && LangOpts.AllowRecip && + !LangOpts.FiniteMathOnly && LangOpts.NoSignedZero && + La

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865-1869 +if ((LangOpts.FastMath || + !LangOpts.FastMath && LangOpts.AllowFPReassoc && LangOpts.AllowRecip && + !LangOpts.FiniteMathOnly && LangOpts.NoSignedZero && + La

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865 FuncAttrs.addAttribute("approx-func-fp-math", "true"); -if ((LangOpts.FastMath || - (!LangOpts.FastMath && LangOpts.AllowFPReassoc && - LangOpts.AllowRecip && !LangOpts.Finit

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. >> I'm not following entirely, but -funsafe-math-optimizations is just a subset >> of -ffast-math, so checking only the properties that contribute to >> -funsafe-math-optimizations should be enough. >> I think it is way simpler to reason in these terms than enumeratin

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. In D136786#3893485 , @andrew.w.kaylor wrote: > In D136786#3892177 , @zahiraam > wrote: > I'm not following entirely, but -funsafe-math-optimizations is just a subset of -ffas

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. In D136786#3896708 , @michele.scandale wrote: > In D136786#3896341 , @zahiraam > wrote: > >>> I'm going to ignore fast-math right now, because I think the current >>> handling is mostl

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:181 + FPFeatures.allowFPContractAcrossStatement()); } Shouldn't then this also check for FPFeatures.getFPContractMode() ? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam created this revision. zahiraam added reviewers: majnemer, rnk. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Microsoft allows the support of ‘constexpr’ with ‘__declspec(dllimport) starting from VS2017 15.u update 4. See Constexpr

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. In D137107#3897326 , @rnk wrote: > Unless I'm missing something, I think Clang's behavior here is preferable to > MSVC's. MSVC produces code which will not link. Clang turns the linker error > into a compiler error, which is ge

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam added a comment. In D123630#3899550 , @lenary wrote: > Reverse ping. This has been accepted, what is the status of landing this? As far as I can tell this has landed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://r

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:950 +ComplexExprEmitter::EmitPromotedComplexOperand(const Expr *E, + QualType PromotionType) { + if (E->getType()->isAnyComplexType()) {

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam marked 2 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3140 + return CGF.Builder.CreateFPExt(result, ConvertType(E->getType())); + } + return result; rjmccall wrote: > Please extract this b

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. I think I introduced a bug when replacing the VisitUnaryMinus/Plus/Imag/Real with VisitMinus/Plus/Imag/Real. Now this simple test case is failing in the non-promotion path (with the +avx512fp16). _Float16 _Complex MinusOp_c_c(_Float16 c) { return -c; } error: cann

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3140 + return CGF.Builder.CreateFPExt(result, ConvertType(E->getType())); + } + return result; rjmccall wrote: > zahiraam wrote: > > rjmccall wrote: > > > Please extract this bl

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. With this last patch, the behaviors of CodeGen/volatile-1.c and CodeGenCXX/volatile-1.cpp have changed ( change with __imag). I have uploaded the changes but still trying to figure out what exactly changed and why. Thanks. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:609 + ComplexPairTy Op; + PromotionType = getPromotionType(E->getSubExpr()->getType()); + if (!PromotionType.isNull()) rjmccall wrote: > This is overwriting the argument, so the co

<    1   2   3   4   5   6   >