[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi updated this revision to Diff 104490. yamaguchi added a comment. Update patch. https://reviews.llvm.org/D34770 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocomplete.sh llvm/include/llvm/Option/OptTable.h llvm/lib/Option/OptTable.cp

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi added a comment. @teemperor > I think we want to support completing both -cc1 and normal driver invocation. > Most people use the driver, but for example during debugging people use the > cc1 version, so both are valid use cases. I just saw we actually have the > completion code in t

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi updated this revision to Diff 104982. yamaguchi added a comment. Update diff. Autocomplete cc1 flags when argv[1] is -cc1 or previous flag is -Xclang. https://reviews.llvm.org/D34770 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocomple

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi updated this revision to Diff 104983. yamaguchi added a comment. Update code comments. https://reviews.llvm.org/D34770 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocomplete.sh llvm/include/llvm/Option/OptTable.h llvm/lib/Option/Opt

[PATCH] D34924: [Bash-autocompletion] Check if bash-completion is installed

yamaguchi created this revision. Bash-autocompletion for clang depends on bash-completion system and abort `bash: _init_completion: command not found` when it is not installed. Changed to return silently if bash-completion is not installed. https://reviews.llvm.org/D34924 Files: clang/utils/

[PATCH] D34924: [Bash-autocompletion] Check if bash-completion is installed or not

yamaguchi updated this revision to Diff 104988. yamaguchi added a comment. Update patch and diff. https://reviews.llvm.org/D34924 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh === --- clang/uti

[PATCH] D34925: [Bash-completion] Fixed a bug that ~ doesn't expanded to $HOME

yamaguchi created this revision. `~/build/bin/clang -f[tab]` was executed without ~ expanded to $HOME, so changed this by expanding ~ to path using eval. https://reviews.llvm.org/D34925 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

yamaguchi added inline comments. Comment at: clang/utils/bash-autocomplete.sh:3 + +_clang_filedir() +{ ruiu wrote: > Is the output of `compgen -f` the same as `_filedir`? If so, can you always > use `compgen -f`? _filedir is better than `compgen -f`, because it

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

yamaguchi updated this revision to Diff 104992. yamaguchi marked 2 inline comments as done. yamaguchi added a comment. Update diff. https://reviews.llvm.org/D34924 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh ===

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

yamaguchi updated this revision to Diff 104993. yamaguchi added a comment. Update diff. https://reviews.llvm.org/D34924 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh === --- clang/utils/bash-au

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

yamaguchi updated this revision to Diff 104994. yamaguchi marked an inline comment as done. yamaguchi added a comment. Update patch. https://reviews.llvm.org/D34924 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh ==

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

yamaguchi updated this revision to Diff 104996. yamaguchi added a comment. _get_comp_words_by_ref still depends on older bash-completion package, so delete this and set cword and cur manualy. https://reviews.llvm.org/D34924 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-au

[PATCH] D34925: [Bash-completion] Fixed a bug that ~ doesn't expanded to $HOME

This revision was automatically updated to reflect the committed changes. Closed by commit rL306957: [Bash-completion] Fixed a bug that ~ doesn't expanded to $HOME (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D34925?vs=104991&id=104997#toc Repository: rL LLVM h

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306962: [Bash-autocompletion] Add support for older bash version. (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D34924?vs=104996&id=104999#toc Repository: rL LLVM https:

[PATCH] D34927: [Bash-autocompletion] Fix a bug that -foo=bar doesn't handled properly

yamaguchi created this revision. Fixed a bug that -foo=bar wasn't handled properly on old version of bash. https://reviews.llvm.org/D34927 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh === ---

[PATCH] D34930: [Bash-autocompletion] Show flags which has HelpText or GroupID

yamaguchi created this revision. Herald added a subscriber: hiraditya. Otherwise internal flags will be also completed. https://reviews.llvm.org/D34930 Files: llvm/lib/Option/OptTable.cpp Index: llvm/lib/Option/OptTable.cpp ===

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi updated this revision to Diff 105209. yamaguchi added a comment. Fixed typo. https://reviews.llvm.org/D34770 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocomplete.sh llvm/include/llvm/Option/OptTable.h llvm/lib/Option/OptTable.cpp

[PATCH] D34927: [Bash-autocompletion] Fix a bug that -foo=bar doesn't handled properly

yamaguchi updated this revision to Diff 105208. yamaguchi added a comment. Update diff. Thanks for the pointing out. https://reviews.llvm.org/D34927 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh ==

[PATCH] D34930: [Bash-autocompletion] Show flags which has HelpText or GroupID

yamaguchi added a comment. We are going to ask community which flags should be autocompleted or not, and tidy Options.td. https://reviews.llvm.org/D34930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi added inline comments. Comment at: clang/utils/bash-autocomplete.sh:16 + if [[ "${COMP_WORDS[1]}" == "-cc1" || "$w1" == "-Xclang" ]]; then +arg="#" + fi compnerd wrote: > `prefix` may be a better term? Thanks for reviewing! $arg has string like `-

[PATCH] D34930: [Bash-autocompletion] Show flags which has HelpText or GroupID

This revision was automatically updated to reflect the committed changes. Closed by commit rL307116: [Bash-autocompletion] Show flags which has HelpText or GroupID (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D34930?vs=105017&id=105211#toc Repository: rL LLVM h

[PATCH] D34927: [Bash-autocompletion] Fix a bug that -foo=bar doesn't handled properly

This revision was automatically updated to reflect the committed changes. Closed by commit rL307478: [Bash-autocompletion] Fix a bug that -foo=bar doesn't handled properly (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D34927?vs=105208&id=105771#toc Repository: rL

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

This revision was automatically updated to reflect the committed changes. Closed by commit rL307479: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D34770?vs=105209&id=105772#toc Repository: rL L

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

yamaguchi created this revision. `-W[tab]` will autocomplete warnings defined in this link: https://clang.llvm.org/docs/DiagnosticsReference.html#wweak-vtables https://reviews.llvm.org/D35447 Files: clang/include/clang/Basic/DiagnosticIDs.h clang/lib/Basic/DiagnosticIDs.cpp clang/lib/Driv

[PATCH] D35448: [Bash-autocompletion] Fixed a bug on bash

yamaguchi created this revision. Maybe I mismerged when merging previous commits by hand. https://reviews.llvm.org/D35448 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh === --- clang/utils/bash-

[PATCH] D35448: [Bash-autocompletion] Fixed a bug on bash

This revision was automatically updated to reflect the committed changes. Closed by commit rL308091: [Bash-autocompletion] Fixed a bug on bash (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D35448?vs=106752&id=106762#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

yamaguchi added a comment. @teemperor I forgot to include in DiagnosticIDs, thanks! What do you mean `reuse the normal flags` ? Do you think we should define these -W in Options.td like other flags? https://reviews.llvm.org/D35447 ___ cfe-commits

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

yamaguchi updated this revision to Diff 106763. yamaguchi added a comment. Update diff according to Rui and teemperor's comments. https://reviews.llvm.org/D35447 Files: clang/include/clang/Basic/DiagnosticIDs.h clang/lib/Basic/DiagnosticIDs.cpp clang/lib/Driver/Driver.cpp clang/test/Dri

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

yamaguchi updated this revision to Diff 106764. yamaguchi added a comment. Add code comment. https://reviews.llvm.org/D35447 Files: clang/include/clang/Basic/DiagnosticIDs.h clang/lib/Basic/DiagnosticIDs.cpp clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c Index: clang/tes

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

yamaguchi updated this revision to Diff 106774. yamaguchi added a comment. Fixed indent. https://reviews.llvm.org/D35447 Files: clang/include/clang/Basic/DiagnosticIDs.h clang/lib/Basic/DiagnosticIDs.cpp clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c Index: clang/test/Dr

[PATCH] D35447: [Bash-autocompletion] Add support for -W and -Wno

This revision was automatically updated to reflect the committed changes. Closed by commit rL308139: [Bash-autocompletion] Add support for -W and -Wno (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D35447?vs=106774&id=106805#toc Repository: rL LLVM https://review

[PATCH] D35759: [Bash-autocompletion] Show HelpText with possible flags

yamaguchi created this revision. Herald added a subscriber: hiraditya. `clang --autocomplete=-std` will show -std: Language standard to compile for -std= Language standard to compile for -stdlib=C++ standard library to use by this change. However, showing HelpText with complet

[PATCH] D35759: [Bash-autocompletion] Show HelpText with possible flags

yamaguchi updated this revision to Diff 107778. yamaguchi added a comment. Fixed test and update diff according to Rui's comment. https://reviews.llvm.org/D35759 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocomplete.sh llvm/lib/Option/OptTable

[PATCH] D35759: [Bash-autocompletion] Show HelpText with possible flags

yamaguchi added inline comments. Comment at: llvm/lib/Option/OptTable.cpp:240 if (StringRef(S).startswith(Cur)) -Ret.push_back(S); +Ret.push_back(S + "\t" + std::string(StringRef(In.HelpText))); } ruiu wrote: > I believe > > Ret.pus

[PATCH] D35759: [Bash-autocompletion] Show HelpText with possible flags

yamaguchi updated this revision to Diff 107779. yamaguchi added a comment. Add newline after the end of the line. https://reviews.llvm.org/D35759 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocomplete.sh llvm/lib/Option/OptTable.cpp Index: llv

[PATCH] D35762: [Bash-autocompletion] Fixed typo and add '-' after -Wno

yamaguchi created this revision. -Wno- was autocompleted as -Wno, so fixed this typo. https://reviews.llvm.org/D35762 Files: clang/lib/Basic/DiagnosticIDs.cpp clang/test/Driver/autocomplete.c Index: clang/test/Driver/autocomplete.c =

[PATCH] D35759: [Bash-autocompletion] Show HelpText with possible flags

yamaguchi updated this revision to Diff 107781. yamaguchi added a comment. Update diff. Delete trailing whitespace so that -stdlib= autocompletion works correctly. https://reviews.llvm.org/D35759 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocom

[PATCH] D35762: [Bash-autocompletion] Fixed typo and add '-' after -Wno

This revision was automatically updated to reflect the committed changes. Closed by commit rL308824: [Bash-autocompletion] Fixed typo and add '-' after -Wno (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D35762?vs=107780&id=107782#toc Repository: rL LLVM https://

[PATCH] D35763: [Bash-completion] Fixed a bug that file doesn't autocompleted after =

yamaguchi created this revision. File path wasn't autocompleted after `-fmodule-cache-path=[tab]`, so fixed this bug by checking if $flags contains only a newline or not. https://reviews.llvm.org/D35763 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh

[PATCH] D35759: [Bash-autocompletion] Show HelpText with possible flags

yamaguchi updated this revision to Diff 107790. yamaguchi added a comment. Update diff. Use llvm::join because we don't want to print two '\n's. https://reviews.llvm.org/D35759 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocomplete.sh llvm/lib/

[PATCH] D35759: [Bash-autocompletion] Show HelpText with possible flags

yamaguchi updated this revision to Diff 107791. yamaguchi added a comment. Update diff according to Rui's comment. https://reviews.llvm.org/D35759 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocomplete.sh llvm/lib/Option/OptTable.cpp Index: ll

[PATCH] D35759: [Bash-autocompletion] Show HelpText with possible flags

yamaguchi added a comment. @ruiu Yeah, we are planning to merge this to 5.0, so that clang Driver interface will be compatible among further versions. https://reviews.llvm.org/D35759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D35763: [Bash-completion] Fixed a bug that file doesn't autocompleted after =

This revision was automatically updated to reflect the committed changes. Closed by commit rL309112: [Bash-completion] Fixed a bug that file doesn't autocompleted after = (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D35763?vs=107787&id=108266#toc Repository: rL

[PATCH] D35759: [Bash-autocompletion] Show HelpText with possible flags

This revision was automatically updated to reflect the committed changes. Closed by commit rL309113: [Bash-autocompletion] Show HelpText with possible flags (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D35759?vs=107791&id=108267#toc Repository: rL LLVM https://

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

yamaguchi created this revision. This is a patch for bug [1] Warnings should not be emitted with -M and -MM flags, because this mode is only used for generate MakeFiles. [1]: https://bugs.llvm.org/show_bug.cgi?id=6817 https://reviews.llvm.org/D32341 Files: lib/Driver/ToolChains/Clang.cpp

[PATCH] D32342: Fixed llvm/CMakeLists.txt which doesn't generate proper MakeFiles and added relative path to llvm doxygen

yamaguchi created this revision. Herald added a subscriber: mgorny. Fist part is to change CMakeLists.txt and doxygen.cfg.in by following reasons: In llvm/docs/CmakeLists.txt, it was - set(abs_top_srcdir ${LLVM_MAIN_SRC_DIR}) - set(abs_top_builddir ${LLVM_BINARY_DIR}) However, ${LLVM_MAIN_SRC_DI

[PATCH] D32342: Changed llvm/CMakeLists.txt and added relative path to llvm doxygen

yamaguchi updated this revision to Diff 96124. yamaguchi retitled this revision from "Fixed llvm/CMakeLists.txt which doesn't generate proper MakeFiles and added relative path to llvm doxygen" to "Changed llvm/CMakeLists.txt and added relative path to llvm doxygen". yamaguchi added a comment. Ed

[PATCH] D32342: Changed llvm/CMakeLists.txt and added relative path to llvm doxygen

yamaguchi updated this revision to Diff 96128. yamaguchi added a comment. Modified README.txt. I thought its good to specify where the html is. https://reviews.llvm.org/D32342 Files: docs/CMakeLists.txt docs/README.txt docs/doxygen.cfg.in Index: docs/doxygen.cfg.in ==

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

yamaguchi updated this revision to Diff 96273. yamaguchi added a comment. Add testcase. https://reviews.llvm.org/D32341 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/m_and_mm.c Index: test/Driver/m_and_mm.c === --- test/

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

yamaguchi updated this revision to Diff 96283. yamaguchi added a comment. Fixed typo. https://reviews.llvm.org/D32341 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/m_and_mm.c Index: test/Driver/m_and_mm.c === --- test/Dr

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

yamaguchi added a comment. Do you think it is not a good idea to change condition if -MD or -MMD exists? for example, if ( !A->getOption().matches(options::OPT_MD) && !A->getOption().matches(options::OPT_MQ)) CmdArgs.push_back("-w"); https://reviews.llvm.org/D32341 __

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

yamaguchi updated this revision to Diff 97013. yamaguchi added a comment. show warnings with -M and -MD https://reviews.llvm.org/D32341 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/m_and_mm.c Index: test/Driver/m_and_mm.c =

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

yamaguchi updated this revision to Diff 97019. yamaguchi added a comment. Add testcase https://reviews.llvm.org/D32341 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/m_and_mm.c Index: test/Driver/m_and_mm.c === --- test/D

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi created this revision. This is an update patch for bug [1]. -Wmissing-braces should not fire for system headers. [1] https://bugs.llvm.org/show_bug.cgi?id=24007 https://reviews.llvm.org/D32646 Files: lib/Sema/SemaInit.cpp test/Sema/warn-missing-braces.c Index: test/Sema/warn-m

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi updated this revision to Diff 97182. yamaguchi added a comment. Update testcase. Made it minimal. https://reviews.llvm.org/D32646 Files: lib/Sema/SemaInit.cpp test/Sema/warn-missing-braces.c Index: test/Sema/warn-missing-braces.c =

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi marked 2 inline comments as done. yamaguchi added inline comments. Comment at: lib/Sema/SemaInit.cpp:892 + SpellingLoc = SemaRef.getSourceManager().getSpellingLoc(SpellingLoc); + if (!(SpellingLoc.isValid() && +SemaRef.getSourceManager().isInSyste

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi added inline comments. Comment at: lib/Sema/SemaInit.cpp:892 + SpellingLoc = SemaRef.getSourceManager().getSpellingLoc(SpellingLoc); + if (!(SpellingLoc.isValid() && +SemaRef.getSourceManager().isInSystemHeader(SpellingLoc))) { v.

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi added inline comments. Comment at: lib/Sema/SemaInit.cpp:892 + SpellingLoc = SemaRef.getSourceManager().getSpellingLoc(SpellingLoc); + if (!(SpellingLoc.isValid() && +SemaRef.getSourceManager().isInSystemHeader(SpellingLoc))) { ya

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi updated this revision to Diff 97224. yamaguchi added a comment. @v.g.vassilev I don't think early return is good idea, because someone might want to add some code under this function in the future. https://reviews.llvm.org/D32646 Files: lib/Sema/SemaInit.cpp test/Sema/warn-missi

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi updated this revision to Diff 97227. yamaguchi marked 5 inline comments as done. yamaguchi added a comment. Changed to early return. https://reviews.llvm.org/D32646 Files: lib/Sema/SemaInit.cpp test/Sema/warn-missing-braces.c Index: test/Sema/warn-missing-braces.c ==

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi updated this revision to Diff 97228. yamaguchi added a comment. Add check if there is -Wmissing-braces enabled or not. https://reviews.llvm.org/D32646 Files: lib/Sema/SemaInit.cpp test/Sema/warn-missing-braces.c Index: test/Sema/warn-missing-braces.c

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi updated this revision to Diff 97398. yamaguchi marked 2 inline comments as done. yamaguchi added a comment. Fixed spaces and changed SpellingLoc from two lines to one line. https://reviews.llvm.org/D32646 Files: lib/Sema/SemaInit.cpp test/Sema/warn-missing-braces.c Index: test/S

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

yamaguchi added inline comments. Comment at: lib/Sema/SemaInit.cpp:875 if (!VerifyOnly) { StructuredSubobjectInitList->setType(T); ruiu wrote: > Is it intentional that you run the new code only when !VerifyOnly? I think VerifyOnly is used to check if it

[PATCH] D31495: Fix a bug that -isysroot is completely ignored on Unix

This revision was automatically updated to reflect the committed changes. Closed by commit rL301998: Fix a bug that -isysroot is completely ignored on Unix (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D31495?vs=95402&id=97543#toc Repository: rL LLVM https://rev

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

yamaguchi added a comment. @teemperor ping..? https://reviews.llvm.org/D32341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2