yamaguchi added a comment. @teemperor
> I think we want to support completing both -cc1 and normal driver invocation. > Most people use the driver, but for example during debugging people use the > cc1 version, so both are valid use cases. I just saw we actually have the > completion code in the Driver, so what do you think about moving the code to > the Frontend part and call it from the Driver/Frontend part? I'm not sure what you refer to by ` I just saw we actually have the completion code in the Driver`. We are already auto completing both cc1 options and driver options, right? I'm sorry but I don't understand your main point. What am I missing? > I think it makes the most sense if we complete cc1 options but return > "-Xclang OPTION" when we encounter a cc1 option from the Driver (because it's > the least intrusive thing to do and the cc1 options are the ones everyone > forgets about :) ). What about completing cc1 options only when -cc1 is passed or -Xclang is passed before current input? https://reviews.llvm.org/D34770 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
