[PATCH] D102147: [Clang][Coroutines] Implement P2014R0 Option 1 behind -fcoroutines-aligned-alloc

ychen abandoned this revision. ychen added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. 327141f was landed as an alternative. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

ychen added a comment. Drive by thoughts: keyed this on assertion/debug build? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134550/new/ https://reviews.llvm.org/D134550 ___ cfe-commits mailing list cfe-

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

ychen added a comment. In D134542#3814029 , @erichkeane wrote: > Thanks for the quick review! Yeah, that case is a tough one, we don't really > have a good way of determining whether that was supposed to fail, or be the > best match. GCC does the opt

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

ychen created this revision. ychen added reviewers: MaskRay, probinson. Herald added subscribers: StephenFan, inglorion. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. So the behavior is consistent with n

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

ychen updated this revision to Diff 462968. ychen added a comment. - use getLastArg - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134657/new/ https://reviews.llvm.org/D134657 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/tes

[PATCH] D134659: [Driver] pass -fjmc to LTO

ychen created this revision. ychen added reviewers: MaskRay, probinson. Herald added subscribers: StephenFan, inglorion. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. So the behavior is consistent with n

[PATCH] D134673: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

ychen created this revision. ychen added a reviewer: probinson. Herald added a subscriber: inglorion. Herald added a project: All. ychen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Also refactor the existing code a little bit.

[PATCH] D134673: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

ychen added a comment. In D134673#3816166 , @probinson wrote: > I'm guessing the non-PS4 targets would also want this, so a similar change is > needed in tools::addLTOOptions. This can be a separate patch if you wish. That's right. It was submitted htt

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen updated this revision to Diff 463019. ychen added a comment. - update comments suggested by @mizvekov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133683/new/ https://reviews.llvm.org/D133683 Files: clang/lib/Sema/SemaTemplateDeduction.cp

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen added a comment. ping ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133683/new/ https://reviews.llvm.org/D133683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen updated this revision to Diff 463283. ychen added a comment. - add test for the conditioning on `ClangABICompat15`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133683/new/ https://reviews.llvm.org/D133683 Files: clang/lib/Sema/SemaTempla

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen added a comment. In D133683#3817523 , @mizvekov wrote: > - Missing release notes. I didn't add that because this patch is logically part of D128745 which has a release note already. > - FWIW GCC treats the `g(42

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen added a comment. In D134507#3817928 , @probinson wrote: > It feels odd to use a ClangABI check for something that is affecting what > source is accepted, but this is not my area of expertise. > @aaron.ballman or @rjmccall would probably be the righ

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen added a comment. In D133683#3818804 , @mizvekov wrote: > In D133683#3818752 , @ychen wrote: > >> I didn't add that because this patch is logically part of D128745 >> which

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen updated this revision to Diff 463309. ychen added a comment. - Update release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133683/new/ https://reviews.llvm.org/D133683 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplate

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen added a comment. In D133683#3818887 , @mizvekov wrote: > In D133683#3818858 , @ychen wrote: > >> It is clear cut by https://eel.is/c++draft/temp.deduct.partial#3.1. It is >> orthogonal to the DRs implemente

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen added a comment. In D133683#3819003 , @mizvekov wrote: > In D133683#3818935 , @ychen wrote: > >> This is described in https://eel.is/c++draft/temp.deduct.partial#13. >> Parietal ordering currently doesn't c

[PATCH] D134673: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rG55cd5bc50964: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134673/new/ https://revie

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5839fb6d25b4: [Driver] pass -fcrash-diagnostics-dir to LTO (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D134659: [Driver] pass -fjmc to LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rG54967c01d2bb: [Driver] pass -fjmc to LTO (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134659/new/ https://reviews.llvm.org/D134659 Fil

[PATCH] D134772: [Clang] Make constraints of auto part of NTTP instead of AutoType

ychen created this revision. ychen added reviewers: mizvekov, saar.raz, rsmith. Herald added subscribers: arphaman, martong, kristof.beyls. Herald added a reviewer: shafik. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

ychen added a comment. In D134657#3819435 , @thakis wrote: > This breaks `Driver/crash-diagnostics-dir-2.c` on my mac: > > FAIL: Clang :: Driver/crash-diagnostics-dir-2.c (7510 of 15804) > TEST 'Clang :: Driver/crash-diagnostics-d

[PATCH] D134772: [Clang] Make constraints of auto part of NTTP instead of AutoType

ychen added a comment. @rsmith, thanks for chiming in. In D134772#3819502 , @rsmith wrote: > I'm somewhat skeptical of this approach, because constrained `auto` can > appear in places within the type of an NTTP other than the top level -- for > example

[PATCH] D134772: [Clang] Make constraints of auto part of NTTP instead of AutoType

ychen added a comment. In D134772#3819551 , @mizvekov wrote: > I don't think the problem here is an uniquing problem per se, it's just that > the constraints are part of the canonical type of undeduced auto, which is > undesirable for the NTTP. > > Mayb

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

ychen added a comment. Herald added subscribers: pcwang-thead, abrachet. Herald added a reviewer: ThomasRaoux. Herald added a project: All. It is possible to just use `clang-format @response.txt`? That should also invoke the executable once. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

ychen created this revision. ychen added reviewers: mizvekov, rsmith, erichkeane, aaron.ballman. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As @mizvekov suggested in D134772

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

ychen updated this revision to Diff 464731. ychen added a comment. - address @erichkeane's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135088/new/ https://reviews.llvm.org/D135088 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/De

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

ychen marked an inline comment as done. ychen added a comment. In D135088#3831183 , @erichkeane wrote: > This looks right enough to me with the 1 nit, but let Matheus take a look > before committing. Thanks for the quick review. Repository: rG LLVM

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added a comment. The Windows premerge failure looks relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135045/new/ https://reviews.llvm.org/D135045 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen added a comment. ping. To avoid confusion, note that this and D128745 are not about C++20 or newer language versions. They are implementing DRs which should apply to all language versions >= C++11 since the variadic template is involved. ClangABICompat

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen added a comment. In D134507#3831951 , @rjmccall wrote: > DRs do not modify existing language versions. We can decide as a vendor > whether to apply DRs to existing language versions. The fact that this is a > language semantics change makes me t

[PATCH] D135115: [clang-format] update --files help description

ychen created this revision. ychen added reviewers: MyDeveloperDay, probinson. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. correlates the option with reponse file concept. Repository: rG LLVM Githu

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

This revision was automatically updated to reflect the committed changes. Closed by commit rG1fb728e95c74: [c++] implements tentative DR1432 for partial ordering of function template (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

ychen added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:5736-5737 llvm::FoldingSetNodeID ID; AutoType::Profile(ID, *this, DeducedType, Keyword, IsDependent, TypeConstraintConcept, TypeConstraintArgs); if (AutoType *AT = AutoTypes.FindNo

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

ychen updated this revision to Diff 464858. ychen added a comment. - remove dead code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135088/new/ https://reviews.llvm.org/D135088 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/DeclTemplate.cpp

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

ychen added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:5745-5746 + if (TypeConstraintConcept) { +Canon = getAutoTypeInternal(QualType(), Keyword, false, IsPack, nullptr, +{}, true); // Find the insert posit

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

ychen updated this revision to Diff 464861. ychen added a comment. - add back `IsDependent` parameter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135088/new/ https://reviews.llvm.org/D135088 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

ychen added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:5745-5746 + if (TypeConstraintConcept) { +Canon = getAutoTypeInternal(QualType(), Keyword, false, IsPack, nullptr, +{}, true); // Find the insert posit

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

ychen updated this revision to Diff 464865. ychen marked an inline comment as done. ychen added a comment. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135088/new/ https://reviews.llvm.org/D135088 Files: clang/lib/AST/ASTCon

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

ychen marked an inline comment as done. ychen added a comment. @mizvekov Thanks for the review! Comment at: clang/lib/AST/ASTContext.cpp:5768-5769 if (!IsCanon) { if (DeducedType.isNull()) { - SmallVector CanonArgs; - bool AnyNonCanonArgs = - ::getCan

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3832432 , @rjmccall wrote: > Pinging this thread because it has more reviewers who probably have opinions > about this. > > https://reviews.llvm.org/D134507 is a patch that adds `-fclang-abi-compat` > support around the

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. > There were multiple DRs implemented in this patch. > > DR692 was a fix against C++11 > DR1395 was a fix against C++17 > DR1432 is still open but was opened against C++11 > > Which DRs do we wish to implement in what language modes? There are regressions if DR1395 is not a

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3834387 , @hubert.reinterpretcast wrote: > In D128745#3834313 , @ychen wrote: > >> I think the consensus is some flag is needed to put it back to legacy >> behavior just in case

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3834454 , @tahonermann wrote: > Is it known what gcc and Microsoft maintainers are going to do with these > DRs? I don't see any recent changes in gcc, but the following is > interesting... It's hard to tell if they d

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

This revision was automatically updated to reflect the committed changes. ychen marked an inline comment as done. Closed by commit rG5d69937b9f9c: [Clang] make canonical AutoType constraints-free (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D135115: [clang-format] update --files help description

ychen updated this revision to Diff 465134. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135115/new/ https://reviews.llvm.org/D135115 Files: clang/docs/ClangFormat.rst Index: clang/docs/ClangFormat.rs

[PATCH] D135115: [clang-format] update --files help description

ychen updated this revision to Diff 465151. ychen added a comment. - make corresponding change in the commandline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135115/new/ https://reviews.llvm.org/D135115 Files: clang/docs/ClangFormat.rst clan

[PATCH] D134772: [Clang] Make constraints of auto part of NTTP instead of AutoType

ychen abandoned this revision. ychen added a comment. D135088 was landed instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134772/new/ https://reviews.llvm.org/D134772 ___

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4313 +// 253402300799 is the UNIX timestamp of -12-31T23:59:59Z. +if (StringRef(Epoch).getAsInteger(10, V) || V > 253402300799) + Diags.Report(diag::err_fe_invalid_source_date_epoc

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 465543. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclTemplate.h

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 465547. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclTemplate.h

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 465549. ychen added a comment. - rebased on D135088 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1092 +TT = *PP.getPreprocessorOpts().SourceDateEpoch; +TM = std::gmtime(&TT); + } else { MaskRay wrote: > ychen wrote: > > Why not use localtime as the else branch? > > > > As m

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1092 +TT = *PP.getPreprocessorOpts().SourceDateEpoch; +TM = std::gmtime(&TT); + } else { MaskRay wrote: > ychen wrote: > > MaskRay wrote: > > > ychen wrote: > > > > Why not use l

[PATCH] D135115: [clang-format] update --files help description

ychen added a comment. In D135115#3839547 , @HazardyKnusperkeks wrote: > Except for the `@` part. (Which also isn't handles by clang-format, or > is it?) It is not. It is handled by the LLVM commandline library. https://llvm.org/docs/CommandLine.html#

[PATCH] D135115: [clang-format] update --files help description

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c94f75f00af: [clang-format] update --files help description (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added a comment. Looks good to me except for one nit. And the test still fails on Windows for some reason. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1612 + time_t TT = *getPreprocessorOpts().SourceDateEpoch; + std::tm *TM = std::gmtime(&TT); Result

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1612 + time_t TT = *getPreprocessorOpts().SourceDateEpoch; + std::tm *TM = std::gmtime(&TT); Result = asctime(TM); MaskRay wrote: > ychen wrote: > > To be consistent with

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. Hi @mizvekov , after D135088 , this patch is ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 __

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3850667 , @hubert.reinterpretcast wrote: > In D128745#3834435 , @ychen wrote: > >> New flag or not, as long as we allow users to use the old behavior, it is >> already fracturin

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen accepted this revision as: ychen. ychen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135045/new/ https://reviews.llvm.org/D135045 __

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 467031. ychen added a comment. - remove dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclTe

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. @mizvekov it turns out I don't need that code anymore. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 ___ cfe-commits mailing li

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3851458 , @rjmccall wrote: > Was this change in LLVM 15, or is it still unreleased? This is still unreleased. It will be released in Clang16. In D128745#3852409 , @aaron.ballman

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen abandoned this revision. ychen added a comment. Per further discussions in D128745 , this is not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134507/new/ https://reviews.llvm.org/D134507 __

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3854675 , @hubert.reinterpretcast wrote: >> I reached out to the GCC author to confirm that the committee acknowledges >> that there should be a change to temp.func.order p6.2.1, but no consensus on >> what changes to

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 467845. ychen added a comment. - skip non-dependent NTTP comparison because they're equivalent (match GCC) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clan

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5511-5539 + template ::value, bool> = true> + bool operator()(T1 *PS1, T2 *PS2) { +return hasEqualTemplateArgumentList( +PS1->getTemplateArgsAsWritten()->arguments(), +PS2->get

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 468286. ychen added a comment. - use getTemplateArgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Decl

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5511-5539 + template ::value, bool> = true> + bool operator()(T1 *PS1, T2 *PS2) { +return hasEqualTemplateArgumentList( +PS1->getTemplateArgsAsWritten()->arguments(), +PS2->get

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen added a comment. In D134507#3856956 , @tahonermann wrote: >> Per further discussions in D128745 , this >> is not needed. > > I agree that the code change is not needed. I think it is worth keeping the > test thou

[PATCH] D136120: [Clang] follow-up D128745, remove all ClangABICompat checks

ychen created this revision. ychen added reviewers: aaron.ballman, erichkeane, hubert.reinterpretcast. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per discussions in D128745

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

ychen created this revision. ychen added reviewers: royjacobson, erichkeane. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For https://github.com/llvm/llvm-project/issues/58382 Repository: rG LLVM Gi

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

ychen updated this revision to Diff 468430. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136133/new/ https://reviews.llvm.org/D136133 Files: clang/test/CXX/drs/dr25xx.cpp clang/test/CXX/drs/dr2xx.cpp clang/ww

[PATCH] D136120: [Clang] follow-up D128745, remove ClangABICompat checks

ychen updated this revision to Diff 472727. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136120/new/ https://reviews.llvm.org/D136120 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D136120: [Clang] follow-up D128745, remove ClangABICompat checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG40e99473170f: [Clang] follow-up D128745, remove ClangABICompat checks (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136120/new/ https:/

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. In D139837#4067208 , @ayzhao wrote: > Thanks for your effort on this! > > FYI I landed parenthesized aggregate initialization in D141546 > , so CTAD for that feature should no longer > be blocked.

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. gentle ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexical order before emission

ychen added a comment. gentle ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen added a comment. gentle ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127259/new/ https://reviews.llvm.org/D127259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen added a comment. In D127259#3590127 , @rnk wrote: > I think Richard had some concerns in the other review that this may not be > enough to really guarantee initialization order within the TU. I couldn't say > either way, I shouldn't review this co

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

ychen created this revision. ychen added reviewers: rnk, rsmith, aaron.ballman. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. By the standard https://eel.is/c++draft/basic.start#dynamic-1, implicitly in

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

ychen updated this revision to Diff 431825. ychen added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126341/new/ https://reviews.llvm.org/D126341 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenModule.cpp c

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

ychen added a comment. In D126341#3537675 , @aaron.ballman wrote: > Adding the language WG as a reviewer in case others have opinions. > >> The underlying problem is basically wg21.link/cwg362 which has no concensus >> yet. > > According to > https://w

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

ychen added a comment. In D126341#3537947 , @rnk wrote: > I'm somewhat supportive of the goal here, but I think there are still some > underlying issues. > > First, why should these guarantees be limited to instantiations and not > inline variables? Suc

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added inline comments. Herald added subscribers: jsji, Enna1. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1843 + + auto *FTRTTIProxy = new llvm::GlobalVariable( + TheModule, Addr->getType(), pcc wrote: > ychen wrote: > > pcc wrote: > > > Are these

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

ychen added a comment. In D126341#3554286 , @rnk wrote: > Well, I guess we're out of luck, but that seems like a very poorly considered > requirement from the standard. If we can't use comdats for inline variables, > every time you include a header with

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexing order before emission

ychen created this revision. ychen added reviewers: rnk, rsmith. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/55804 The lexing order is already bookkep

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexing order before emission

ychen updated this revision to Diff 434884. ychen added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenModule.cpp cla

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen created this revision. ychen added reviewers: rsmith, rnk. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Based on the Richard's suggestion in D126341 : `If we can

[PATCH] D119296: KCFI sanitizer

ychen added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2257 + + F->setPrefixData(CreateKCFITypeId(FD->getType())); + F->addFnAttr("kcfi-target"); FYI: using prefix data may not work for the C++ coroutine. (https://github.com/llvm/llvm-pro

[PATCH] D154301: Fix aggregate CTAD with string literals adding extra const

ychen added a comment. Thanks for catching this. The change LGTM. I think this is https://wg21.link/cwg2681. Could you please move the test to `clang/test/CXX/drs/dr26xx.cpp` and keep only these tests that are in the DR? Then you could run `clang/www/make_cxx_dr_status` to update `clang/www/cx

[PATCH] D154301: Fix aggregate CTAD with string literals adding extra const

ychen added a comment. `clang/test/SemaTemplate/aggregate-deduction-candidate.cpp` seems need updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154301/new/ https://reviews.llvm.org/D154301 ___ cfe-c

[PATCH] D154301: Fix aggregate CTAD with string literals adding extra const

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154301/new/ https://reviews.llvm.org/D154301 _

[PATCH] D154301: Fix aggregate CTAD with string literals adding extra const

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92f4bf268998: Fix aggregate CTAD with string literals adding extra const (authored by MitalAshok, committed by ychen). Repository: rG LLVM Github

[PATCH] D74456: Reland "[Support] make report_fatal_error `abort` instead of `exit`"

ychen added a comment. In D74456#1871238 , @MaskRay wrote: > `ninja check-llvm check-clang` passed on a powerpc64le machine. Thanks for the review. Fingers crossed sanitizer bots not complain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

ychen added a comment. There are some interesting failures that need to be investigated. https://reviews.llvm.org/rG647c3f4e47de8a850ffcaa897db68702d8d2459a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67847/new/ https://reviews.llvm.org/D67847

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

ychen added a comment. In D67847#1847757 , @rnk wrote: > If we can reland this patch, it should fix this new clang bug: > https://bugs.llvm.org/show_bug.cgi?id=44705 > > This was the list of failures you noted on the commit: > > In rG647c3f4e47de8a850ffca

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen added a comment. In D127259#4156314 , @erichkeane wrote: > I don't see much compile-time concerns myself, Indeed. http://llvm-compile-time-tracker.com/compare.php?from=54faf22f7b947464a070669711100211e87f3ea8&to=ad87d0dbd44f3a8f66c31fa9b731aea34c

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen updated this revision to Diff 502068. ychen added a comment. This revision is now accepted and ready to land. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127259/new/ https://reviews.llvm.org/D127259 Files: clang/include/clang/Se

<    1   2   3   4   5   6   7   >